---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/#review29842
---
When we create Tasks (e.g. in Master::launchTask) we should add a
On Dec. 5, 2013, 10:32 p.m., Ben Mahler wrote:
When we create Tasks (e.g. in Master::launchTask) we should add a
corresponding status for the Task, can you take that up in a subsequent
patch?
There are a few spots in the master/slave where a task is created with no
corresponding
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/#review28884
---
Ship it!
src/exec/exec.cpp
On Nov. 14, 2013, 7:06 p.m., Vinod Kone wrote:
src/exec/exec.cpp, line 498
https://reviews.apache.org/r/14434/diff/6/?file=383873#file383873line498
May be only set this if it's not already set by the executor? Silently
overwriting is a bit concerning.
Brenden Matthews wrote:
On Nov. 14, 2013, 7:19 p.m., Ross Allen wrote:
src/webui/master/static/js/controllers.js, line 224
https://reviews.apache.org/r/14434/diff/7/?file=384705#file384705line224
All other timestamps in JS are unmodified, stored as seconds, and then
the '* 1000' is done in the view.
On Nov. 14, 2013, 7:06 p.m., Vinod Kone wrote:
src/exec/exec.cpp, line 498
https://reviews.apache.org/r/14434/diff/6/?file=383873#file383873line498
May be only set this if it's not already set by the executor? Silently
overwriting is a bit concerning.
Brenden Matthews wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/
---
(Updated Nov. 13, 2013, 10:17 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/#review28844
---
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 13, 2013, 10:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/#review28850
---
I'll hold off on merging this until I hear from some of the others.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/
---
(Updated Oct. 31, 2013, 8 p.m.)
Review request for mesos and Benjamin Hindman.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/#review27947
---
src/webui/master/static/framework.html
On Oct. 31, 2013, 7:09 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 1427-1435
https://reviews.apache.org/r/14434/diff/5/?file=371838#file371838line1427
We should wipe the 'data' and 'message' as they may be arbitrarily
large.
s/TaskStatus */TaskStatus* /
On Oct. 31, 2013, 8:06 p.m., Ross Allen wrote:
src/webui/master/static/framework.html, line 98
https://reviews.apache.org/r/14434/diff/5/?file=371840#file371840line98
Knowing that statuses[0] is the start time and statuses[statuses.length
- 1] should stay either in Mesos or in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/#review27997
---
Ship it!
This LGTM barring the tooltip comments from Ross!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14434/
---
(Updated Oct. 26, 2013, 1:48 a.m.)
Review request for mesos.
Changes
---
15 matches
Mail list logo
