Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-11-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14847/#review28134 --- include/mesos/mesos.proto

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-11-04 Thread Benjamin Hindman
On Nov. 4, 2013, 8:24 p.m., Vinod Kone wrote: include/mesos/mesos.proto, lines 179-180 https://reviews.apache.org/r/14847/diff/2/?file=370571#file370571line179 Sorry didn't review this earlier but there are couple of issues with this. SlaveInfo is checkpointed, so

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-23 Thread Benjamin Hindman
On Oct. 22, 2013, 6:01 p.m., Brenden Matthews wrote: It may also be worth looking at these: https://reviews.apache.org/r/11108/ https://reviews.apache.org/r/11975/ This is how we accomplish the same thing. Niklas Nielsen wrote: Hi Brenden, Thanks for the

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-23 Thread Brenden Matthews
On Oct. 22, 2013, 6:01 p.m., Brenden Matthews wrote: It may also be worth looking at these: https://reviews.apache.org/r/11108/ https://reviews.apache.org/r/11975/ This is how we accomplish the same thing. Niklas Nielsen wrote: Hi Brenden, Thanks for the

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-23 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14847/#review27438 --- src/tests/script.cpp

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14847/ --- (Updated Oct. 24, 2013, 3:26 a.m.) Review request for mesos and Benjamin

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Niklas Nielsen
On Oct. 22, 2013, 6:01 p.m., Brenden Matthews wrote: It may also be worth looking at these: https://reviews.apache.org/r/11108/ https://reviews.apache.org/r/11975/ This is how we accomplish the same thing. Hi Brenden, Thanks for the pointers! Was there any particular push-back

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Brenden Matthews
On Oct. 22, 2013, 6:01 p.m., Brenden Matthews wrote: It may also be worth looking at these: https://reviews.apache.org/r/11108/ https://reviews.apache.org/r/11975/ This is how we accomplish the same thing. Niklas Nielsen wrote: Hi Brenden, Thanks for the

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14847/#review27337 --- src/slave/slave.cpp

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Niklas Nielsen
On Oct. 22, 2013, 10:25 p.m., Benjamin Hindman wrote: src/slave/slave.cpp, line 226 https://reviews.apache.org/r/14847/diff/1/?file=369207#file369207line226 Can we check that this is a valid hostname? I.e., does this hostname resolve to one of the available IP addresses on this

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Benjamin Hindman
But does this check if the hostname resolves to one of the IPs addressable on this machine? I.e., an IP address we can bind to? On Tue, Oct 22, 2013 at 3:59 PM, Niklas Nielsen n...@qni.dk wrote: On Oct. 22, 2013, 10:25 p.m., Benjamin Hindman wrote: src/slave/slave.cpp, line 226

Re: Review Request 14847: Added --hostname flag to slave and removed webui_hostname.

2013-10-22 Thread Niklas Nielsen
On Oct. 22, 2013, 10:25 p.m., Benjamin Hindman wrote: src/slave/slave.cpp, line 226 https://reviews.apache.org/r/14847/diff/1/?file=369207#file369207line226 Can we check that this is a valid hostname? I.e., does this hostname resolve to one of the available IP addresses on this