---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 25, 2014, 5:10 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review54549
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 25, 2014, 6:25 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review54463
---
The last nits: looks good to me, but would like BenH to take a look
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 23, 2014, 5:30 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 22, 2014, 5:30 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review54238
---
Ship it!
Looks great! A few minor nits and a request for a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review53949
---
Mostly just style stuff, after a quick cleanup we'll get this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 19, 2014, 6:37 p.m.)
Review request for mesos and Benjamin
On Sept. 19, 2014, 10:25 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 205
https://reviews.apache.org/r/25789/diff/4/?file=694225#file694225line205
At first I was expecting strings::join to just be variadic on
std::string (like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review53862
---
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
On Sept. 18, 2014, 8:11 p.m., Dominic Hamon wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 190
https://reviews.apache.org/r/25789/diff/1/?file=693848#file693848line190
given that we test for variadic template support in configure, do you
think we still
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 18, 2014, 10:22 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review53891
---
It seems we have mixed use of const char * and std::string in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 18, 2014, 11:10 p.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/#review53898
---
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25789/
---
(Updated Sept. 19, 2014, 12:36 a.m.)
Review request for mesos and Benjamin
17 matches
Mail list logo
