Re: Review Request 26071: Sample isolator module.

2014-10-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 22, 2014, 4:04 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 22, 2014, 1:51 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review57648 --- LGTM - one last question below. BenH - any last comments?

Re: Review Request 26071: Sample isolator module.

2014-10-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 21, 2014, 5:35 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-20 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 20, 2014, 8:56 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-20 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review57506 --- Ship it! Ship It! - Niklas Nielsen On Oct. 20, 2014, 5:56 p.m.,

Re: Review Request 26071: Sample isolator module.

2014-10-19 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 20, 2014, 1:42 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 18, 2014, 3:10 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-18 Thread Kapil Arya
On Oct. 16, 2014, 6:24 p.m., Niklas Nielsen wrote: src/tests/isolator_tests.cpp, lines 129-130 https://reviews.apache.org/r/26071/diff/6/?file=723152#file723152line129 Don't know if we have any specific wrapping rules wrt very long templates. This looks off to me - but let's look

Re: Review Request 26071: Sample isolator module.

2014-10-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 16, 2014, 3:19 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 16, 2014, 3:20 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review57013 --- src/Makefile.am https://reviews.apache.org/r/26071/#comment97452

Re: Review Request 26071: Sample isolator module.

2014-10-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 11:50 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 11:50 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 12:52 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-10-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review56740 --- Patch looks great! Reviews applied: [26071] All tests passed. -

Re: Review Request 26071: Sample isolator module.

2014-10-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review56742 --- src/examples/test_isolator_module.cpp

Re: Review Request 26071: Sample isolator module.

2014-10-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Oct. 15, 2014, 9:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-09-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/#review54652 --- Patch looks great! Reviews applied: [25848, 26071] All tests

Re: Review Request 26071: Sample isolator module.

2014-09-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Sept. 26, 2014, 11:32 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 26071: Sample isolator module.

2014-09-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- (Updated Sept. 26, 2014, 5:57 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 26071: Sample isolator module.

2014-09-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26071/ --- Review request for mesos, Bernd Mathiske and Niklas Nielsen. Bugs: MESOS-1384