Re: Review Request 29329: Add executor for docker containerizer

2015-04-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- (Updated April 7, 2015, 12:39 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29329: Add executor for docker containerizer

2015-04-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- (Updated April 7, 2015, 12:34 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29329: Add executor for docker containerizer

2015-03-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/#review77312 --- Hey Tim. Made some comments on the doc. Mainly, I'm interested in

Re: Review Request 29329: Add executor for docker containerizer

2015-02-20 Thread Timothy Chen
Sorry about that! I just relaxed the perms so can anyone can edit/comment. Tim On Thu, Feb 19, 2015 at 7:58 PM, Vinod Kone vinodk...@gmail.com wrote: Thanks Tim for the doc. Can you open it up for comments (it's currently view only)? On Thu, Feb 19, 2015 at 5:15 PM, Timothy Chen

Re: Review Request 29329: Add executor for docker containerizer

2015-02-19 Thread Vinod Kone
Thanks Tim for the doc. Can you open it up for comments (it's currently view only)? On Thu, Feb 19, 2015 at 5:15 PM, Timothy Chen tnac...@apache.org wrote: On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: How are we going to manage the duplication across the command executor and the docker

Re: Review Request 29329: Add executor for docker containerizer

2015-02-19 Thread Timothy Chen
On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: How are we going to manage the duplication across the command executor and the docker executor? Timothy Chen wrote: I think I'm going to leave them seperate as they most likely will grow independent in tangent. The docker

Re: Review Request 29329: Add executor for docker containerizer

2015-02-13 Thread Bill Farner
On Feb. 3, 2015, 11:23 p.m., Bill Farner wrote: Is there a shortcoming in the executor API that prevents this from being an independent binary? Timothy Chen wrote: Hi Bill, this is going to be a binary on itself just like command exexutor. Do you have something else in mind?

Re: Review Request 29329: Add executor for docker containerizer

2015-02-13 Thread Timothy Chen
On Feb. 3, 2015, 11:23 p.m., Bill Farner wrote: Is there a shortcoming in the executor API that prevents this from being an independent binary? Timothy Chen wrote: Hi Bill, this is going to be a binary on itself just like command exexutor. Do you have something else in mind?

Re: Review Request 29329: Add executor for docker containerizer

2015-02-05 Thread Steve Niemitz
On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: How are we going to manage the duplication across the command executor and the docker executor? Timothy Chen wrote: I think I'm going to leave them seperate as they most likely will grow independent in tangent. The docker

Re: Review Request 29329: Add executor for docker containerizer

2015-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/#review70849 --- Is there a shortcoming in the executor API that prevents this from

Re: Review Request 29329: Add executor for docker containerizer

2015-02-03 Thread Timothy Chen
On Feb. 3, 2015, 11:23 p.m., Bill Farner wrote: Is there a shortcoming in the executor API that prevents this from being an independent binary? Hi Bill, this is going to be a binary on itself just like command exexutor. Do you have something else in mind? - Timothy

Re: Review Request 29329: Add executor for docker containerizer

2015-02-03 Thread Ben Mahler
On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: How are we going to manage the duplication across the command executor and the docker executor? Timothy Chen wrote: I think I'm going to leave them seperate as they most likely will grow independent in tangent. The docker

Re: Review Request 29329: Add executor for docker containerizer

2015-01-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- (Updated Jan. 17, 2015, 1:26 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29329: Add executor for docker containerizer

2015-01-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/#review68533 --- How are we going to manage the duplication across the command

Re: Review Request 29329: Add executor for docker containerizer

2015-01-16 Thread Timothy Chen
On Jan. 17, 2015, 1:39 a.m., Ben Mahler wrote: How are we going to manage the duplication across the command executor and the docker executor? I think I'm going to leave them seperate as they most likely will grow independent in tangent. The docker executor is solely responsible for

Re: Review Request 29329: Add executor for docker containerizer

2015-01-09 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/#review67433 --- Ship it! Ship It! - Bernd Mathiske On Jan. 8, 2015, 5:20 p.m.,

Re: Review Request 29329: Add executor for docker containerizer

2015-01-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- (Updated Jan. 9, 2015, 1:20 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29329: Add executor for docker containerizer

2015-01-08 Thread Timothy Chen
On Jan. 8, 2015, 11:27 a.m., Bernd Mathiske wrote: src/docker/executor.cpp, line 165 https://reviews.apache.org/r/29329/diff/1/?file=798951#file798951line165 This cryptic statement is worth a comment (maybe mention man waitpid? Or mention higher up in this code that the status

Re: Review Request 29329: Add executor for docker containerizer

2015-01-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/#review67035 --- What bug ID does this refer to? Any tests? Does this work already?

Re: Review Request 29329: Add executor for docker containerizer

2015-01-08 Thread Timothy Chen
On Jan. 8, 2015, 11:27 a.m., Bernd Mathiske wrote: src/docker/executor.cpp, line 189 https://reviews.apache.org/r/29329/diff/1/?file=798951#file798951line189 This stems from copied code. Any ideas how to do this properly? We probably need to add some visibility under libprocess, or

Re: Review Request 29329: Add executor for docker containerizer

2015-01-08 Thread Timothy Chen
On Jan. 8, 2015, 11:27 a.m., Bernd Mathiske wrote: What bug ID does this refer to? Any tests? Does this work already? This is a refactor and able to easier recover when the slave is running under a docker container. All the docker tests inheriently test this executor since it's part of

Re: Review Request 29329: Add executor for docker containerizer

2015-01-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- (Updated Jan. 6, 2015, 10:16 p.m.) Review request for mesos, Benjamin Hindman

Review Request 29329: Add executor for docker containerizer

2014-12-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git

Re: Review Request 29329: Add executor for docker containerizer

2014-12-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29329/ --- (Updated Dec. 22, 2014, 11:47 p.m.) Review request for mesos and Benjamin