Re: symmetry of pluggable authentication classes?

2009-11-13 Thread Shawn Pearce
On Fri, Oct 30, 2009 at 11:27, Daniel Kahn Gillmor d...@fifthhorseman.net wrote:  http://mina.apache.org/sshd/configuring-security.html Also, should either authenticator do anything with the ServerSession object passed in?  There does not seem to be any comment about that parameter in the

Re: symmetry of pluggable authentication classes?

2009-11-13 Thread Guillaume Nodet
Yeah, it may make more sense to always return a boolean then. Wdyt ? Btw, I've done quite a bit of refactoring on the shell / commands interfaces, so it will break any existing app (though the changes are quite easy to do). On Fri, Nov 13, 2009 at 16:00, Shawn Pearce s...@google.com wrote: On

Re: symmetry of pluggable authentication classes?

2009-11-13 Thread Shawn Pearce
On Fri, Nov 13, 2009 at 09:08, Guillaume Nodet gno...@gmail.com wrote: Yeah, it may make more sense to always return a boolean then.  Wdyt ? I think boolean makes more sense as a return, its the result of the authentication operation, true they are permitted, false they are not. If the

Re: symmetry of pluggable authentication classes?

2009-11-12 Thread Guillaume Nodet
You're right. I'll raise a JIRA and fix those interfaces. Thx for reporting. On Fri, Oct 30, 2009 at 20:27, Daniel Kahn Gillmor d...@fifthhorseman.net wrote: hey folks-- i just learned about mina -- looks neat, thanks for offering it! i'm interested in the configurable authentication