[jira] [Work logged] (SSHD-1303) Keeping error streams and input streams separate after ChannelExec#setRedirectErrorStream(true) is called

2022-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1303?focusedWorklogId=819026=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819026 ] ASF GitHub Bot logged work on SSHD-1303: Author: ASF GitHub Bot

[jira] [Work logged] (SSHD-1303) Keeping error streams and input streams separate after ChannelExec#setRedirectErrorStream(true) is called

2022-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1303?focusedWorklogId=819090=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819090 ] ASF GitHub Bot logged work on SSHD-1303: Author: ASF GitHub Bot

[jira] [Resolved] (SSHD-1303) Keeping error streams and input streams separate after ChannelExec#setRedirectErrorStream(true) is called

2022-10-21 Thread Thomas Wolf (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wolf resolved SSHD-1303. --- Fix Version/s: 2.9.2 Resolution: Fixed PR merged. > Keeping error streams and input streams

[GitHub] [mina-sshd] tomaswolf merged pull request #255: [SSHD-1303] AbstractClientChannel: use null stream for redirected stderr

2022-10-21 Thread GitBox
tomaswolf merged PR #255: URL: https://github.com/apache/mina-sshd/pull/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Work logged] (SSHD-1303) Keeping error streams and input streams separate after ChannelExec#setRedirectErrorStream(true) is called

2022-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1303?focusedWorklogId=819080=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819080 ] ASF GitHub Bot logged work on SSHD-1303: Author: ASF GitHub Bot

[GitHub] [mina-sshd] lgoldstein commented on pull request #255: [SSHD-1303] AbstractClientChannel: use null stream for redirected stderr

2022-10-21 Thread GitBox
lgoldstein commented on PR #255: URL: https://github.com/apache/mina-sshd/pull/255#issuecomment-1286753864 >> Then let's delay doing so to that future until a second concrete use case for this comes up My personal philosophy is that if something is relatively simple, generic enough

[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #255: [SSHD-1303] AbstractClientChannel: use null stream for redirected stderr

2022-10-21 Thread GitBox
tomaswolf commented on code in PR #255: URL: https://github.com/apache/mina-sshd/pull/255#discussion_r1001428599 ## sshd-core/src/main/java/org/apache/sshd/client/channel/AbstractClientChannel.java: ## @@ -474,4 +494,48 @@ public Integer getExitStatus() { public String

[jira] [Assigned] (SSHD-1302) Handling empty ChannelExec#getInvertedOut() to rely on InputStream

2022-10-21 Thread Thomas Wolf (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wolf reassigned SSHD-1302: - Assignee: Thomas Wolf > Handling empty ChannelExec#getInvertedOut() to rely on InputStream >

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #256: [SSHD-1302] AbstractClientChannel: don't close inverted output streams

2022-10-21 Thread GitBox
tomaswolf opened a new pull request, #256: URL: https://github.com/apache/mina-sshd/pull/256 Closing them when the channel closes leads to the strange situation that the application reads from an already closed InputStream. That's not a good idea. It's the caller's responsibility to

[jira] [Updated] (SSHD-1302) Handling empty ChannelExec#getInvertedOut() to rely on InputStream

2022-10-21 Thread Thomas Wolf (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wolf updated SSHD-1302: -- Issue Type: Bug (was: Improvement) > Handling empty ChannelExec#getInvertedOut() to rely on

[jira] [Commented] (SSHD-1302) Handling empty ChannelExec#getInvertedOut() to rely on InputStream

2022-10-21 Thread Thomas Wolf (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17622470#comment-17622470 ] Thomas Wolf commented on SSHD-1302: --- Thanks for this report. IMO this is simply broken, and should be

[jira] [Updated] (SSHD-1302) Reading again from exhausted ChannelExec#getInvertedOut() throws IOException instead of returning -1

2022-10-21 Thread Thomas Wolf (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wolf updated SSHD-1302: -- Priority: Minor (was: Major) > Reading again from exhausted ChannelExec#getInvertedOut() throws

[jira] [Work logged] (SSHD-1302) Handling empty ChannelExec#getInvertedOut() to rely on InputStream

2022-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1302?focusedWorklogId=819257=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-819257 ] ASF GitHub Bot logged work on SSHD-1302: Author: ASF GitHub Bot

[jira] [Updated] (SSHD-1302) Reading again from exhausted ChannelExec#getInvertedOut() throws IOException instead of returning -1

2022-10-21 Thread Thomas Wolf (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wolf updated SSHD-1302: -- Summary: Reading again from exhausted ChannelExec#getInvertedOut() throws IOException instead of

[jira] [Updated] (SSHD-1303) Keeping error streams and input streams separate after ChannelExec#setRedirectErrorStream(true) is called

2022-10-21 Thread Thomas Wolf (Jira)
[ https://issues.apache.org/jira/browse/SSHD-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wolf updated SSHD-1303: -- Issue Type: Bug (was: Improvement) > Keeping error streams and input streams separate after >