[GitHub] [mina-sshd] lgoldstein commented on a diff in pull request #362: Fix rooted filesystem

lgoldstein commented on code in PR #362: URL: https://github.com/apache/mina-sshd/pull/362#discussion_r1172872427 ## sshd-common/src/main/java/org/apache/sshd/common/util/io/IoUtils.java: ## @@ -637,4 +677,75 @@ public static List readAllLines(BufferedReader reader, int

[GitHub] [mina-sshd] HannesWell commented on pull request #343: Simplify maven-bundle-plugin configuration

HannesWell commented on PR #343: URL: https://github.com/apache/mina-sshd/pull/343#issuecomment-1516653451 > > @gnodet, would you be available beginning of May to do a new release? > > I'll try to do that next week. Is there any remaining issue/PR to look at ? Thanks! --

[GitHub] [mina-sshd] lgoldstein commented on a diff in pull request #362: Fix rooted filesystem

lgoldstein commented on code in PR #362: URL: https://github.com/apache/mina-sshd/pull/362#discussion_r1172862559 ## sshd-common/src/main/java/org/apache/sshd/common/file/root/RootedDirectoryStream.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [mina-sshd] lgoldstein commented on a diff in pull request #362: Fix rooted filesystem

lgoldstein commented on code in PR #362: URL: https://github.com/apache/mina-sshd/pull/362#discussion_r1172873194 ## sshd-common/src/main/java/org/apache/sshd/common/util/io/IoUtils.java: ## @@ -637,4 +677,75 @@ public static List readAllLines(BufferedReader reader, int

[GitHub] [mina-sshd] tomaswolf commented on pull request #362: Fix rooted filesystem

tomaswolf commented on PR #362: URL: https://github.com/apache/mina-sshd/pull/362#issuecomment-1516999345 It would be extremely helpful to have meaningful commit messages. Just "More unix like" is _not_ helpful. If someone looks at this code a few months or years from now he or she will