ecki commented on PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1872178463
Debian bookworm backported the strictkex fix, so you could use that
container (or maybe pinning Sid, it has the upstream fix, but that’s harder to
keep available in the long run)
--
This
lgoldstein commented on PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1872124954
> Please note that OpenSSH 8.9 does not have the strict KEX feature. The
first public version that does have it is OpenSSH 9.6. See the [OpenSSH release
lgoldstein commented on PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1872125946
> As you're a committer and PMC member I cannot stop you from merging this,
but I fundamentally disagree with this change.
Then I won't - until at least we reach some agreement
lgoldstein commented on PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1872126240
> As for the reformatting: of course I don't know how it happened... it
looks to me as if your IDE reformatted the whole file to line length 80 on
save. We normally use a line length
lgoldstein commented on PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1872145739
> I'll try to put together a simpler PR over New Year.
I just had a thought - maybe you can test your code's interoperability with
mine as well as OpenSSH's and thus perhaps
lgoldstein commented on PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1872130789
Here are more settings - as can be seen, the "Format source code" option is
disabled. There is a very limited set of actions that it is set up to do on save
lgoldstein commented on PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1872153855
> I cannot stop you from merging this, but I fundamentally disagree with
this change.
> Implementing strict KEX is about a 20, maybe 30-line change in
AbstractSession
lgoldstein commented on PR #446:
URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1872128342
Nope - my
> it looks to me as if your IDE reformatted the whole file to line length
80 on save.
Does not look that way...
