[jira] [Commented] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time
[ https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935748#comment-15935748 ] Goldstein Lyor commented on SSHD-732: - I believe the problem is related to some kind of bug in the implementation of spliteraror for the keys iterable. I was able to zoom into some issue with the UserAuthPublicKeysIterator > ClientIdentitiesWatcher should load keys one at a time > -- > > Key: SSHD-732 > URL: https://issues.apache.org/jira/browse/SSHD-732 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Critical > > The keys are loaded into a List instead of using an > Iterable which could allow lazy loading the keys. > The problem is that loading keys can require passwords, thus asking the user > for passwords which may not be used. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time
[ https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor updated SSHD-732: Fix Version/s: (was: 1.5.0) > ClientIdentitiesWatcher should load keys one at a time > -- > > Key: SSHD-732 > URL: https://issues.apache.org/jira/browse/SSHD-732 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Critical > > The keys are loaded into a List instead of using an > Iterable which could allow lazy loading the keys. > The problem is that loading keys can require passwords, thus asking the user > for passwords which may not be used. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time
[ https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor updated SSHD-732: Issue Type: Bug (was: Improvement) > ClientIdentitiesWatcher should load keys one at a time > -- > > Key: SSHD-732 > URL: https://issues.apache.org/jira/browse/SSHD-732 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Minor > > The keys are loaded into a List instead of using an > Iterable which could allow lazy loading the keys. > The problem is that loading keys can require passwords, thus asking the user > for passwords which may not be used. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time
[ https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor updated SSHD-732: Priority: Critical (was: Minor) > ClientIdentitiesWatcher should load keys one at a time > -- > > Key: SSHD-732 > URL: https://issues.apache.org/jira/browse/SSHD-732 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 1.4.0 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Critical > > The keys are loaded into a List instead of using an > Iterable which could allow lazy loading the keys. > The problem is that loading keys can require passwords, thus asking the user > for passwords which may not be used. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time
[
https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15934795#comment-15934795
]
Goldstein Lyor edited comment on SSHD-732 at 3/21/17 4:05 PM:
--
Hi Guillaume,
Have you run full unit tests on the code ? I am getting quite a few failures -
I have fixed one, but there are others that are failing for reasons beyond me
(I have not had time to explore them in depth). Specifically,:
* The code for {{BuiltinClientIdentitiesWatcherTest#testMultipleFilesWatch}}
has to be fixed as follows:
{code:java}
Iterable keys = watcher.loadKeys();
Collection actual = new ArrayList<>();
for (KeyPair kp : keys) {
actual.add(kp);
}
{code}
* {{AuthenticationTest#testPublicKeyAuthDifferentThanKex}} now fails
consistently.
If you want a debuggable version to work on (one that also contains EDDSA and
compiles) then check out [my clone|https://github.com/lgoldstein/mina-sshd] and
switch to `eddsa` branch
was (Author: lgoldstein):
Hi Guillaume,
Have you run full unit tests on the code ? I am getting quite a few failures -
I have fixed one, but there are others that are failing for reasons beyond me
(I have not had time to explore them in depth). Specifically,:
* The code for {{BuiltinClientIdentitiesWatcherTest#testMultipleFilesWatch}}
has to be fixed as follows:
{code:java}
Iterable keys = watcher.loadKeys();
Collection actual = new ArrayList<>();
for (KeyPair kp : keys) {
actual.add(kp);
}
{code}
* {{AuthenticationTest#testPublicKeyAuthDifferentThanKex}} now fails
consistently.
> ClientIdentitiesWatcher should load keys one at a time
> --
>
> Key: SSHD-732
> URL: https://issues.apache.org/jira/browse/SSHD-732
> Project: MINA SSHD
> Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 1.5.0
>
>
> The keys are loaded into a List instead of using an
> Iterable which could allow lazy loading the keys.
> The problem is that loading keys can require passwords, thus asking the user
> for passwords which may not be used.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Reopened] (SSHD-732) ClientIdentitiesWatcher should load keys one at a time
[
https://issues.apache.org/jira/browse/SSHD-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Goldstein Lyor reopened SSHD-732:
-
Hi Guillaume,
Have you run full unit tests on the code ? I am getting quite a few failures -
I have fixed one, but there are others that are failing for reasons beyond me
(I have not had time to explore them in depth). Specifically,:
* The code for {{BuiltinClientIdentitiesWatcherTest#testMultipleFilesWatch}}
has to be fixed as follows:
{code:java}
Iterable keys = watcher.loadKeys();
Collection actual = new ArrayList<>();
for (KeyPair kp : keys) {
actual.add(kp);
}
{code}
* {{AuthenticationTest#testPublicKeyAuthDifferentThanKex}} now fails
consistently.
> ClientIdentitiesWatcher should load keys one at a time
> --
>
> Key: SSHD-732
> URL: https://issues.apache.org/jira/browse/SSHD-732
> Project: MINA SSHD
> Issue Type: Improvement
>Affects Versions: 1.4.0
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 1.5.0
>
>
> The keys are loaded into a List instead of using an
> Iterable which could allow lazy loading the keys.
> The problem is that loading keys can require passwords, thus asking the user
> for passwords which may not be used.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
