[jira] Created: (MYFACES-344) component method's visibility review

2005-07-21 Thread Csaba Sebastian (JIRA)
component method's visibility review Key: MYFACES-344 URL: http://issues.apache.org/jira/browse/MYFACES-344 Project: MyFaces Type: Improvement Versions: Nightly Build Reporter: Csaba Sebastian The extension of the

[jira] Created: (MYFACES-345) x:navigationMenuItem should have target attribute and can include f:param in it's body

2005-07-21 Thread lantian (JIRA)
x:navigationMenuItem should have target attribute and can include f:param in it's body Key: MYFACES-345 URL: http://issues.apache.org/jira/browse/MYFACES-345 Project: MyFaces

[proposal] JavaDoc from the spec?

2005-07-21 Thread Bill Dudney
Hi All, Is there an issue with copying the javadoc from the spec classes? I remember someone said we could not use the jsf-api.jar file a long time ago but the java doc is part of the spec. We should be able to copy that correct? So I'd like to propose that as I'm adding tests to the

Re: [proposal] JavaDoc from the spec?

2005-07-21 Thread Bruno Aranda
+1 For me it is better to introduce a new dependency if we can create better tests (and faster) than using nasty workarounds... Bruno 2005/7/21, Bill Dudney [EMAIL PROTECTED]: Hi All, Is there an issue with copying the javadoc from the spec classes? I remember someone said we could not use

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Bruno Aranda
+1 For me it is better to introduce a new dependency if we can create better tests (and faster) than using nasty workarounds... Bruno P.S. Now in the correct place :-) 2005/7/21, Bill Dudney [EMAIL PROTECTED]: Hi All, I've got the first of the EasyMock (http://www.easymock.org) tests in

Re: [proposal] JavaDoc from the spec?

2005-07-21 Thread Mathias Broekelmann
+1 That would simplify implementing the spec and increase the usability of javadocs of myfaces. Bill Dudney schrieb: Hi All, Is there an issue with copying the javadoc from the spec classes? I remember someone said we could not use the jsf-api.jar file a long time ago but the java doc

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Mathias Broekelmann
+1 I haven´t use mockups before (shame on me ;)) but I would like to see it in action. Mathias Bill Dudney schrieb: Hi All, I've got the first of the EasyMock (http://www.easymock.org) tests in place. I have not commited the changes because I wanted to get everyone's opinion before

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Manfred Geiler
+1 dependencies for test compiling are ok, as long as there is no need to add them to our bin-releases! :-))) -Manfred 2005/7/21, Bill Dudney [EMAIL PROTECTED]: Hi All, I've got the first of the EasyMock (http://www.easymock.org) tests in place. I have not commited the changes because I

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Bill Dudney
The dependency will only be at development time. I've added them to the 'download-dependency' target in the build.xml file so you won't even have to know they are there :-) TTFN, -bd- On Jul 21, 2005, at 5:23 AM, Manfred Geiler wrote: +1 dependencies for test compiling are ok, as long

Re: [proposal] JavaDoc from the spec?

2005-07-21 Thread Manfred Geiler
Hello, any lawyer listening that *really* understands the Sun.CfcsSpec.license.11.14.2003? Is it allowed to copy and (re)use text from the spec. Would that be kind of reproduction, which is only allowed for private use according to the spec license? I don't know. -Manfred 2005/7/21, Bill

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Manfred Geiler
2005/7/21, Bill Dudney [EMAIL PROTECTED]: The dependency will only be at development time. Yes, of course. I was just kidding... :-) -Manfred

Re: [proposal] JavaDoc from the spec?

2005-07-21 Thread Sean Schofield
I'm +1 for that as long as Craig and Sun are +1 sean On 7/21/05, Manfred Geiler [EMAIL PROTECTED] wrote: Hello, any lawyer listening that *really* understands the Sun.CfcsSpec.license.11.14.2003? Is it allowed to copy and (re)use text from the spec. Would that be kind of reproduction, which

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Sean Schofield
+1 Bill. A *huge* thank you for taking the lead on this. In general I'm in favor of Mock Objects and more testing so however you want to do that is fine with me! sean On 7/21/05, Manfred Geiler [EMAIL PROTECTED] wrote: 2005/7/21, Bill Dudney [EMAIL PROTECTED]: The dependency will only be at

Re: [proposal] JavaDoc from the spec?

2005-07-21 Thread Martin Marinschek
I would say that yes, it is OK. we could of course just do it and see what happens ;) regards, MartinOn 7/21/05, Bill Dudney [EMAIL PROTECTED] wrote: From reading the license we will need a lawyer :-)Looks like paragraphs 2-5 are the important oneshttp://tinyurl.com/bd4hfI think paragraph 2

Re: [proposal] JavaDoc from the spec?

2005-07-21 Thread Bill Dudney
always easier to ask forgiveness than permission, I love it! :-)TTFN,-bd-On Jul 21, 2005, at 7:04 AM, Martin Marinschek wrote:I would say that yes, it is OK. we could of course just do it and see what happens ;) regards, MartinOn 7/21/05, Bill Dudney [EMAIL PROTECTED] wrote: From reading the

[jira] Created: (MYFACES-346) ExtensionFilter does not close output streams before retrieving response bytes

2005-07-21 Thread Dan Zehme (JIRA)
ExtensionFilter does not close output streams before retrieving response bytes -- Key: MYFACES-346 URL: http://issues.apache.org/jira/browse/MYFACES-346 Project: MyFaces Type: Bug

Re: Profiling and other

2005-07-21 Thread Bill Dudney
I would be very interested in this! The general idea I have about testing is that I'd like for us to have the ability to deploy to a container, start the container, run some tests (JMeter or Cactus) and capture the results. It would be cool to see your work and integrate it with the stuff

[jira] Closed: (MYFACES-346) ExtensionFilter does not close output streams before retrieving response bytes

2005-07-21 Thread Bruno Aranda (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-346?page=all ] Bruno Aranda closed MYFACES-346: Fix Version: Nightly Build Resolution: Fixed This should be solved in the next nightly build. Thanks for reporting! ExtensionFilter does not close

[jira] Closed: (MYFACES-343) Add onclick, ondblclick support for rows in x:dataTable

2005-07-21 Thread sean schofield (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-343?page=all ] sean schofield closed MYFACES-343: -- Fix Version: Nightly Build Resolution: Fixed Add onclick, ondblclick support for rows in x:dataTable

[jira] Commented: (MYFACES-344) component method's visibility review

2005-07-21 Thread sean schofield (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-344?page=comments#action_12316356 ] sean schofield commented on MYFACES-344: What components specifically are you talking about? component method's visibility review

[jira] Commented: (MYFACES-344) component method's visibility review

2005-07-21 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-344?page=comments#action_12316357 ] Mike Kienenberger commented on MYFACES-344: --- Or to put it another way: If you provide patches for visibility issues causing you problems, they'll probably be

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Grant Smith
+1 for EasyMock and it's dependencies. While we're at it, don't we need junit.jar too ? Also, I would recommend only downloading the dependencies if you run the 'test-all' (or 'test' for a subproject) target, not if you run the usual 'dist-all' that most people will be doing. Thanks for doing

[jira] Commented: (MYFACES-349) ActionListener in server-side tree2 does not get invoked when clicking the navigation icon

2005-07-21 Thread Brendan Conner (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-349?page=comments#action_12316366 ] Brendan Conner commented on MYFACES-349: Oops. The formatting didn't work out the way I had expected in my last post. Here's another copy of my JSP code, with

source code formatting

2005-07-21 Thread Mathias Broekelmann
I´ve some trouble with code formatting in the myfaces code. I like to write code in bad format and press CTRL+F in eclipse which pretty prints the code. But that normally formats the entire file. My last commit shows the results. Every line in the file seems to have changed but only format

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Bill Dudney
OK I've committed the changes. On the download dependencies, there is no real reason not to just download them (IMO) because it takes an additional 20 seconds the first time and then an additional 1 second thereafter (I made up the #'s but its not far off) so I'd just as soon not

[jira] Created: (MYFACES-350) Use 'node.isLeaf()' in tree2 to decide whether to display the navigation icon

2005-07-21 Thread Brendan Conner (JIRA)
Use 'node.isLeaf()' in tree2 to decide whether to display the navigation icon - Key: MYFACES-350 URL: http://issues.apache.org/jira/browse/MYFACES-350 Project: MyFaces Type: Improvement

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Bruno Aranda
Good!, I've just executed the tests. Look promissing! Thanks! Bruno 2005/7/21, Bill Dudney [EMAIL PROTECTED]: OK I've committed the changes. On the download dependencies, there is no real reason not to just download them (IMO) because it takes an additional 20 seconds the first time and

RE: source code formatting

2005-07-21 Thread Korhonen, Kalle
-Original Message- From: Mathias Broekelmann [mailto:[EMAIL PROTECTED] Subject: source code formatting I like to write code in bad format and press CTRL+F in eclipse which pretty prints the code. But that normally formats the entire file. My last commit shows the results. Every

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Bill Dudney
Hi Mike, I understand the point that it could take longer for slower connections. However, again IMO, if someone is doing development on myfaces they should be doing testing. And also IMO as a user of other projects I like to have a test target that I can use when building others software

hold up on updating...

2005-07-21 Thread Bill Dudney
Yes that is me that broke the build... fixing now and I'll repost when its all better Insert Pie In Face here ;- -bd-

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Mike Kienenberger
If all users were like me (permanent broadband connection), I'd agree :) Remember that some folks don't want the source to do development, they just have a requirement that all things must be built from source. Now, I'd think you'd also want to test it after the build, but again, that's just me.

Re: [proposal] JavaDoc from the spec?

2005-07-21 Thread Craig McClanahan
So, the question is about copying the JavaDocs from the RI's jsf-api.jar file, but not the code? I'm gonna have to ask what the precise rules are and get back to you on that. Craig On 7/21/05, Bruno Aranda [EMAIL PROTECTED] wrote: Sorry, that was the answer to the other proposal ;-) For

Re: source code formatting

2005-07-21 Thread Mathias Broekelmann
Not every one is using eclipse so in addition to the eclipse export I would like to write down the rules I use: Rules for source code formatting are based on Java Code Conventions (http://java.sun.com/docs/codeconv) except: - opening braces are on the next line except for array initializers

Re: source code formatting

2005-07-21 Thread Bruno Aranda
I've updated the wiki with the section MyFaces Developer Notes, which I have obained from the sources before the reorg (developer-notes.txt). There are a few lines about the code style... By the way, it would be nice to have a format file that comply with this conventions for eclipse... ;) Bruno

Re: hold up on updating...

2005-07-21 Thread Bill Dudney
Should be good to go now... $ ant unit-test-all TTFN, -bd- On Jul 21, 2005, at 10:32 AM, Bill Dudney wrote: Yes that is me that broke the build... fixing now and I'll repost when its all better Insert Pie In Face here ;- -bd-

Re: [proposal] JavaDoc from the spec?

2005-07-21 Thread Bill Dudney
Thanks for looking into this for us Craig. Seems like a big waste of effort for us to reinvent that wheel. Besides if we document the methods incorrectly we probably won't be spec compliant :-) TTFN, -bd- On Jul 21, 2005, at 10:43 AM, Craig McClanahan wrote: So, the question is about

Re: source code formatting

2005-07-21 Thread Mathias Broekelmann
I didn´t found a way to add a file to WIKI so I have attached it to this mail. If you know a way to add the content to WIKI please do it ;-) Cheers, Mathias Bruno Aranda schrieb: I've updated the wiki with the section MyFaces Developer Notes, which I have obained from the sources before the

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Sean Schofield
On the download dependencies, there is no real reason not to just download them (IMO) because it takes an additional 20 seconds the first time and then an additional 1 second thereafter (I made up the #'s but its not far off) so I'd just as soon not complicate matters by adding another target

Re: [proposal] JavaDoc from the spec?

2005-07-21 Thread Craig McClanahan
On 7/21/05, Bill Dudney [EMAIL PROTECTED] wrote: Thanks for looking into this for us Craig. Seems like a big waste of effort for us to reinvent that wheel. Besides if we document the methods incorrectly we probably won't be spec compliant :-) Hmm ... I don't remember any TCK tests that

Re: source code formatting

2005-07-21 Thread Sean Schofield
I noticed your recent changes were all messed up with the formatting. I think the guidelines you mentioned are consistent with what's been done in the past. Definitely spaces instead of tabs! sean On 7/21/05, Mathias Broekelmann [EMAIL PROTECTED] wrote: I didn´t found a way to add a file to

Re: source code formatting

2005-07-21 Thread Manfred Geiler
Mathias, perhaps this can help: http://wiki.apache.org/general/WikiFrequentlyAskedQuestions -Manfred 2005/7/21, Mathias Broekelmann [EMAIL PROTECTED]: I didn´t found a way to add a file to WIKI so I have attached it to this mail. If you know a way to add the content to WIKI please do it ;-)

Re: source code formatting

2005-07-21 Thread Manfred Geiler
Yes, that's close to what we prescribed in the developer-notes.txt file, fine! ;-) -Manfred 2005/7/21, Mathias Broekelmann [EMAIL PROTECTED]: Not every one is using eclipse so in addition to the eclipse export I would like to write down the rules I use: Rules for source code formatting are

[jira] Created: (MYFACES-351) Tree2 isssue (Summary)

2005-07-21 Thread Jon Travis (JIRA)
Tree2 isssue (Summary) -- Key: MYFACES-351 URL: http://issues.apache.org/jira/browse/MYFACES-351 Project: MyFaces Type: Bug Environment: All Reporter: Jon Travis This JIRA issue is in response to the upcomming tree2 summit. We would love

Re: source code formatting

2005-07-21 Thread Mathias Broekelmann
The faq doesn´t answer it but it was easy: Every page has a drop down for actions which contains an entry for attachements... :-)) Manfred Geiler schrieb: Mathias, perhaps this can help: http://wiki.apache.org/general/WikiFrequentlyAskedQuestions -Manfred 2005/7/21, Mathias Broekelmann [EMAIL

Contribution of component library planned, live demo available

2005-07-21 Thread Udo Schnurpfeil
Dear MyFaces-Team, after the MyFaces BOF on the ApacheCON 2005 we have talked to Martin and Matthias about our extensional faces-based component library Tobago. We showed them some of our online examples visible at http://tobago.atanion.net and we all agreed, that it is important to

[jira] Commented: (MYFACES-344) component method's visibility review

2005-07-21 Thread Csaba Sebastian (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-344?page=comments#action_12316423 ] Csaba Sebastian commented on MYFACES-344: - Specifically: - the Buffer component: I've added an attribute for something like lazy evaluation, but I can't access the

[ANNOUNCE] JavaOne JSF article

2005-07-21 Thread Kito D. Mann
Hello, I just wanted to let everyone know that I've posted an extensive write-up about JavaOne, focusing on JSF (and MyFaces as well). You can read the article here: http://www.jsfcentral.com/editorial/editorial_3.html. If I saw you at JavaOne, chances are you're mentioned in here :-). Kito

[jira] Created: (MYFACES-352) ForceId does not work when used with bindings

2005-07-21 Thread Sarodge Dechgan (JIRA)
ForceId does not work when used with bindings - Key: MYFACES-352 URL: http://issues.apache.org/jira/browse/MYFACES-352 Project: MyFaces Type: Bug Versions: Nightly Build Environment: Apache Tomcat/5.0.28