[
https://issues.apache.org/jira/browse/MYFACES-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796364#comment-16796364
]
maurel commented on MYFACES-4281:
-
Thank you for the time you spent on this issue.
> tag parsing error
[
https://issues.apache.org/jira/browse/MYFACES-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4281.
Resolution: Fixed
Thanks to [~jfrm.mau...@gmail.com]!
> tag parsing error
>
tandraschko merged pull request #49: Myfaces-4281
URL: https://github.com/apache/myfaces/pull/49
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tandraschko commented on issue #49: Myfaces-4281
URL: https://github.com/apache/myfaces/pull/49#issuecomment-474455355
Looks good now!
Very good contribution - thanks.
I will port it to 2.3.x.
This is an automated
tandraschko commented on issue #49: Myfaces-4281
URL: https://github.com/apache/myfaces/pull/49#issuecomment-474340305
at best disable the eclipse autoformatting and re-apply your changes.
You can then refresh your PR or create a new PR (please google about that)
jfmaurel commented on issue #49: Myfaces-4281
URL: https://github.com/apache/myfaces/pull/49#issuecomment-474339965
Sorry for that, I used my own settings in Eclipse by inadvertance.
What should I do now to correct that ?
tandraschko commented on issue #49: Myfaces-4281
URL: https://github.com/apache/myfaces/pull/49#issuecomment-474336922
Great contribution!
Could you please don't change our formattings? Otherwise it's hard to check
changes and we have a own checkstyle in MyFaces.
jfmaurel opened a new pull request #49: Myfaces-4281
URL: https://github.com/apache/myfaces/pull/49
changes in o.a.m..view.facelets.compiler.SAXCompiler (skip html namespaces
unit compilation)
add org.apache.myfaces.view.facelets.compiler;SkipNamespaceUnitTest.java
add test resource
