Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Thomas Andraschko
I thought that you manually added -PcheckJDK into the mvn cmd? If yes: IMO we can just call it an "optional step" which needs to be checked; In this case now it fails but we know that that IllegalXmlCharacterFilterWriter is working fine on java1.6 Am Mi., 29. Apr. 2020 um 16:46 Uhr schrieb Paul

Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Paul Nicolucci
What do you mean by: "ignore the IllegalXmlCharacterFilterWriter from the checkJDK result "manually", the checkJDK is a optional thing in the build process. right? we already removed it in 2.3 and later" Is there something we need to add in the poms or should we just use : @IgnoreJRERequirement?

[jira] [Commented] (MYFACES-4333) ElContext#getFunctionMapper returns null

2020-04-29 Thread Bill Lucy (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095480#comment-17095480 ] Bill Lucy commented on MYFACES-4333: [~tandraschko] I'm not sure if it's possible to get a

Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Thomas Andraschko
Commited it, please review Am Mi., 29. Apr. 2020 um 15:28 Uhr schrieb Thomas Andraschko < andraschko.tho...@gmail.com>: > I tried to configure the animal-sniffer to exclude the class and also > tried another plugin. I didnt find a way to exclude it. > > I would do the following: > -

[jira] [Commented] (MYFACES-4333) ElContext#getFunctionMapper returns null

2020-04-29 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095475#comment-17095475 ] Thomas Andraschko commented on MYFACES-4333: changed it, please review >

Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Thomas Andraschko
I tried to configure the animal-sniffer to exclude the class and also tried another plugin. I didnt find a way to exclude it. I would do the following: - IllegalXmlCharacterFilterWriter wont be registered for java 1.6, i will add it this now - ignore the IllegalXmlCharacterFilterWriter from the

Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Thomas Andraschko
Puh, no idea but i would just delete it Am Mi., 29. Apr. 2020 um 14:53 Uhr schrieb Paul Nicolucci < pnicolu...@gmail.com>: > Yea I think that would work! > > Looks like I'll need to manually delete the 2.2.13 tag? Doesn't look like > the release plugin rollback actually did that. The rollback

Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Paul Nicolucci
Yea I think that would work! Looks like I'll need to manually delete the 2.2.13 tag? Doesn't look like the release plugin rollback actually did that. The rollback did revert the commits that were made so that was at least helpful. I dropped the repo in nexus as well.

Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Thomas Andraschko
Oh, stop this would not fix the build, just runtime :D maybe we cann exclude this file + add the IF-statement? Am Mi., 29. Apr. 2020 um 14:43 Uhr schrieb Thomas Andraschko < andraschko.tho...@gmail.com>: > I think we can also do something like: > if (java16) {

Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Thomas Andraschko
I think we can also do something like: if (java16) { registerIllegalXmlCharacterFilterWriter } i can easily add this Am Mi., 29. Apr. 2020 um 14:33 Uhr schrieb Paul Nicolucci < pnicolu...@gmail.com>: > In my opinion removing the security feature doesn't seem like a good > option although I'm

Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Paul Nicolucci
In my opinion removing the security feature doesn't seem like a good option although I'm not quite sure which part of this is related to security. Removing support for JRE 1.6 or rewriting the solution seem like better options to me. While we decide as a community how to move forward I'll work

[jira] [Resolved] (TOBAGO-2032) Images for tc:selectBooleanCheckbox

2020-04-29 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2032. -- Resolution: Fixed > Images for tc:selectBooleanCheckbox > ---

[jira] [Resolved] (TOBAGO-2033) Images for tc:selectBooleanToggle

2020-04-29 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2033. -- Resolution: Fixed > Images for tc:selectBooleanToggle > - > >

[jira] [Resolved] (MYFACES-4334) org.apache.myfaces.util.ExternalSpecifications isServlet4Available sometimes logged many times

2020-04-29 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4334. Resolution: Fixed > org.apache.myfaces.util.ExternalSpecifications

[jira] [Created] (MYFACES-4334) org.apache.myfaces.util.ExternalSpecifications isServlet4Available sometimes logged many times

2020-04-29 Thread Thomas Andraschko (Jira)
Thomas Andraschko created MYFACES-4334: -- Summary: org.apache.myfaces.util.ExternalSpecifications isServlet4Available sometimes logged many times Key: MYFACES-4334 URL:

Re: Status of MyFaces 2.3.6 and 2.2.13 releases

2020-04-29 Thread Thomas Andraschko
Hi Paul, no idea about the TCK. I think it's ok to release without it for now. Maybe we should check it again for a 3.0 Jakarta Release. About the Surrogate I think that method was introduced in JRE 1.7. What should we do here? We have the following options: - mark 2.2.13 to not support JRE

[jira] [Commented] (MYFACES-4333) ElContext#getFunctionMapper returns null

2020-04-29 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095139#comment-17095139 ] Thomas Andraschko commented on MYFACES-4333: [~wtlucy] / [~volosied]: Shouldnt we probably