[GitHub] [myfaces] bohmber merged pull request #134: MYFACES-4373: make sure SecureRandom is used for invalid configs

2021-01-13 Thread GitBox
bohmber merged pull request #134: URL: https://github.com/apache/myfaces/pull/134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [myfaces] wtlucy commented on pull request #134: MYFACES-4373: make sure SecureRandom is used for invalid configs

2021-01-13 Thread GitBox
wtlucy commented on pull request #134: URL: https://github.com/apache/myfaces/pull/134#issuecomment-759820899 > Can you apply the change for csrfRandomMode as well? Sure, done. I also realized that `StateCacheClientSide` needed to be updated.

[GitHub] [myfaces] bohmber merged pull request #133: MYFACES-4373: make sure SecureRandom is used for invalid configs 3.0.x

2021-01-13 Thread GitBox
bohmber merged pull request #133: URL: https://github.com/apache/myfaces/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [myfaces] tandraschko commented on pull request #133: MYFACES-4373: make sure SecureRandom is used for invalid configs 3.0.x

2021-01-13 Thread GitBox
tandraschko commented on pull request #133: URL: https://github.com/apache/myfaces/pull/133#issuecomment-759770834 +1 for both This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [myfaces] wtlucy opened a new pull request #134: MYFACES-4373: make sure SecureRandom is used for invalid configs

2021-01-13 Thread GitBox
wtlucy opened a new pull request #134: URL: https://github.com/apache/myfaces/pull/134 follow-on for https://issues.apache.org/jira/browse/MYFACES-4373 This is an automated message from the Apache Git Service. To respond to

[GitHub] [myfaces] wtlucy opened a new pull request #133: MYFACES-4373: make sure SecureRandom is used for invalid configs 3.0.x

2021-01-13 Thread GitBox
wtlucy opened a new pull request #133: URL: https://github.com/apache/myfaces/pull/133 follow-on for https://issues.apache.org/jira/browse/MYFACES-4373 This is an automated message from the Apache Git Service. To respond to

[GitHub] [myfaces] wtlucy commented on a change in pull request #127: MYFACES-4373: prefer SecureRandom for token generation 3.0.x

2021-01-13 Thread GitBox
wtlucy commented on a change in pull request #127: URL: https://github.com/apache/myfaces/pull/127#discussion_r556803559 ## File path: impl/src/main/java/org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java ## @@ -133,11 +133,11 @@ * Adds a random key

[GitHub] [myfaces] bohmber commented on a change in pull request #127: MYFACES-4373: prefer SecureRandom for token generation 3.0.x

2021-01-13 Thread GitBox
bohmber commented on a change in pull request #127: URL: https://github.com/apache/myfaces/pull/127#discussion_r556781198 ## File path: impl/src/main/java/org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java ## @@ -133,11 +133,11 @@ * Adds a random key

[jira] [Resolved] (MYFACES-4373) Use SecureRandom for Token Generation

2021-01-13 Thread Bill Lucy (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Lucy resolved MYFACES-4373. Fix Version/s: 2.3.8 3.0.0-RC2 2.2.14

[jira] [Commented] (MYFACES-4373) Use SecureRandom for Token Generation

2021-01-13 Thread Bill Lucy (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264391#comment-17264391 ] Bill Lucy commented on MYFACES-4373: Thanks for the quick reviews [~tandraschko] and [~bommel] -

[jira] [Commented] (MYFACES-4373) Use SecureRandom for Token Generation

2021-01-13 Thread Thomas Andraschko (Jira)
[ https://issues.apache.org/jira/browse/MYFACES-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264389#comment-17264389 ] Thomas Andraschko commented on MYFACES-4373: Merged all, looks good. Thanks! Please set the

[GitHub] [myfaces] tandraschko merged pull request #127: MYFACES-4373: prefer SecureRandom for token generation 3.0.x

2021-01-13 Thread GitBox
tandraschko merged pull request #127: URL: https://github.com/apache/myfaces/pull/127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [myfaces] tandraschko merged pull request #132: MYFACES-4373: prefer SecureRandom for token generation

2021-01-13 Thread GitBox
tandraschko merged pull request #132: URL: https://github.com/apache/myfaces/pull/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [myfaces] tandraschko edited a comment on pull request #132: MYFACES-4373: prefer SecureRandom for token generation

2021-01-13 Thread GitBox
tandraschko edited a comment on pull request #132: URL: https://github.com/apache/myfaces/pull/132#issuecomment-759700069 edit: nvm :D This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [myfaces] tandraschko merged pull request #129: MYFACES-4373: prefer SecureRandom for token generation 2.2.x

2021-01-13 Thread GitBox
tandraschko merged pull request #129: URL: https://github.com/apache/myfaces/pull/129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [myfaces] tandraschko merged pull request #130: MYFACES-4373: prefer SecureRandom for token generation 2.1.x

2021-01-13 Thread GitBox
tandraschko merged pull request #130: URL: https://github.com/apache/myfaces/pull/130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [myfaces] tandraschko merged pull request #131: MYFACES-4373: prefer SecureRandom for token generation

2021-01-13 Thread GitBox
tandraschko merged pull request #131: URL: https://github.com/apache/myfaces/pull/131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [myfaces] tandraschko commented on pull request #132: MYFACES-4373: prefer SecureRandom for token generation

2021-01-13 Thread GitBox
tandraschko commented on pull request #132: URL: https://github.com/apache/myfaces/pull/132#issuecomment-759700069 RANDOM_KEY_IN_VIEW_STATE_SESSION_TOKEN_DEFAULT is unused? This is an automated message from the Apache Git

[GitHub] [myfaces] tandraschko merged pull request #128: MYFACES-4373: prefer SecureRandom for token generation 2.3.x

2021-01-13 Thread GitBox
tandraschko merged pull request #128: URL: https://github.com/apache/myfaces/pull/128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [myfaces] bohmber commented on pull request #132: MYFACES-4373: prefer SecureRandom for token generation

2021-01-13 Thread GitBox
bohmber commented on pull request #132: URL: https://github.com/apache/myfaces/pull/132#issuecomment-759695295 Can you check StateCacheServerSide for the randomMode if is unknown, please? This is an automated message from

[GitHub] [myfaces] wtlucy opened a new pull request #132: MYFACES-4373: prefer SecureRandom for token generation

2021-01-13 Thread GitBox
wtlucy opened a new pull request #132: URL: https://github.com/apache/myfaces/pull/132 https://issues.apache.org/jira/browse/MYFACES-4373 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [myfaces] wtlucy opened a new pull request #131: MYFACES-4373: prefer SecureRandom for token generation

2021-01-13 Thread GitBox
wtlucy opened a new pull request #131: URL: https://github.com/apache/myfaces/pull/131 https://issues.apache.org/jira/browse/MYFACES-4373 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [myfaces] wtlucy opened a new pull request #130: MYFACES-4373: prefer SecureRandom for token generation 2.1.x

2021-01-13 Thread GitBox
wtlucy opened a new pull request #130: URL: https://github.com/apache/myfaces/pull/130 https://issues.apache.org/jira/browse/MYFACES-4373 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [myfaces] wtlucy opened a new pull request #129: MYFACES-4373: prefer SecureRandom for token generation 2.2.x

2021-01-13 Thread GitBox
wtlucy opened a new pull request #129: URL: https://github.com/apache/myfaces/pull/129 https://issues.apache.org/jira/browse/MYFACES-4373 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [myfaces] wtlucy opened a new pull request #128: MYFACES-4373: prefer SecureRandom for token generation 2.3.x

2021-01-13 Thread GitBox
wtlucy opened a new pull request #128: URL: https://github.com/apache/myfaces/pull/128 https://issues.apache.org/jira/browse/MYFACES-4373 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [myfaces] wtlucy opened a new pull request #127: MYFACES-4373: prefer SecureRandom for token generation 3.0.x

2021-01-13 Thread GitBox
wtlucy opened a new pull request #127: URL: https://github.com/apache/myfaces/pull/127 https://issues.apache.org/jira/browse/MYFACES-4373 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (MYFACES-4373) Use SecureRandom for Token Generation

2021-01-13 Thread Bill Lucy (Jira)
Bill Lucy created MYFACES-4373: -- Summary: Use SecureRandom for Token Generation Key: MYFACES-4373 URL: https://issues.apache.org/jira/browse/MYFACES-4373 Project: MyFaces Core Issue Type: Bug

[GitHub] [myfaces-tobago] bohmber merged pull request #188: improved integration test

2021-01-13 Thread GitBox
bohmber merged pull request #188: URL: https://github.com/apache/myfaces-tobago/pull/188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [myfaces-tobago] bohmber opened a new pull request #188: improved integration test

2021-01-13 Thread GitBox
bohmber opened a new pull request #188: URL: https://github.com/apache/myfaces-tobago/pull/188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL