[jira] Created: (TRINIDAD-1821) client-side DateFormat improperly parses year when format mask contains 3 or more 'y'

2010-06-01 Thread Cale Scholl (JIRA)
Project: MyFaces Trinidad Issue Type: Bug Components: Components Reporter: Cale Scholl Priority: Minor The following section of code was located in the _subparse function of trinidad-impl DateFormat.js and was ripped out: else if (charCount

[jira] Updated: (TRINIDAD-1821) client-side DateFormat improperly parses year when format mask contains 3 or more 'y'

2010-06-01 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1821: -- Status: Patch Available (was: Open) client-side DateFormat improperly parses year when

[jira] Created: (TRINIDAD-1818) TrDateTimeRangeValidator should validate using date object, not date string

2010-05-28 Thread Cale Scholl (JIRA)
Trinidad Issue Type: Bug Components: Components Reporter: Cale Scholl Priority: Minor TrDateTimeRangeValidator converts date strings to date objects in order to do validation. Just use the date objects directly, if available. -- This message

[jira] Updated: (TRINIDAD-1818) TrDateTimeRangeValidator should validate using date object, not date string

2010-05-28 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1818: -- Status: Patch Available (was: Open) TrDateTimeRangeValidator should validate using date

[jira] Commented: (TRINIDAD-1683) client-side convertNumber causes loss of precision

2010-02-22 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12837043#action_12837043 ] Cale Scholl commented on TRINIDAD-1683: --- Since Java 1.5+ supports covariant return

[jira] Created: (TRINIDAD-1688) color converter renders extra JS

2010-01-15 Thread Cale Scholl (JIRA)
: 1.2.12-core Reporter: Cale Scholl Priority: Minor MAIN ENHANCEMENT: In trinidad-impl ColorConverter.getClientScript we have: -- String[] patterns = getPatterns(); buff.append(_cfs[\); buff.append(clientId); buff.append(\]=); if (patterns.length == 1

Can someone take a look at my patches for convertNumber precision?

2010-01-13 Thread Cale Scholl
I have two related patches available: https://issues.apache.org/jira/browse/TRINIDAD-1678 https://issues.apache.org/jira/browse/TRINIDAD-1683 Thank you, Cale

convert to BigInteger when integerOnly=true ?

2010-01-08 Thread Cale Scholl
Aloha, convertNumber currently converts to Long when integerOnly=true; I'd like to convert to BigInteger instead so that we're less likely to lose any precision. There's a test in NumberConverterTestCase called testIntegerOnlyIsHonoured that expects Long values, so I changed it to expect

[jira] Created: (TRINIDAD-1683) client-side convertNumber causes loss of precision

2010-01-08 Thread Cale Scholl (JIRA)
: Components Affects Versions: 1.2.12-core Reporter: Cale Scholl Priority: Minor ISSUE: -- JS numbers are 64-bit values and thus only have 16 digits of precision; this isn't enough to represent the max value of a Long, BigInteger, or BigDecimal. This means

[jira] Updated: (TRINIDAD-1683) client-side convertNumber causes loss of precision

2010-01-08 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1683: -- Status: Patch Available (was: Open) client-side convertNumber causes loss of precision

[jira] Commented: (TRINIDAD-1678) TrNumberFormat.prototype.numberToString doesn't account for numbers represented via scientific notation

2010-01-08 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12798257#action_12798257 ] Cale Scholl commented on TRINIDAD-1678: --- see also: https://issues.apache.org/jira

[jira] Created: (TRINIDAD-1678) TrNumberFormat.prototype.numberToString doesn't account for numbers represented via scientific notation

2010-01-07 Thread Cale Scholl (JIRA)
/browse/TRINIDAD-1678 Project: MyFaces Trinidad Issue Type: Bug Components: Components Affects Versions: 1.2.12-core Reporter: Cale Scholl Priority: Minor ISSUE: -- Say we have a 22-digit number string 77

[jira] Updated: (TRINIDAD-1678) TrNumberFormat.prototype.numberToString doesn't account for numbers represented via scientific notation

2010-01-07 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1678: -- Status: Patch Available (was: Open) TrNumberFormat.prototype.numberToString doesn't

Re: [jira] Updated: (TRINIDAD-1666) convertNumber without maxfractiondigits specified limits digits to 3

2010-01-04 Thread Cale Scholl
Now that the busy holiday season is over, would someone mind taking a look at my patch? Thanks, Cale On 12/24/2009 10:34 PM, Cale Scholl (JIRA) wrote: [ https://issues.apache.org/jira/browse/TRINIDAD-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl

[jira] Created: (TRINIDAD-1666) convertNumber without maxfractiondigits specified limits digits to 3

2009-12-24 Thread Cale Scholl (JIRA)
Issue Type: Bug Components: Components Affects Versions: 1.2.12-core Reporter: Cale Scholl Priority: Minor ISSUE: -- Given a default convertNumber e.g. af:convertNumber id=cn1 type=number/: Enter 1.23456789. Press Submit. You will see that the number

[jira] Updated: (TRINIDAD-1666) convertNumber without maxfractiondigits specified limits digits to 3

2009-12-24 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1666: -- Status: Patch Available (was: Open) convertNumber without maxfractiondigits specified

ColorConverter performance, and client converter class organization

2009-12-14 Thread Cale Scholl
There are two issues I'd like to discuss: 1. In trinidad-impl ColorConverter.getClientScript we have: String[] patterns = getPatterns(); buff.append(_cfs[\); buff.append(clientId); buff.append(\]=); if (patterns.length == 1) { buff.append(\);

[patch available] [jira] Updated: (TRINIDAD-1538) Failing client side validation with some date patterns

2009-08-10 Thread Cale Scholl
Howdy folks, This patch has been available for a week. Could one of the Trinidad committers take a look? Thank you, Cale Cale Scholl (JIRA) said the following On 7/31/2009 4:12 PM PT: [ https://issues.apache.org/jira/browse/TRINIDAD-1538?page

[jira] Updated: (TRINIDAD-1538) Failing client side validation with some date patterns

2009-07-31 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1538: -- Status: Patch Available (was: Open) Failing client side validation with some date

[jira] Commented: (TRINIDAD-1538) Failing client side validation with some date patterns

2009-07-31 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737766#action_12737766 ] Cale Scholl commented on TRINIDAD-1538: --- Code change in DateFormat.js _subparse

[jira] Commented: (TRINIDAD-1538) Failing client side validation with some date patterns

2009-07-31 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12737812#action_12737812 ] Cale Scholl commented on TRINIDAD-1538: --- Code review changes: var isStrict

[jira] Created: (TRINIDAD-1539) grouping and parsing regressions in convertNumber

2009-07-28 Thread Cale Scholl (JIRA)
: Cale Scholl Grouping regression caused by: https://issues.apache.org/jira/browse/TRINIDAD-1534 The fix is to replace this: balance = ints.substring(0, toMuch) + groupingSeparator; with this: balance = (counter 4) ? ints.substring(0, toMuch) : ints.substring(0, toMuch) + groupingSeparator

[jira] Updated: (TRINIDAD-1539) grouping and parsing regressions in convertNumber

2009-07-28 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1539: -- Status: Patch Available (was: Open) grouping and parsing regressions in convertNumber

[jira] Updated: (TRINIDAD-1537) client convertNumber truncates invalid number instead of throwing exception

2009-07-21 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1537: -- Status: Patch Available (was: Open) client convertNumber truncates invalid number instead

[jira] Created: (TRINIDAD-1536) client convertnumber truncates number when groupingseparator is space

2009-07-20 Thread Cale Scholl (JIRA)
Issue Type: Bug Reporter: Cale Scholl Set browser locale to locale in which grouping-separator is space, like fr_FR. For the fr_FR case, enter 1 233 456 €, client side converter truncates it into 1. Same issue for %. -- This message is automatically generated by JIRA. - You can

[jira] Updated: (TRINIDAD-1536) client convertnumber truncates number when groupingseparator is space

2009-07-20 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1536: -- Status: Patch Available (was: Open) client convertnumber truncates number when

[jira] Created: (TRINIDAD-1537) client convertNumber truncates invalid number instead of throwing exception

2009-07-20 Thread Cale Scholl (JIRA)
Trinidad Issue Type: Bug Reporter: Cale Scholl On the client, 123abc45 is truncated to 123, whereas it should throw an exception; the server throws an exception The reason that 123abc45 is truncated to 123 is due to a native js function: parseFloat(123abc45) returns 123

[jira] Commented: (TRINIDAD-1537) client convertNumber truncates invalid number instead of throwing exception

2009-07-20 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733428#action_12733428 ] Cale Scholl commented on TRINIDAD-1537: --- Currently cannot provide patch due

[jira] Updated: (TRINIDAD-1421) incorrect convertNumber behavior when integerOnly=true

2009-07-17 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1421: -- Status: Patch Available (was: Open) incorrect convertNumber behavior when integerOnly

[jira] Created: (TRINIDAD-1534) incorrect grouping shown by convertnumber

2009-07-17 Thread Cale Scholl (JIRA)
incorrect grouping shown by convertnumber - Key: TRINIDAD-1534 URL: https://issues.apache.org/jira/browse/TRINIDAD-1534 Project: MyFaces Trinidad Issue Type: Bug Reporter: Cale Scholl

[jira] Updated: (TRINIDAD-1534) incorrect grouping shown by convertnumber

2009-07-17 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1534: -- Status: Patch Available (was: Open) incorrect grouping shown by convertnumber

Re: [Trinidad] JDK build issue

2009-03-11 Thread Cale Scholl
Works for me on Windows XP x84. C:\jdevrt\trinidad\trunk_testwhich mvn /cygdrive/c/program files/apache/maven/maven-2.0.7/bin/mvn C:\jdevrt\trinidad\trunk_testecho %JAVA_HOME% C:\java\jdk\jdk1.5.0_17 C:\jdevrt\trinidad\trunk_testmvn clean install builds successfully -Cale Andrew Robinson

[jira] Created: (TRINIDAD-1413) getLocalizedPattern displays currency sign in Linux

2009-03-05 Thread Cale Scholl (JIRA)
Components: Components Affects Versions: 1.2.11-core Reporter: Cale Scholl Attachments: 1.2.11.1-branch_currencySign.patch, trunk_currencySign.patch This is concerning the implementation of getLocalizedPattern provided with the fix for: https://issues.apache.org/jira/browse

[jira] Updated: (TRINIDAD-1413) getLocalizedPattern displays currency sign in Linux

2009-03-05 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1413: -- Status: Patch Available (was: Open) getLocalizedPattern displays currency sign in Linux

Re: 1.2.11-SNAPSHOT dependencies

2009-02-19 Thread Cale Scholl
Hi, When doing a mvn clean install on Trinidad trunk (formerly trunk 1.2.x) I get the following error: [INFO] [INFO] Building Apache MyFaces Trinidad Blank Demo [INFO]task-segment: [clean, install] [INFO]

[jira] Created: (TRINIDAD-1388) Golden file test framework does not support javax.faces componentTypes

2009-02-05 Thread Cale Scholl (JIRA)
Issue Type: Bug Affects Versions: 1.0.10-core, 1.2.10-core Reporter: Cale Scholl Priority: Minor When a page contains Trinidad components, h:form will be overridden (rendered with Trinidad HtmlFormRenderer). If there are any changes in how we override the h:form

[jira] Commented: (TRINIDAD-1374) NumberConverter with type='number' and pattern set gives malformed error

2009-01-29 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12668616#action_12668616 ] Cale Scholl commented on TRINIDAD-1374: --- According to the comments in trinidad

[jira] Updated: (TRINIDAD-1374) NumberConverter with type='number' and pattern set gives malformed error

2009-01-29 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1374: -- Status: Patch Available (was: Open) NumberConverter with type='number' and pattern set

[jira] Created: (TRINIDAD-1380) convertNumber should support 'locale' attribute on client

2009-01-26 Thread Cale Scholl (JIRA)
Components: Components Affects Versions: 1.0.10-core, 1.2.10-core Reporter: Cale Scholl -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

[jira] Updated: (TRINIDAD-1380) convertNumber should support 'locale' attribute on client

2009-01-26 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1380: -- Status: Patch Available (was: Open) convertNumber should support 'locale' attribute

[jira] Created: (TRINIDAD-1366) client percent convertnumber not work well in fr_fr

2009-01-14 Thread Cale Scholl (JIRA)
Components: Components, Plugins Affects Versions: 1.0.10-core, 1.2.10-core, 1.2.8-plugins Reporter: Cale Scholl Priority: Minor TrNumberFormat.prototype.percentageToString() just appends the '%' symbol. The is wrong for the fr_FR locale, since the percent suffix

[jira] Updated: (TRINIDAD-1366) client percent convertnumber not work well in fr_fr

2009-01-14 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1366: -- Status: Patch Available (was: Open) client percent convertnumber not work well in fr_fr

[jira] Created: (TRINIDAD-1361) js error when use convertDateTime with secondaryPattern attribute

2009-01-05 Thread Cale Scholl (JIRA)
Type: Bug Components: Components Affects Versions: 1.0.10-core, 1.2.10-core Reporter: Cale Scholl Regression caused by https://issues.apache.org/jira/browse/TRINIDAD-1344 convertDateTime with secondaryPattern attribute means in TrDateTimeConverter.prototype

[jira] Updated: (TRINIDAD-1361) js error when use convertDateTime with secondaryPattern attribute

2009-01-05 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1361: -- Status: Patch Available (was: Open) js error when use convertDateTime

[jira] Created: (TRINIDAD-1344) fixed multiple issues with convertDateTime's handling of convenience patterns

2008-12-12 Thread Cale Scholl (JIRA)
Trinidad Issue Type: Bug Components: Components Affects Versions: 1.0.10-core, 1.2.10-core Reporter: Cale Scholl The provided 1.2.10.1_convPatterns.patch fixes multiple issues with convertDateTime's handling of convenience patterns; convenience patterns

[jira] Updated: (TRINIDAD-1344) fixed multiple issues with convertDateTime's handling of convenience patterns

2008-12-12 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1344: -- Status: Patch Available (was: Open) fixed multiple issues with convertDateTime's handling

[jira] Created: (TRINIDAD-1338) Users shouldn't be forced to enter % or currency symbols

2008-12-08 Thread Cale Scholl (JIRA)
Components: Components Affects Versions: 1.0.10-core, 1.2.10-core Reporter: Cale Scholl When using convertNumber with type=percent or type=currency, the user shouldn't be forced to enter the % or currency symbols. If not specified, the symbols should default to those specified

[jira] Updated: (TRINIDAD-1338) Users shouldn't be forced to enter % or currency symbols

2008-12-08 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1338: -- Status: Patch Available (was: Open) Users shouldn't be forced to enter % or currency

[jira] Reopened: (TRINIDAD-1231) Server and client message formatters should be consistent with each other.

2008-12-03 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl reopened TRINIDAD-1231: --- There is a small error that needs attention. IE7 doesn't support the javascript syntax

[Fwd: [Trinidad] Resolving differences between client-side and server-side message formatter?]

2008-11-01 Thread Cale Scholl
://issues.apache.org/jira/browse/TRINIDAD-1231 Thank you, Cale Original Message Subject: [Trinidad] Resolving differences between client-side and server-side message formatter? Date: Thu, 30 Oct 2008 10:50:16 -0700 From: Cale Scholl [EMAIL PROTECTED] Reply-To: MyFaces Development

[Trinidad] Resolving differences between client-side and server-side message formatter?

2008-10-30 Thread Cale Scholl
Hello, I'm pretty new to the Trinidad community, so let me apologize in advance if there's something I've misunderstood. What I'd like to talk about are the differences between the client-side message formatter: trinidad-impl\src\main\javascript\META-INF\adf\jsLibs\Core.js - function

[jira] Created: (TRINIDAD-1278) Don't display - in error message when label is null.

2008-10-25 Thread Cale Scholl (JIRA)
Versions: 1.2.9-core Reporter: Cale Scholl Priority: Minor Attachments: trunk12_noDash.patch When the label is null, the error message printed at the top of the screen will be something like - Invalid data. The - looks unsightly without any text preceding it, so we

[jira] Updated: (TRINIDAD-1278) Don't display - in error message when label is null.

2008-10-25 Thread Cale Scholl (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cale Scholl updated TRINIDAD-1278: -- Status: Patch Available (was: Open) Don't display - in error message when label is null

[jira] Created: (TRINIDAD-1231) Custom message/hint strings used by validators should be escaped.

2008-09-17 Thread Cale Scholl (JIRA)
Type: Bug Components: Components Affects Versions: 1.2.9-core, 1.0.9-core Reporter: Cale Scholl Priority: Minor Whenever a validator has an attribute hintXYZ or messageDetailXYZ that allows for a custom string, we should escape that string whenever we write