RE: [jira] Commented: (TOMAHAWK-440) Add orientation parameter to NewspaperTable

2006-05-19 Thread L Frohman
Done, I replaced TOMAHAWK-440 with TOMAHAWK-441. (I'm using up all the JIRA numbers). -Original Message- From: Mike Kienenberger [mailto:[EMAIL PROTECTED] Sent: Thursday, May 18, 2006 4:43 PM To: MyFaces Discussion Cc: Mike Kienenberger (JIRA) Subject: Re: [jira] Commented: (TOMAHAWK-440

[jira] Commented: (TOMAHAWK-440) Add orientation parameter to NewspaperTable

2006-05-18 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/TOMAHAWK-440?page=comments#action_12412427 ] Mike Kienenberger commented on TOMAHAWK-440: Does this only affect newspaperColumn tables? If so, we should rename it to be newspaperHorizontalOrientation. It

Re: [jira] Commented: (TOMAHAWK-440) Add orientation parameter to NewspaperTable

2006-05-18 Thread Mike Kienenberger
On 5/18/06, L Frohman [EMAIL PROTECTED] wrote: quick question, I have the following line in HtmlTableRendererBase.java. boolean newspaperVerticalOrientation = !horizontal.equals(getNewspaperOrientation(component)); horizontal should be a constant somewhere (private static final String), but it

RE: [jira] Commented: (TOMAHAWK-440) Add orientation parameter to NewspaperTable

2006-05-18 Thread L Frohman
to it. Any other problems/comments? I'll make a new jira and mark this one as fixed. Thanks, Lance -Original Message- From: Mike Kienenberger (JIRA) [mailto:[EMAIL PROTECTED] Sent: Thursday, May 18, 2006 2:11 PM To: [EMAIL PROTECTED] Subject: [jira] Commented: (TOMAHAWK-440) Add orientation

RE: [jira] Commented: (TOMAHAWK-440) Add orientation parameter to NewspaperTable

2006-05-18 Thread L Frohman
] Subject: [jira] Commented: (TOMAHAWK-440) Add orientation parameter to NewspaperTable [ http://issues.apache.org/jira/browse/TOMAHAWK-440?page=comments#action_12412 427 ] Mike Kienenberger commented on TOMAHAWK-440: Does this only affect

Re: [jira] Commented: (TOMAHAWK-440) Add orientation parameter to NewspaperTable

2006-05-18 Thread Mike Kienenberger
On 5/18/06, L Frohman [EMAIL PROTECTED] wrote: I originally had the attribute be orientation with values horizontal and vertical, but I figured since there were only two values, it was better to make it boolean. But I can change it back. Yes, it only affects newspaperColumn tables. I was going