Re: Facelets Tomahawk

2006-08-04 Thread Martin Marinschek
As for the generator - can we check if the Trinidad generator can do the work for us? regards, Martin On 8/4/06, Sean Schofield [EMAIL PROTECTED] wrote: It's that unit test vs integration test thing again. Your example will show that facelets works as an integration test, but isn't

Re: Facelets Tomahawk

2006-08-04 Thread Mike Kienenberger
On 8/3/06, Sean Schofield [EMAIL PROTECTED] wrote: It's that unit test vs integration test thing again. Your example will show that facelets works as an integration test, but isn't really as comprehensive as having a facelets example for every component. Yes a facelets example for every

Re: Facelets Tomahawk

2006-08-04 Thread Matthias Wessendorf
There is currently some ADF/Trinidad specific code in (FacesBean, AdfFacesContext (aka Requestcontext),...) -Matthias On 8/4/06, Martin Marinschek [EMAIL PROTECTED] wrote: As for the generator - can we check if the Trinidad generator can do the work for us? regards, Martin On 8/4/06, Sean

Re: Facelets Tomahawk

2006-08-04 Thread Adam Winer
... but I'd really like to add a flag to maven-faces-pluginto turn Trinidad-specific superclasses on and off. (IIRC, theFacelet generator is actually already generic). If I got thisdone, would someone on the Tomahawk side use it? -- AdamOn 8/4/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: There

Re: Facelets Tomahawk

2006-08-04 Thread Matthias Wessendorf
+1 on using that plugin. the plugin is longer on my list; but current things like getting myfaces_core out etc stop me from doing it. -Matt On 8/4/06, Adam Winer [EMAIL PROTECTED] wrote: ... but I'd really like to add a flag to maven-faces-plugin to turn Trinidad-specific superclasses on and

Re: Facelets Tomahawk

2006-08-03 Thread Thomas Spiegl
I have written an autogenerator for the facelets-taglib. Maybe we can use this one. What about adding new MyFaces examples using facelets? We will need it to test tomahawk facelet support. On 8/3/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Yes, I know... there is also the Trinidad

Re: Facelets Tomahawk

2006-08-03 Thread Sean Schofield
What about adding new MyFaces examples using facelets? We will need it to test tomahawk facelet support. I am currently writing such an example over at Shale (just getting it started.) It uses Shale, MyFaces, Tomahawk, Facelets, Hibernate and Spring. IMO this single example would suffice for

Re: Facelets Tomahawk

2006-08-03 Thread Mike Kienenberger
On 8/3/06, Thomas Spiegl [EMAIL PROTECTED] wrote: I have written an autogenerator for the facelets-taglib. Maybe we can use this one. It seems like extra work to maintain two generators when they both generate the same kind of information. What about adding new MyFaces examples using

Re: Facelets Tomahawk

2006-08-03 Thread Sean Schofield
It's that unit test vs integration test thing again. Your example will show that facelets works as an integration test, but isn't really as comprehensive as having a facelets example for every component. Yes a facelets example for every component wouldn't hurt. Also, Wendy's work with the

Facelets Tomahawk

2006-08-02 Thread Thomas Spiegl
I will add facelets support to MyFaces tomahawk. Here my suggestions: Tomahawk Facelets classes (TagHandlers, etc.) go to folder: tomahawk/core/src/main/java package: org.apache.myfaces.custom.facelets Tomahawk Facelets Taglib resides in folder: tomahawk/core/src/main/resources-facelets

Re: Facelets Tomahawk

2006-08-02 Thread Matthias Wessendorf
On 8/2/06, Thomas Spiegl [EMAIL PROTECTED] wrote: I will add facelets support to MyFaces tomahawk. Here my suggestions: Tomahawk Facelets classes (TagHandlers, etc.) go to folder: tomahawk/core/src/main/java +1 package: org.apache.myfaces.custom.facelets -1 I prefere

Re: Facelets Tomahawk

2006-08-02 Thread Sean Schofield
Can you give an example of a class that is a problem and how you propose to fix it? I'm not terribly familiar with facelets but I was able to get tree2 working without adding special facelets packages. There were just some differences in properties and how facelets expected to find them. Sean

Re: Facelets Tomahawk

2006-08-02 Thread Mike Kienenberger
On 8/2/06, Sean Schofield [EMAIL PROTECTED] wrote: Can you give an example of a class that is a problem and how you propose to fix it? I'm not terribly familiar with facelets but I was able to get tree2 working without adding special facelets packages. There were just some differences in

Re: Facelets Tomahawk

2006-08-02 Thread Matthias Wessendorf
Also pure jsp tags (like t:updateActionListener) also have to be rewritten as a facelets tag handlers. yes, we have handlers for that in Trinidad too. -Matthias -- Matthias Wessendorf further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com

Re: Facelets Tomahawk

2006-08-02 Thread Matthias Wessendorf
Tobago has some facelets *specials* too On 8/2/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Also pure jsp tags (like t:updateActionListener) also have to be rewritten as a facelets tag handlers. yes, we have handlers for that in Trinidad too. -Matthias -- Matthias Wessendorf further

Re: Facelets Tomahawk

2006-08-02 Thread Sean Schofield
If we design our MyFaces components right, the only component classes that will need facelets tag handlers are those with method bindings. The method binding method signature for an attribute has be specified in a facelets component tag handler. Well lets make sure we do this part whenever

Re: Facelets Tomahawk

2006-08-02 Thread Mike Kienenberger
On 8/2/06, Sean Schofield [EMAIL PROTECTED] wrote: If we design our MyFaces components right, the only component classes that will need facelets tag handlers are those with method bindings. The method binding method signature for an attribute has be specified in a facelets component tag

Re: Facelets Tomahawk

2006-08-02 Thread Sean Schofield
For most of the remaining problem components, it's simply a matter of taking care of the generic attributes and making them explicit html attributes like you did for tree2. OK so there's not much of a need for this new package directory but we do need it in a few limited cases right? The only

Re: Facelets Tomahawk

2006-08-02 Thread Mike Kienenberger
On 8/2/06, Sean Schofield [EMAIL PROTECTED] wrote: For most of the remaining problem components, it's simply a matter of taking care of the generic attributes and making them explicit html attributes like you did for tree2. OK so there's not much of a need for this new package directory but

Re: Facelets Tomahawk

2006-08-02 Thread Mike Kienenberger
On 8/2/06, Mike Kienenberger [EMAIL PROTECTED] wrote: I think I remember seeing that Manfred had resurrected the code generator before I left on vacation. Just stumbled across the JIRA issue while looking at another. http://issues.apache.org/jira/browse/MYFACES-1284

Re: Facelets Tomahawk

2006-08-02 Thread Matthias Wessendorf
Yes, I know... there is also the Trinidad maven-faces-plugin. On 8/2/06, Mike Kienenberger [EMAIL PROTECTED] wrote: On 8/2/06, Mike Kienenberger [EMAIL PROTECTED] wrote: I think I remember seeing that Manfred had resurrected the code generator before I left on vacation. Just stumbled across