werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1820403081
Thanks for testing and closing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
volosied merged PR #637:
URL: https://github.com/apache/myfaces/pull/637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
volosied merged PR #638:
URL: https://github.com/apache/myfaces/pull/638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
volosied commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1810604214
Thanks - I'll test it out again. Give me a few days!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1810336916
@volosied there were indeed smaller issues, which the Tobago guys reported
my, all of them are now backported to the 3.x branch, please give it another
shot!
--
This is an automated
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1808389193
Hi i added a small fix from an issue which was reported from the Tobago guys!
The fix for 4.0+ will come soon, it just needs final Tobago testing, but
their testcase is fixed by this fix.
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1805969120
I can make a quick pull request for 2.3 (next has one already)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
volosied commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1805831640
We've still been patching fixes, and it's a version our product still
supports.And since the code is mostly the same as 2.3, I expect the TCK
failures to also exist in that branch.
melloware commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1805821676
i thought the 3.0.x branch we decided was dead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
volosied commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1805815432
Hi sorry for the delay -- I used the current 3.0.x branch along with your
commits to test the TCK. I was hoping to create a 3.0 release soon ( along with
the other branches).
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1805584477
Any news on the TCK @volosied ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
volosied commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1799343920
Hi, the changes look good to me. Both scenarios I've tested pass.
Let me run the full TCK and (hopefully) we merge this in!
--
This is an automated message from the Apache Git
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1799032107
Hi, I fixed the check on FormData level, apparently the hasKey function only
checked for newly appended values not existing data passed into the existing
formData object, this should fix the
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796991675
I will have a deeper look into this tomorrow, I need to debug this out
properly, the issue simply is there are possibilities where an array of values
can come in over checkbox fields over
volosied commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796973598
Thanks for looking. I hoped it would work, too, but it doesn't,
unfortunately. Problem looks to be here:
getFormData:function () {
var formDataDecorator =
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796524136
Mhh I have to check that let me check that tomorrow!
There needs to be a check that the value of the same element is not attached
twice.
It is getting late here, so I will check that
volosied commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796428426
I'm seeing it's caused by
ajaxUtils.encodeSubmittableFields(ret, form, null);
volosied commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796413956
Yep, it's fixed now. Thanks!
However, I'm still seeing the an array sent for the issuing element?
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796399710
Fixed it, sorry for the issue, I guess I have to recheck my integration
tests apparently this code was not triggered by them!
(the 4.x codebase has a dedicated unit test so it is covered
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796387031
mhh let me check quickly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
volosied commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796385353
@werpu I'm getting the following error in my test case:
```
Error Message: (intermediate value).toLowerCase is not a function
werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796359752
does it work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
tandraschko commented on PR #637:
URL: https://github.com/apache/myfaces/pull/637#issuecomment-1792029872
fixed it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tandraschko commented on PR #637:
URL: https://github.com/apache/myfaces/pull/637#issuecomment-1792023607
yep
not sure what happening
i added a unittest yesterday and everything was broken, needed to upgrade
OWB because of nullpointers in ASM and now this exception...
--
This is an
24 matches
Mail list logo
