Re: StateSaving reviews

2012-11-16 Thread Mark Struberg
, 2012 2:11 AM Subject: Re: StateSaving reviews On Thu, Nov 15, 2012 at 7:41 PM, Mark Struberg strub...@yahoo.de wrote: Btw you should either copy over Tom and Manfreds @author from the JspViewStateManager or remove your own @author from the copied class as it is still 80% the old code. I

Re: StateSaving reviews

2012-11-16 Thread Mark Struberg
strub...@yahoo.de Cc: Sent: Friday, November 16, 2012 2:09 AM Subject: Re: StateSaving reviews Hi I'll proceed with the necessary changes now. I hope to get it done tomorrow. regards, Leonardo 2012/11/15 Leonardo Uribe lu4...@gmail.com: Hi 2012/11/15 Mark Struberg strub

Re: StateSaving reviews

2012-11-16 Thread Leonardo Uribe
16, 2012 2:09 AM Subject: Re: StateSaving reviews Hi I'll proceed with the necessary changes now. I hope to get it done tomorrow. regards, Leonardo 2012/11/15 Leonardo Uribe lu4...@gmail.com: Hi 2012/11/15 Mark Struberg strub...@yahoo.de: The usual release cycle is 2 to 3 months

Re: StateSaving reviews

2012-11-16 Thread Leonardo Uribe
Struberg strub...@yahoo.de Cc: Sent: Friday, November 16, 2012 4:16 PM Subject: Re: StateSaving reviews Hi 2012/11/16 Mark Struberg strub...@yahoo.de: Btw, you wrote that code has been there for years!! I checked the logs now. Actually most of the changes got only introduced

Re: StateSaving reviews

2012-11-16 Thread Mark Struberg
... I hope you feel better now at least. LieGrue, strub - Original Message - From: Leonardo Uribe lu4...@gmail.com To: MyFaces Development dev@myfaces.apache.org; Mark Struberg strub...@yahoo.de Cc: Sent: Friday, November 16, 2012 2:09 AM Subject: Re: StateSaving reviews Hi

Re: StateSaving reviews

2012-11-16 Thread Leonardo Uribe
, November 16, 2012 2:09 AM Subject: Re: StateSaving reviews Hi I'll proceed with the necessary changes now. I hope to get it done tomorrow. regards, Leonardo 2012/11/15 Leonardo Uribe lu4...@gmail.com: Hi 2012/11/15 Mark Struberg strub...@yahoo.de: The usual release cycle is 2 to 3

Re: StateSaving reviews

2012-11-15 Thread Kito Mann
As an observer to this argument and someone whose clients depend on the stability of the code base, such a refactoring so close to release seems like a bad idea. Why not do this after the release? Sent from my iPhone http://www.jsfcentral.com http://www.Virtua.com On Nov 15, 2012, at 6:36 PM,

Re: StateSaving reviews

2012-11-15 Thread Mark Struberg
: there is no effective code change. Just making inner classes visible to uncover the mess. LieGrue, strub - Original Message - From: Kito Mann kito.m...@virtua.com To: MyFaces Development dev@myfaces.apache.org Cc: Sent: Friday, November 16, 2012 12:54 AM Subject: Re: StateSaving

Re: StateSaving reviews

2012-11-15 Thread Leonardo Uribe
, Leonardo Uribe LieGrue, strub - Original Message - From: Kito Mann kito.m...@virtua.com To: MyFaces Development dev@myfaces.apache.org Cc: Sent: Friday, November 16, 2012 12:54 AM Subject: Re: StateSaving reviews As an observer to this argument and someone whose clients depend

Re: StateSaving reviews

2012-11-15 Thread Mark Struberg
. LieGrue, strub - Original Message - From: Leonardo Uribe lu4...@gmail.com To: MyFaces Development dev@myfaces.apache.org; Mark Struberg strub...@yahoo.de Cc: Sent: Friday, November 16, 2012 1:11 AM Subject: Re: StateSaving reviews Hi 2012/11/15 Mark Struberg strub...@yahoo.de

Re: StateSaving reviews

2012-11-15 Thread Mike Kienenberger
On Thu, Nov 15, 2012 at 6:54 PM, Kito Mann kito.m...@virtua.com wrote: As an observer to this argument and someone whose clients depend on the stability of the code base, such a refactoring so close to release seems like a bad idea. Why not do this after the release? Releases are just

Re: StateSaving reviews

2012-11-15 Thread Leonardo Uribe
...@gmail.com To: MyFaces Development dev@myfaces.apache.org; Mark Struberg strub...@yahoo.de Cc: Sent: Friday, November 16, 2012 1:11 AM Subject: Re: StateSaving reviews Hi 2012/11/15 Mark Struberg strub...@yahoo.de: Kito, there was no single word inside the PMC that the release

Re: StateSaving reviews

2012-11-15 Thread Leonardo Uribe
, November 16, 2012 1:11 AM Subject: Re: StateSaving reviews Hi 2012/11/15 Mark Struberg strub...@yahoo.de: Kito, there was no single word inside the PMC that the release will be next week. I just again scanned our internal mailboxes to verify that. Leo is just adding another messy argument

Re: StateSaving reviews

2012-11-15 Thread Mike Kienenberger
On Thu, Nov 15, 2012 at 7:41 PM, Mark Struberg strub...@yahoo.de wrote: Btw you should either copy over Tom and Manfreds @author from the JspViewStateManager or remove your own @author from the copied class as it is still 80% the old code. I am fairly certain we did away with @author tags