[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520828#comment-16520828 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239:

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399597447 I also thought a bit about it, i think it would be better if we discuss it first on the mailing list. And details about it would be

[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520399#comment-16520399 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239:

[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520400#comment-16520400 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko edited a comment on issue #8:

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368 @pnicolucci i'm not sure about this changes out.write vs sb.append... Why do you switchted from out.write to a new StringBuilder?

[GitHub] tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368 @pnicolucci i'm not sure about this changes out.write vs sb.append... Why do you switchted from out.write to a new

[GitHub] pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399464056 @tandraschko , we've been running some performance tests and can see a .5 - 1% increase in our testing in performance with an application

[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520424#comment-16520424 ] ASF GitHub Bot commented on MYFACES-4239: - pnicolucci commented on issue #8: MYFACES-4239:

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399464821 ok, i see i'm ok for it if you use the SharedStringBuilder This is an

[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520431#comment-16520431 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239:

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465655 JFYI: we avoided new objects so much in the past that we even switched from for-each to for loops, so the SharedStringBuilder is IMO a

[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520436#comment-16520436 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239:

[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520435#comment-16520435 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239:

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465769 All other changes looks fine of course. This is an automated message

[GitHub] tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465655 JFYI: we avoided new objects so much in the past that we even switched from for-each to for loops, so the SharedStringBuilder is

[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520440#comment-16520440 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko edited a comment on issue #8:

[jira] [Commented] (TOBAGO-1879) tc:date does not support Calendar and DateTime

2018-06-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520446#comment-16520446 ] Hudson commented on TOBAGO-1879: FAILURE: Integrated in Jenkins build Tobago Trunk #1468 (See

[jira] [Resolved] (MYFACES-4241) MF 2.3 crashes without CDI

2018-06-22 Thread Thomas Andraschko (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4241. Resolution: Fixed Fix Version/s: 2.3.2 > MF 2.3 crashes without CDI >

Re: Migrate all MyFaces projects to Git

2018-06-22 Thread Thomas Andraschko
Also deleted the unused branches now! 2018-06-21 17:23 GMT+02:00 Dennis Kieselhorst : > Great, thank you! > > On 2018/06/21 13:59:15, Werner Punz wrote: > > Just deleted it...> > >

[jira] [Created] (MYFACES-4241) MF 2.3 crashes without CDI

2018-06-22 Thread Thomas Andraschko (JIRA)
Thomas Andraschko created MYFACES-4241: -- Summary: MF 2.3 crashes without CDI Key: MYFACES-4241 URL: https://issues.apache.org/jira/browse/MYFACES-4241 Project: MyFaces Core Issue Type:

[jira] [Resolved] (TOBAGO-1905) Upgrade to Bootstrap 4.1.1

2018-06-22 Thread Henning Noeth (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Noeth resolved TOBAGO-1905. --- Resolution: Fixed > Upgrade to Bootstrap 4.1.1 > -- > >

[jira] [Commented] (TOBAGO-1905) Upgrade to Bootstrap 4.1.1

2018-06-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520302#comment-16520302 ] Hudson commented on TOBAGO-1905: SUCCESS: Integrated in Jenkins build Tobago Trunk #1464 (See

[jira] [Commented] (MYFACES-4227) Dynamic Resource Loading doesn't work

2018-06-22 Thread Thomas Andraschko (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520338#comment-16520338 ] Thomas Andraschko commented on MYFACES-4227: Seems like the following happens: The new

[GitHub] pnicolucci opened a new pull request #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
pnicolucci opened a new pull request #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520385#comment-16520385 ] ASF GitHub Bot commented on MYFACES-4239: - pnicolucci opened a new pull request #8:

[GitHub] pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399469835 I'll refactor a bit to use the SharedStringBuilder. Thanks for the information / review!

[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements

2018-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520449#comment-16520449 ] ASF GitHub Bot commented on MYFACES-4239: - pnicolucci commented on issue #8: MYFACES-4239: