Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-24 Thread via GitHub
tandraschko commented on PR #705: URL: https://github.com/apache/myfaces/pull/705#issuecomment-2074927528 TBH i would some time for debugging and i dont have this maybe just the channelToken generation is wrong, dont know currently, sorry -- This is an automated message from the

Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-24 Thread via GitHub
tandraschko commented on PR #705: URL: https://github.com/apache/myfaces/pull/705#issuecomment-2074843461 how are the channelTokens generated? i wonder that if you open index.xhtml in two different tabs, does it use the same channelToken? -- This is an automated message from the

Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-24 Thread via GitHub
milansie commented on PR #705: URL: https://github.com/apache/myfaces/pull/705#issuecomment-2074902294 Yup, it seems so. If the channel is applicationScope, only one channelToken exists for the application. If the channel scope is session (and user is specified), there is same

Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub
melloware commented on PR #708: URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075470451 OK I did a git pull of the 4.1 branch and everything is passing for me with `mvn clean install`. logs below ``` [INFO]

Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub
melloware commented on PR #708: URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075471785 let me try your branch now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] build(deps): bump quarkus.version from 1.13.7.Final to 3.10.0 [myfaces-tobago]

2024-04-24 Thread via GitHub
dependabot[bot] opened a new pull request, #5087: URL: https://github.com/apache/myfaces-tobago/pull/5087 Bumps `quarkus.version` from 1.13.7.Final to 3.10.0. Updates `io.quarkus:quarkus-bom` from 1.13.7.Final to 3.10.0 Release notes Sourced from

Re: [PR] build(deps): bump quarkus.version from 1.13.7.Final to 3.9.4 [myfaces-tobago]

2024-04-24 Thread via GitHub
dependabot[bot] commented on PR #5083: URL: https://github.com/apache/myfaces-tobago/pull/5083#issuecomment-2075420916 Superseded by #5087. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] build(deps): bump quarkus.version from 1.13.7.Final to 3.9.4 [myfaces-tobago]

2024-04-24 Thread via GitHub
dependabot[bot] closed pull request #5083: build(deps): bump quarkus.version from 1.13.7.Final to 3.9.4 URL: https://github.com/apache/myfaces-tobago/pull/5083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Myfaces 4662 [myfaces]

2024-04-24 Thread via GitHub
volosied opened a new pull request, #708: URL: https://github.com/apache/myfaces/pull/708 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub
volosied commented on PR #708: URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075445624 @melloware I'm hitting this in the quarkus tests? Not sure why -- it doesn't look related to my changes? Can you test / investigate this PR? ```

Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub
volosied commented on PR #708: URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075478696 Might just be something with my system then. Thanks for checking! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub
melloware commented on PR #708: URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075476511 OK your branch is also all passing for me locally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub
melloware commented on PR #708: URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075459835 yep let me look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.