[RESULT] [VOTE] Release Tobago 3.0.4

[Bernd Bohmann]

Hello

Udo is on vacation i will take over the next steps.

The result is

+1
Bernd Bohmann (binding)
Dennis Kieselhorst (binding)
Henning Nöth
Werner Punz (binding)
Mustafa Agâh Öztürk

so I will proceed with the next steps for the release.

Regards

Bernd

On Fri, Apr 7, 2017 at 2:57 PM, Mustafa Agâh Öztürk 
wrote:

> +1 from me.
>
>
> On 04/07/2017 03:53 PM, Werner Punz wrote:
> > +1
> >
> > Werner
> >
> >
> > Am 06.04.17 um 10:58 schrieb Udo Schnurpfeil:
> >> Hello,
> >>
> >> I would like to release Tobago 3.0.4.
> >>
> >> This is a PATCH release with backwards-compatible bug fixes.
> >>
> >> For a detail list please consult the release notes at:
> >>
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12310273=12340258
> >>
> >>
> >> The version is available at the staging repository (Nexus) at:
> >>
> >> https://repository.apache.org/content/repositories/
> orgapachemyfaces-1102/
> >>
> >>
> >> Please vote now! (The vote is open for 72h.)
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Regards,
> >> Udo
> >>
> >
> >
>
>

[jira] [Commented] (TRINIDAD-2508) JSF 2.2 @MultipartConfig on FacesServlet breaks Trinidad file upload

[Bernd Bohmann (JIRA)]

[ 
https://issues.apache.org/jira/browse/TRINIDAD-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962190#comment-15962190
 ] 

Bernd Bohmann commented on TRINIDAD-2508:
-

Tested with:
myfaces 2.1.18 and jetty-plugin 7.6.9.v20130131

trinidad-example/trinidad-demo$ mvn -PjettyConfig jetty:run

and:

myfaces 2.2.12 and jetty-plugin 9.2.21.v20170120

trinidad-example/trinidad-demo$ mvn -PjettyConfig -Djsfversion=2.2 jetty:run


> JSF 2.2 @MultipartConfig on FacesServlet breaks Trinidad file upload
> 
>
> Key: TRINIDAD-2508
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2508
> Project: MyFaces Trinidad
>  Issue Type: Bug
>Reporter: Andy Schwartz
>Assignee: Dennis Kieselhorst
> Fix For: 2.1.3-core
>
> Attachments: trinidad-2508.patch
>
>
> I have been testing Trinidad against JSF 2.2.  So far everything looks good 
> with one exception:  Trinidad's file upload feature is broken.
> I traced this down to a conflict between Java EE's multipart form support and 
> Trinidad file upload.  Both Java EE and Trinidad are capable of processing 
> multipart forms.  However, the multipart request input stream can only be 
> read once, which means that only one layer gets to do this work.
> Trinidad processes multipart forms in its FileUploadConfiguratorImpl, which 
> is run from inside TrinidadFilterImpl.doFilter().  However, when running 
> against JSF 2.2, the servlet engine (WLS in my case) is reading the request 
> input stream before we get this far.  I found that this was happening in 
> response to servlet request parameter lookups that are made by other 
> Configurators.
> The change in behavior from JSF 2.1 to JSF 2.2 is this:  prior to JSF 2.2 - 
> and specifically, prior to the introduction of the @MultipartConfig 
> annotation to FacesServlet, request parameter lookups that are made before 
> the FileUploadConfiguratorImpl processes the multipart data would fail - ie. 
> would return null without reading the request input stream.
> After upgrading to JSF 2.2, the presence of the @MultipartConfig now tells 
> the servlet engine that it is responsible for reading multipart form data.  
> Thus, request parameter lookups which previously behaved as no-ops are now 
> causing the request input stream to be read.  As a result, by the time 
> FileUploadConfiguratorImpl is invoked, there is no data left on the request 
> input stream and Trinidad does not recognize that there are uploaded files.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (TRINIDAD-2508) JSF 2.2 @MultipartConfig on FacesServlet breaks Trinidad file upload

[Bernd Bohmann (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TRINIDAD-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bernd Bohmann resolved TRINIDAD-2508.
-
Resolution: Fixed
  Assignee: Dennis Kieselhorst  (was: Bernd Bohmann)

I need a review of my changes and some more feedback/testing

> JSF 2.2 @MultipartConfig on FacesServlet breaks Trinidad file upload
> 
>
> Key: TRINIDAD-2508
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2508
> Project: MyFaces Trinidad
>  Issue Type: Bug
>Reporter: Andy Schwartz
>Assignee: Dennis Kieselhorst
> Fix For: 2.1.3-core
>
> Attachments: trinidad-2508.patch
>
>
> I have been testing Trinidad against JSF 2.2.  So far everything looks good 
> with one exception:  Trinidad's file upload feature is broken.
> I traced this down to a conflict between Java EE's multipart form support and 
> Trinidad file upload.  Both Java EE and Trinidad are capable of processing 
> multipart forms.  However, the multipart request input stream can only be 
> read once, which means that only one layer gets to do this work.
> Trinidad processes multipart forms in its FileUploadConfiguratorImpl, which 
> is run from inside TrinidadFilterImpl.doFilter().  However, when running 
> against JSF 2.2, the servlet engine (WLS in my case) is reading the request 
> input stream before we get this far.  I found that this was happening in 
> response to servlet request parameter lookups that are made by other 
> Configurators.
> The change in behavior from JSF 2.1 to JSF 2.2 is this:  prior to JSF 2.2 - 
> and specifically, prior to the introduction of the @MultipartConfig 
> annotation to FacesServlet, request parameter lookups that are made before 
> the FileUploadConfiguratorImpl processes the multipart data would fail - ie. 
> would return null without reading the request input stream.
> After upgrading to JSF 2.2, the presence of the @MultipartConfig now tells 
> the servlet engine that it is responsible for reading multipart form data.  
> Thus, request parameter lookups which previously behaved as no-ops are now 
> causing the request input stream to be read.  As a result, by the time 
> FileUploadConfiguratorImpl is invoked, there is no data left on the request 
> input stream and Trinidad does not recognize that there are uploaded files.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Trinidad Release ?

[Dennis Kieselhorst]

Hi,

as already posted on Twitter yesterday:
2.1.3 is about to be released soon. Any issues you'd like to see in there?
Please let us know! Patches appreciated.

I'll also post this on the users list.

Cheers
Dennis



--
View this message in context: 
http://myfaces.10567.n7.nabble.com/Trinidad-Release-tp123079p123260.html
Sent from the My Faces - Dev mailing list archive at Nabble.com.