[jira] [Resolved] (MYFACES-4252) Classpath._searchDir can throw NullPointerException
[ https://issues.apache.org/jira/browse/MYFACES-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Lucy resolved MYFACES-4252. Resolution: Fixed Fix Version/s: 2.3.3 2.2.13 2.1.19 2.0.25 > Classpath._searchDir can throw NullPointerException > --- > > Key: MYFACES-4252 > URL: https://issues.apache.org/jira/browse/MYFACES-4252 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.0.24, 2.1.18, 2.2.12, 2.3.1 > Environment: WebSphere 9 >Reporter: Bill Lucy >Assignee: Bill Lucy >Priority: Major > Fix For: 2.0.25, 2.1.19, 2.2.13, 2.3.3 > > > In rare cases, Classpath._searchDir can throw a NPE and cause startup to > fail. I'll update _searchDir() to tolerate the case where File.listFiles() > returns null. > DefaultFacesC I Reading config /WEB-INF/faces-config.xml > AbstractFaces E An error occured while initializing MyFaces: > java.lang.NullPointerException > javax.faces.FacesException: java.lang.NullPointerException > > Caused by: java.lang.NullPointerException > at > org.apache.myfaces.view.facelets.util.Classpath._searchDir(Classpath.java:143) > at > org.apache.myfaces.view.facelets.util.Classpath._searchResource(Classpath.java:115) > at org.apache.myfaces.view.facelets.util.Classpath.search(Classpath.java:68) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4252) Classpath._searchDir can throw NullPointerException
[
https://issues.apache.org/jira/browse/MYFACES-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614906#comment-16614906
]
ASF GitHub Bot commented on MYFACES-4252:
-
wtlucy closed pull request #21: MYFACES-4252 fix Classpath._searchDir NPE 2.2.X
URL: https://github.com/apache/myfaces/pull/21
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
index b2f5ee4d6..c82b1b0da 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
@@ -140,20 +140,23 @@ public Object run()
}
if (dirExists && dir.isDirectory())
{
-for (File file : dir.listFiles())
+File[] dirFiles = dir.listFiles();
+if (dirFiles != null)
{
-String path = file.getAbsolutePath();
-if (file.isDirectory())
+for (File file : dirFiles)
{
-_searchDir(result, file, suffix);
-}
-else if (path.endsWith(suffix))
-{
-result.add(file.toURI().toURL());
+String path = file.getAbsolutePath();
+if (file.isDirectory())
+{
+_searchDir(result, file, suffix);
+}
+else if (path.endsWith(suffix))
+{
+result.add(file.toURI().toURL());
+}
}
+return true;
}
-
-return true;
}
return false;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Classpath._searchDir can throw NullPointerException
> ---
>
> Key: MYFACES-4252
> URL: https://issues.apache.org/jira/browse/MYFACES-4252
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.24, 2.1.18, 2.2.12, 2.3.1
> Environment: WebSphere 9
>Reporter: Bill Lucy
>Assignee: Bill Lucy
>Priority: Major
>
> In rare cases, Classpath._searchDir can throw a NPE and cause startup to
> fail. I'll update _searchDir() to tolerate the case where File.listFiles()
> returns null.
> DefaultFacesC I Reading config /WEB-INF/faces-config.xml
> AbstractFaces E An error occured while initializing MyFaces:
> java.lang.NullPointerException
> javax.faces.FacesException: java.lang.NullPointerException
>
> Caused by: java.lang.NullPointerException
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchDir(Classpath.java:143)
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchResource(Classpath.java:115)
> at org.apache.myfaces.view.facelets.util.Classpath.search(Classpath.java:68)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MYFACES-4252) Classpath._searchDir can throw NullPointerException
[
https://issues.apache.org/jira/browse/MYFACES-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614907#comment-16614907
]
ASF GitHub Bot commented on MYFACES-4252:
-
wtlucy closed pull request #22: MYFACES-4252 fix Classpath._searchDir NPE
URL: https://github.com/apache/myfaces/pull/22
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
index b2f5ee4d6..c82b1b0da 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
@@ -140,20 +140,23 @@ public Object run()
}
if (dirExists && dir.isDirectory())
{
-for (File file : dir.listFiles())
+File[] dirFiles = dir.listFiles();
+if (dirFiles != null)
{
-String path = file.getAbsolutePath();
-if (file.isDirectory())
+for (File file : dirFiles)
{
-_searchDir(result, file, suffix);
-}
-else if (path.endsWith(suffix))
-{
-result.add(file.toURI().toURL());
+String path = file.getAbsolutePath();
+if (file.isDirectory())
+{
+_searchDir(result, file, suffix);
+}
+else if (path.endsWith(suffix))
+{
+result.add(file.toURI().toURL());
+}
}
+return true;
}
-
-return true;
}
return false;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Classpath._searchDir can throw NullPointerException
> ---
>
> Key: MYFACES-4252
> URL: https://issues.apache.org/jira/browse/MYFACES-4252
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.24, 2.1.18, 2.2.12, 2.3.1
> Environment: WebSphere 9
>Reporter: Bill Lucy
>Assignee: Bill Lucy
>Priority: Major
>
> In rare cases, Classpath._searchDir can throw a NPE and cause startup to
> fail. I'll update _searchDir() to tolerate the case where File.listFiles()
> returns null.
> DefaultFacesC I Reading config /WEB-INF/faces-config.xml
> AbstractFaces E An error occured while initializing MyFaces:
> java.lang.NullPointerException
> javax.faces.FacesException: java.lang.NullPointerException
>
> Caused by: java.lang.NullPointerException
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchDir(Classpath.java:143)
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchResource(Classpath.java:115)
> at org.apache.myfaces.view.facelets.util.Classpath.search(Classpath.java:68)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] wtlucy closed pull request #21: MYFACES-4252 fix Classpath._searchDir NPE 2.2.X
wtlucy closed pull request #21: MYFACES-4252 fix Classpath._searchDir NPE 2.2.X
URL: https://github.com/apache/myfaces/pull/21
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
index b2f5ee4d6..c82b1b0da 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
@@ -140,20 +140,23 @@ public Object run()
}
if (dirExists && dir.isDirectory())
{
-for (File file : dir.listFiles())
+File[] dirFiles = dir.listFiles();
+if (dirFiles != null)
{
-String path = file.getAbsolutePath();
-if (file.isDirectory())
+for (File file : dirFiles)
{
-_searchDir(result, file, suffix);
-}
-else if (path.endsWith(suffix))
-{
-result.add(file.toURI().toURL());
+String path = file.getAbsolutePath();
+if (file.isDirectory())
+{
+_searchDir(result, file, suffix);
+}
+else if (path.endsWith(suffix))
+{
+result.add(file.toURI().toURL());
+}
}
+return true;
}
-
-return true;
}
return false;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MYFACES-4252) Classpath._searchDir can throw NullPointerException
[
https://issues.apache.org/jira/browse/MYFACES-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614905#comment-16614905
]
ASF GitHub Bot commented on MYFACES-4252:
-
wtlucy closed pull request #20: MYFACES-4252 fix Classpath._searchDir NPE 2.1.X
URL: https://github.com/apache/myfaces/pull/20
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
index b2f5ee4d6..c82b1b0da 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
@@ -140,20 +140,23 @@ public Object run()
}
if (dirExists && dir.isDirectory())
{
-for (File file : dir.listFiles())
+File[] dirFiles = dir.listFiles();
+if (dirFiles != null)
{
-String path = file.getAbsolutePath();
-if (file.isDirectory())
+for (File file : dirFiles)
{
-_searchDir(result, file, suffix);
-}
-else if (path.endsWith(suffix))
-{
-result.add(file.toURI().toURL());
+String path = file.getAbsolutePath();
+if (file.isDirectory())
+{
+_searchDir(result, file, suffix);
+}
+else if (path.endsWith(suffix))
+{
+result.add(file.toURI().toURL());
+}
}
+return true;
}
-
-return true;
}
return false;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Classpath._searchDir can throw NullPointerException
> ---
>
> Key: MYFACES-4252
> URL: https://issues.apache.org/jira/browse/MYFACES-4252
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.24, 2.1.18, 2.2.12, 2.3.1
> Environment: WebSphere 9
>Reporter: Bill Lucy
>Assignee: Bill Lucy
>Priority: Major
>
> In rare cases, Classpath._searchDir can throw a NPE and cause startup to
> fail. I'll update _searchDir() to tolerate the case where File.listFiles()
> returns null.
> DefaultFacesC I Reading config /WEB-INF/faces-config.xml
> AbstractFaces E An error occured while initializing MyFaces:
> java.lang.NullPointerException
> javax.faces.FacesException: java.lang.NullPointerException
>
> Caused by: java.lang.NullPointerException
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchDir(Classpath.java:143)
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchResource(Classpath.java:115)
> at org.apache.myfaces.view.facelets.util.Classpath.search(Classpath.java:68)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] wtlucy closed pull request #22: MYFACES-4252 fix Classpath._searchDir NPE
wtlucy closed pull request #22: MYFACES-4252 fix Classpath._searchDir NPE
URL: https://github.com/apache/myfaces/pull/22
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
index b2f5ee4d6..c82b1b0da 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
@@ -140,20 +140,23 @@ public Object run()
}
if (dirExists && dir.isDirectory())
{
-for (File file : dir.listFiles())
+File[] dirFiles = dir.listFiles();
+if (dirFiles != null)
{
-String path = file.getAbsolutePath();
-if (file.isDirectory())
+for (File file : dirFiles)
{
-_searchDir(result, file, suffix);
-}
-else if (path.endsWith(suffix))
-{
-result.add(file.toURI().toURL());
+String path = file.getAbsolutePath();
+if (file.isDirectory())
+{
+_searchDir(result, file, suffix);
+}
+else if (path.endsWith(suffix))
+{
+result.add(file.toURI().toURL());
+}
}
+return true;
}
-
-return true;
}
return false;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MYFACES-4252) Classpath._searchDir can throw NullPointerException
[
https://issues.apache.org/jira/browse/MYFACES-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614904#comment-16614904
]
ASF GitHub Bot commented on MYFACES-4252:
-
wtlucy closed pull request #19: MYFACES-4252 fix Classpath._searchDir NPE 2.0.X
URL: https://github.com/apache/myfaces/pull/19
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
index b2f5ee4d6..c82b1b0da 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
@@ -140,20 +140,23 @@ public Object run()
}
if (dirExists && dir.isDirectory())
{
-for (File file : dir.listFiles())
+File[] dirFiles = dir.listFiles();
+if (dirFiles != null)
{
-String path = file.getAbsolutePath();
-if (file.isDirectory())
+for (File file : dirFiles)
{
-_searchDir(result, file, suffix);
-}
-else if (path.endsWith(suffix))
-{
-result.add(file.toURI().toURL());
+String path = file.getAbsolutePath();
+if (file.isDirectory())
+{
+_searchDir(result, file, suffix);
+}
+else if (path.endsWith(suffix))
+{
+result.add(file.toURI().toURL());
+}
}
+return true;
}
-
-return true;
}
return false;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Classpath._searchDir can throw NullPointerException
> ---
>
> Key: MYFACES-4252
> URL: https://issues.apache.org/jira/browse/MYFACES-4252
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.24, 2.1.18, 2.2.12, 2.3.1
> Environment: WebSphere 9
>Reporter: Bill Lucy
>Assignee: Bill Lucy
>Priority: Major
>
> In rare cases, Classpath._searchDir can throw a NPE and cause startup to
> fail. I'll update _searchDir() to tolerate the case where File.listFiles()
> returns null.
> DefaultFacesC I Reading config /WEB-INF/faces-config.xml
> AbstractFaces E An error occured while initializing MyFaces:
> java.lang.NullPointerException
> javax.faces.FacesException: java.lang.NullPointerException
>
> Caused by: java.lang.NullPointerException
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchDir(Classpath.java:143)
> at
> org.apache.myfaces.view.facelets.util.Classpath._searchResource(Classpath.java:115)
> at org.apache.myfaces.view.facelets.util.Classpath.search(Classpath.java:68)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] wtlucy closed pull request #20: MYFACES-4252 fix Classpath._searchDir NPE 2.1.X
wtlucy closed pull request #20: MYFACES-4252 fix Classpath._searchDir NPE 2.1.X
URL: https://github.com/apache/myfaces/pull/20
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
index b2f5ee4d6..c82b1b0da 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
@@ -140,20 +140,23 @@ public Object run()
}
if (dirExists && dir.isDirectory())
{
-for (File file : dir.listFiles())
+File[] dirFiles = dir.listFiles();
+if (dirFiles != null)
{
-String path = file.getAbsolutePath();
-if (file.isDirectory())
+for (File file : dirFiles)
{
-_searchDir(result, file, suffix);
-}
-else if (path.endsWith(suffix))
-{
-result.add(file.toURI().toURL());
+String path = file.getAbsolutePath();
+if (file.isDirectory())
+{
+_searchDir(result, file, suffix);
+}
+else if (path.endsWith(suffix))
+{
+result.add(file.toURI().toURL());
+}
}
+return true;
}
-
-return true;
}
return false;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wtlucy closed pull request #19: MYFACES-4252 fix Classpath._searchDir NPE 2.0.X
wtlucy closed pull request #19: MYFACES-4252 fix Classpath._searchDir NPE 2.0.X
URL: https://github.com/apache/myfaces/pull/19
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
index b2f5ee4d6..c82b1b0da 100644
--- a/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
+++ b/impl/src/main/java/org/apache/myfaces/view/facelets/util/Classpath.java
@@ -140,20 +140,23 @@ public Object run()
}
if (dirExists && dir.isDirectory())
{
-for (File file : dir.listFiles())
+File[] dirFiles = dir.listFiles();
+if (dirFiles != null)
{
-String path = file.getAbsolutePath();
-if (file.isDirectory())
+for (File file : dirFiles)
{
-_searchDir(result, file, suffix);
-}
-else if (path.endsWith(suffix))
-{
-result.add(file.toURI().toURL());
+String path = file.getAbsolutePath();
+if (file.isDirectory())
+{
+_searchDir(result, file, suffix);
+}
+else if (path.endsWith(suffix))
+{
+result.add(file.toURI().toURL());
+}
}
+return true;
}
-
-return true;
}
return false;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (TOBAGO-1929) Wrong severity for message on form elements
Henning Noeth created TOBAGO-1929:
-
Summary: Wrong severity for message on form elements
Key: TOBAGO-1929
URL: https://issues.apache.org/jira/browse/TOBAGO-1929
Project: MyFaces Tobago
Issue Type: Bug
Components: Core
Affects Versions: 4.2.1
Reporter: Henning Noeth
Since MyFaces v2.2 the message on form elements show a warning instead of an
error.
The message shown in the component show a correct error.
Tested with:
MyFaces v2.0 - correct
MyFaces v2.1 - correct
MyFaces v2.2 - warning instead of error
MyFaces v2.3 - warning instead of error
Example:
{code:xml}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Fwd: MODERATE for annou...@apache.org
SHA1 hashes have been deprecated for some time on download pages (*) The announce was moderated this time, but the download page must be fixed for the next release. This means using SHA256 or SHA512 instead of SHA1. Thanks. (*) http://www.apache.org/dev/release-distribution#sigs-and-sums -- Forwarded message -- From: Paul Nicolucci To: Cc: Bcc: Date: Wed, 12 Sep 2018 14:17:13 - Subject: [ANNOUNCE] MyFaces Core v2.3.2 Release The Apache MyFaces team is pleased to announce the release of MyFaces Core 2.3.2. MyFaces Core is a JavaServer(tm) Faces 2.3 implementation as specified by JSR-372. JavaServer Faces (JSF) is a Java specification for building component-based user interfaces for web applications. MyFaces Core 2.3.2 is available in both binary and source distributions. * http://myfaces.apache.org/download.html MyFaces Core is also available in the central Maven repository under Group ID "org.apache.myfaces.core". Release Notes - MyFaces Core - Version 2.3.2 can be found in the following link: https://issues.apache.org/jira/secure/ReleaseNote.jspa? projectId=10600=12343156 Regards, Paul Nicolucci
