[jira] [Commented] (MYFACES-4267) transient attribute is not inherited from template to final page.

2018-11-23 Thread Thomas Andraschko (JIRA)


[ 
https://issues.apache.org/jira/browse/MYFACES-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697412#comment-16697412
 ] 

Thomas Andraschko commented on MYFACES-4267:


Could you also provide a Sample Template and View?

> transient attribute is not inherited from template to final page.
> -
>
> Key: MYFACES-4267
> URL: https://issues.apache.org/jira/browse/MYFACES-4267
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: Extension Feature
>Affects Versions: 2.3.2
>Reporter: Antgar
>Priority: Critical
>
> After upgrading from Myfaces 2.2 to 2.3, templated transient views stop to 
> work, raising "unable to create views" exceptions.
> f:view transient attribute defined in a template seems not to be inherited by 
> the final page correctly. With myfaces 2.2 it worked correctly, but in 2.3, 
> there is a new check 
> {code:java}
> if (!view.isTransient()) ...
> {code}
> on FaceletViewDeclarationLanguage line 2128. On page restoring, transient 
> appears as false.
> A workaround is to set transient="true" on the final page too. Other option 
> is to use a block 
> {code:java}
> 
> {code}
> on the final page (f:metadata doc says it shouldn't be used in templates).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MYFACES-4268) Opening a dynamic dialog from a command with resetAttributes="true" makes a duplicated POST request.

2018-11-23 Thread Thomas Andraschko (JIRA)


[ 
https://issues.apache.org/jira/browse/MYFACES-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697411#comment-16697411
 ] 

Thomas Andraschko commented on MYFACES-4268:


Please provide a example, otherwise its Impossible for us to replicate.

> Opening a dynamic dialog from a command with resetAttributes="true" makes a 
> duplicated POST request.
> 
>
> Key: MYFACES-4268
> URL: https://issues.apache.org/jira/browse/MYFACES-4268
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 2.3.2
>Reporter: Antgar
>Priority: Minor
>
> If a dynamic dialog containing a form is oppened from a command with 
> resetValues set to true, two POST requests are made returning the same 
> information. It should be loaded only once.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MYFACES-4268) Opening a dynamic dialog from a command with resetAttributes="true" makes a duplicated POST request.

2018-11-23 Thread Antgar (JIRA)
Antgar created MYFACES-4268:
---

 Summary: Opening a dynamic dialog from a command with 
resetAttributes="true" makes a duplicated POST request.
 Key: MYFACES-4268
 URL: https://issues.apache.org/jira/browse/MYFACES-4268
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 2.3.2
Reporter: Antgar


If a dynamic dialog containing a form is oppened from a command with 
resetValues set to true, two POST requests are made returning the same 
information. It should be loaded only once.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MYFACES-4267) transient attribute is not inherited from template to final page.

2018-11-23 Thread Antgar (JIRA)
Antgar created MYFACES-4267:
---

 Summary: transient attribute is not inherited from template to 
final page.
 Key: MYFACES-4267
 URL: https://issues.apache.org/jira/browse/MYFACES-4267
 Project: MyFaces Core
  Issue Type: Bug
  Components: Extension Feature
Affects Versions: 2.3.2
Reporter: Antgar


After upgrading from Myfaces 2.2 to 2.3, templated transient views stop to 
work, raising "unable to create views" exceptions.
Transient attribute of a template seems not to be inherited by the final page 
correctly. With myfaces 2.2 it worked correctly, but in 2.3, there is a new 
check view.isTransient() on FaceletViewDeclarationLanguage line 2128. On page 
restoring, transient appears as false.

A workaround is to set transient="true" on the final page too. Other option is 
to use a block  on the 
final page (f:metadata doc says it shouldn't be used in templates).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Tobago 3.1.1 and 4.3.2

2018-11-23 Thread Henning Nöth
+1

Am 21.11.18 um 17:09 schrieb Udo Schnurpfeil:
> Hello,
> 
> We would like to release
> * Tobago 4.3.2
> * Tobago 3.1.1
> 
> The demos on http://tobago-vm.apache.org/ where updated.
> 
> Major changes since last release are:
> 
> Tobago 4.3.2
> * Bugfixes
> 
> Tobago 3.1.1
> * Bugfixes
> 
> For a detail list please consult the release notes at:
> 
> Tobago 4.3.2
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273=12344394
> 
> Tobago 3.1.1
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273=12343478
> 
> 
> The version is available at the staging repository (Nexus) at:
> 
> https://repository.apache.org/content/repositories/orgapachemyfaces-1146/
> 
> The sources are:
> 
> https://repository.apache.org/content/repositories/orgapachemyfaces-1146/org/apache/myfaces/tobago/tobago/4.3.2/tobago-4.3.2-source-release.zip
> (sha-256 d0b40a6373705d825b79e32eeae4013eb8a7960d877fcf003252e6dd040e0aa9)
> 
> https://repository.apache.org/content/repositories/orgapachemyfaces-1146/org/apache/myfaces/tobago/tobago/3.1.1/tobago-3.1.1-source-release.zip
> (sha-256 6d42c586d8bdaf16db2d716678e45e024ca4602dd6f6cdc62d56081843661179)
> 
> 
> Please vote now! (The vote is open for 72h.)
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> Regards,
> 
> Udo
> 
> 
> 



signature.asc
Description: OpenPGP digital signature


[jira] [Created] (TOBAGO-1960) FacesMessage button doesn't hide in Safari if using ajax

2018-11-23 Thread Henning Noeth (JIRA)
Henning Noeth created TOBAGO-1960:
-

 Summary: FacesMessage button doesn't hide in Safari if using ajax
 Key: TOBAGO-1960
 URL: https://issues.apache.org/jira/browse/TOBAGO-1960
 Project: MyFaces Tobago
  Issue Type: Task
  Components: Core, Themes
Affects Versions: 4.3.1
Reporter: Henning Noeth


To reproduce the issue use the following example:
{code:xml}
  
{code}

1. Select the 'hello' value.
2. Remove the 'hello' value.
3. TAB -> An error occur "field required"
4. Select input field
5. Add valid value
6. TAB
Result: in Safari the "field required" is show even though there is no error



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MYFACES-4266) Ajax update fails due to invalid characters in response XML (DoS)

2018-11-23 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/MYFACES-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696530#comment-16696530
 ] 

ASF GitHub Bot commented on MYFACES-4266:
-

tandraschko commented on issue #27: MYFACES-4266: Ajax update fails due to 
invalid characters in response XML (DoS)
URL: https://github.com/apache/myfaces/pull/27#issuecomment-441182397
 
 
   cool :D
   
   I'm a just a bit unsure... The current version will work but maybe it's a 
bit "unattractive".
   
   1) I think we should overwrite all #write methods, to cover 100% all cases?! 
Probably also writeText?
   2) all #write methods should call the same super.write - currently the 
write(String) calls super.write(char[]) to avoid confusion (and maybe but 
unlikely bugs)
   
   JFYI: you can also use a for-each loop when looping over arrays, we just 
avoid it on ArrayLists, to avoid a iterator instance (ArrayLists are used for 
component lists e.g. and the component tree is traversed very often)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Ajax update fails due to invalid characters in response XML (DoS)
> -
>
> Key: MYFACES-4266
> URL: https://issues.apache.org/jira/browse/MYFACES-4266
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 2.3.2
> Environment: jetty 9.4.14.v20181114
> JDK 10
>Reporter: cnsgithub
>Priority: Major
>
> I noticed that the {{}} update fails when the updated form contains 
> unicode characters, which are not allowed in the [XML 1.0 
> spec|https://www.w3.org/TR/REC-xml/#charsets].
> h2. Expected Behaviour
> If the update response contains characters that are not allowed in XML, they 
> should be filtered by MyFaces before writing the response.
> h2. Actual Behaviour
> Some illegal XML characters are not filtered and therefore the browser fails 
> to parse the response.
> h2. Steps to reproduce
> I created a small github project to reproduce this behaviour: 
> [https://github.com/cnsgithub/mojarra-ajax/tree/myfaces] (branch myfaces)
>  To reproduce:
>  - {{git clone [https://github.com/cnsgithub/mojarra-ajax]}}
>  - {{git checkout myfaces}}
>  - run {{mvn clean package jetty:run}}
>  - after the server has started, open [http://localhost:8080/index.xhtml]
>  - Click the button, the error should occur
> The issue also occurs with user supplied inputs:
>  - open [http://localhost:8080/input.xhtml]
>  - Paste the characters from the {{illegal-xml-chars.txt}} file into the 
> input field
>  - Click the button
> This issue should be addressed with high priority since it is security 
> related (might be exploited for Denial of Service).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] tandraschko commented on issue #27: MYFACES-4266: Ajax update fails due to invalid characters in response XML (DoS)

2018-11-23 Thread GitBox
tandraschko commented on issue #27: MYFACES-4266: Ajax update fails due to 
invalid characters in response XML (DoS)
URL: https://github.com/apache/myfaces/pull/27#issuecomment-441182397
 
 
   cool :D
   
   I'm a just a bit unsure... The current version will work but maybe it's a 
bit "unattractive".
   
   1) I think we should overwrite all #write methods, to cover 100% all cases?! 
Probably also writeText?
   2) all #write methods should call the same super.write - currently the 
write(String) calls super.write(char[]) to avoid confusion (and maybe but 
unlikely bugs)
   
   JFYI: you can also use a for-each loop when looping over arrays, we just 
avoid it on ArrayLists, to avoid a iterator instance (ArrayLists are used for 
component lists e.g. and the component tree is traversed very often)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services