Re: PRs and reviews

2015-11-04 Thread Adam Bordelon
- Including "Fixes #123" in the commit message will tell asfbot to close the PR/issue. On Wed, Nov 4, 2015 at 4:18 PM, Jim Klucar <klu...@gmail.com> wrote: > I'd like to discuss how we do PRs and code reviews. Right now we are using > github most likely because that's how w

PRs and reviews

2015-11-04 Thread Jim Klucar
I'd like to discuss how we do PRs and code reviews. Right now we are using github most likely because that's how we did it before Apache. Now the code lives in the Apache hosted repo and we have Review Board available to us. My assumption is that we are individually more familiar with one way