Re: svn commit: r1867663 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml

2019-09-28 Thread Swapnil M Mane
Hi Deepak, Happy to see your commits in action. :) Just a minor suggestion, we put Jira ticket ID in separate line in commit log. Also, add colon ':' in Thanks statement. And since the ticket type is 'Improvement', it seems to me, we should use 'Improved' instead of 'Fixed'. Here is commit

Re: buildbot failure in on ofbizTrunkFramework

2019-09-28 Thread Pawan Verma
This was due to the wrong invoiceContentTypeId set for the test testCreateSimpleTextContentForInvoice. Fixed at r1867673. -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com On Sat, Sep 28, 2019 at 6:12 PM wrote:

[DISCUSSION] R16 and R17: email password issue and releases

2019-09-28 Thread Jacques Le Roux
Hi, As reported by Rashi Dhagat in OFBIZ-11215 "Email password is not working" in R16, and actually nor in R17. It has been fixed in trunk and R18 with OFBIZ-4361. As mentioned there, it's hard to backport to R17 not even speaking about R16! I wonder if a case like that would not make R16

Re: Improvements in ProductCategoryMember

2019-09-28 Thread Jacques Le Roux
Hi Suraj, This seems legit to me, I see no harm in it and can be helpful indeed. Jacques Le 25/09/2019 à 10:51, Suraj Khurana a écrit : Hello team, We should extend ProductCategoryMember with createdByUserLogin and createdDate fields. One use case is while creating a price rule/promotion and