OFBIZ-11900: Approach so far for MacroFormRenderer refactoring

Hello, OFBIZ-11900 covers the work-in-progress effort to refactor MacroFormRenderer by extracting code which builds strings to be executed as FTL macros into a separate builder class. This github branch [1] contains the work-in-progress changes for this issue. Please take a look at this branch

Re: Is the HTML renderer still used?

Thanks Daniel! Michael Brohl ecomify GmbH - www.ecomify.de Am 28.07.20 um 17:42 schrieb Daniel Watford: I did search but couldn't find anything using the HTML renderers. OFBIZ-6281 [1] and its related issues lead me to believe that the package should have been removed a while ago,

Re: Is the HTML renderer still used?

I did search but couldn't find anything using the HTML renderers. OFBIZ-6281 [1] and its related issues lead me to believe that the package should have been removed a while ago, particularly since HtmlScreenRenderer appears to have been removed. Michael, based on your comments I've created

Re: A little bit of Lombok

Hi Michael, I'd encourage tool use to help us produce software wherever possible, particularly those which are common in the java ecosystem and have a low barrier to entry. In my opinion Lombok is common enough that there are many tutorials available to help developers get up to speed, and it

Re: A little bit of Lombok

Hi I think we need to decide how much is the fair usage of lombok. I have used it previously and it does good job of taking care of removing boilerplate code. However, I feel care must also be taken to determine how much we use it because chances are that the code might not work (potentially) if

Re: Welcome Pawan Verma as new PMC member

Many congratulations Pawan!! Thanks. -- Mridul Pathak > On 28-Jul-2020, at 1:21 PM, Jacques Le Roux > wrote: > > The OFBiz PMC has invited Pawan Verma to become member of the committee and > we are glad to announce that he has accepted the nomination. > > On behalf of the OFBiz PMC, welcome

Re: A little bit of Lombok

La 28.07.2020 16:10, Michael Brohl a scris: Hi Daniel, can you explain what the advantages and disadvantages are? Is it worth the introduction of an additional framework, more complex IDE configuration, an additional Gradle plugin and more memory consumption and why? Thanks for

Re: Is the HTML renderer still used?

If the package is not used anywhere (havn't checked), we should deprecate and document it for the next release and remove it in the release which comes after the next release. This should give users enough time to change their projects accordingly. Thanks, Michael Brohl ecomify GmbH -

Re: A little bit of Lombok

Hi Daniel, can you explain what the advantages and disadvantages are? Is it worth the introduction of an additional framework, more complex IDE configuration, an additional Gradle plugin and more memory consumption and why? Thanks for clarification, Michael Brohl ecomify GmbH -

Re: Is the HTML renderer still used?

Hi Daniel, I indeed see only imports of org.apache.ofbiz.widget.renderer.html under framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/html HtmlMenuWrapper, which uses HtmlMenuRenderer, is used in MenuWrapTransform But I don't see any use of MenuWrapTransform OOTB through

A little bit of Lombok

Hello, Back in April the possibility of using Lombok for the generation of some boilerplate code was mentioned on the mailing list [1]. As part of work-in-progress on OFBIZ-11900 (refactoring MacroFormRenderer) I have used Lombok on a few small classes. The work-in-progress branch can be found

Re: Welcome Pawan Verma as new PMC member

Many congratulations Pawan! Kind regards, -- Ravi Lodhi On Tue, Jul 28, 2020 at 1:22 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Pawan Verma to become member of the committee > and we are glad to announce that he has accepted the nomination. > > On

Re: Welcome Pawan Verma as new PMC member

Many Many congrats Pawan..!! Thanks & Regards -- Deepak Dixit ofbiz.apache.org On Tue, Jul 28, 2020 at 2:18 PM Pritam Kute wrote: > Congratulations Pawan! > > Kind Regards, > -- > Pritam Kute > > > On Tue, Jul 28, 2020 at 2:16 PM Girish Vasmatkar < > girish.vasmat...@hotwaxsystems.com> wrote:

Re: Welcome Pawan Verma as new PMC member

Congratulations Pawan! Kind Regards, -- Pritam Kute On Tue, Jul 28, 2020 at 2:16 PM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Many congratulations Pawan. > > Best, > Girish > > On Tue, Jul 28, 2020 at 2:10 PM Devanshu Vyas > wrote: > > > Many many Congratulations Pawan!!

Re: Welcome Pawan Verma as new PMC member

Many congratulations Pawan. Best, Girish On Tue, Jul 28, 2020 at 2:10 PM Devanshu Vyas wrote: > Many many Congratulations Pawan!! > > > Thanks & Regards, > Devanshu Vyas. > > > On Tue, Jul 28, 2020 at 1:53 PM Aditya Sharma > wrote: > > > Felicitation Pawan!! > > > > Thanks and Regards, > >

Re: Welcome Pawan Verma as new PMC member

Many many Congratulations Pawan!! Thanks & Regards, Devanshu Vyas. On Tue, Jul 28, 2020 at 1:53 PM Aditya Sharma wrote: > Felicitation Pawan!! > > Thanks and Regards, > Aditya Sharma > > On Tue, Jul 28, 2020 at 1:22 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz

Re: Welcome Pawan Verma as new PMC member

Felicitation Pawan!! Thanks and Regards, Aditya Sharma On Tue, Jul 28, 2020 at 1:22 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Pawan Verma to become member of the committee > and we are glad to announce that he has accepted the nomination. > > On

Re: Welcome Pawan Verma as new PMC member

Many congratulations, Pawan! -- Kind Regards, Ashish Vijaywargiya Vice President of Operations *HotWax Systems* *Enterprise open source experts* cell: +91-9893479711 http://www.hotwaxsystems.com On Tue, Jul 28, 2020 at 1:22 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz

Re: Welcome Pawan Verma as new PMC member

Many congratulations, Pawan ! -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jul 28, 2020 at 1:22 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Pawan Verma to become member of the committee > and we are glad to announce that he has

Welcome Pawan Verma as new PMC member

The OFBiz PMC has invited Pawan Verma to become member of the committee and we are glad to announce that he has accepted the nomination. On behalf of the OFBiz PMC, welcome on board Pawan!