Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

2017-07-10 Thread Devanshu Vyas
+1 and the committer should leave the ticket open with the comment 'Need to backport the issue to the previous versions' Thanks & Regards, Devanshu Vyas. On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl <michael.br...@ecomify.de> wrote: > Hi everyone, > > I think we sho

Re: [Discussion] Failing the build if data loading fails

2017-07-10 Thread Devanshu Vyas
I agree with option #3 and the 'continue-on-failure' flag with default value=false. :) Thanks & Regards, Devanshu Vyas. On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb <slidingfilame...@gmail.com > wrote: > Hi Rishi, > > So my suggestion is that if anything does not load, th

Re: OFBiz Dev List and Deepak Dixit mentioned in ASF Annual Report

2017-07-02 Thread Devanshu Vyas
Thanks for sharing Sharan, and great job Deepak!! Thanks & Regards, Devanshu Vyas. On Fri, Jun 30, 2017 at 8:05 PM, Michael Brohl <michael.br...@ecomify.de> wrote: > Hi Sharan, > > thanks for sharing and "thumbs up" for Deepak :-) > > Best regards, > > M

Re: New ASF Members from OFBiz Community

2017-05-01 Thread Devanshu Vyas
Congratulations Nicolas!! Thanks & Regards, Devanshu Vyas. On Mon, May 1, 2017 at 3:52 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi All, > > Nicolas Malin is our last new ASF member, congratulations Nicolas. > > We have now 12 ASF members among our

Re: Inconsistent String Comparisons

2017-04-21 Thread Devanshu Vyas
Thanks Jacques. Even I was more reluctant to use the b) option. Now I will start my work for Freemarker files with the b) option i.e. '==' operator. Thanks & Regards, Devanshu Vyas. On Fri, Apr 21, 2017 at 1:40 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Dev

Re: New ASF Members from OFBiz Community

2017-04-04 Thread Devanshu Vyas
Many Congratulations to Anil and Ashish and Bilgin :) Thanks & Regards, Devanshu Vyas. On Wed, Apr 5, 2017 at 10:11 AM, Arvind Singh Tomar < arvind.to...@hotwaxsystems.com> wrote: > Great news, many congratulations to Anil, Ashish, Michael, Taher and Bilgin > Ibryam :)

Re: New ASF Members from OFBiz Community

2017-04-03 Thread Devanshu Vyas
Congratulations Micheal Brohl and Taher Alkhateeb!!! Thanks & Regards, Devanshu Vyas. On Mon, Apr 3, 2017 at 3:49 PM, Deepak Dixit <deepak.di...@hotwaxsystems.com > wrote: > Many Many Congrats Michael Brohl and Taher Alkhateeb !! > > Thanks & Rega

Re: Inconsistent String Comparisons

2017-04-03 Thread Devanshu Vyas
risons: a) <#if roleType.roleTypeId.equals("_NA_")> selected="selected" b) <#if showLocation == "Y"> I think it will be better to define a standard way to compare strings in FTL also. This will help in cleaning & improving the code. Let me know your t

Re: Welcome James Yong as a new committer

2017-03-14 Thread Devanshu Vyas
Many Congratulations James!!! Thanks & Regards, Devanshu Vyas. On Tue, Mar 14, 2017 at 5:23 PM, Swapnil Shah < swapnil.s...@hotwaxsystems.com> wrote: > Many congratulations James !! > > Thanks & Regards, > Swapnil > > -Original Message- > From: Jacop

Re: Welcome Deepak Dixit as a new PMC member

2017-02-26 Thread Devanshu Vyas
Many Congratulations Deepak!!! Thanks & Regards, Devanshu Vyas. On Fri, Feb 24, 2017 at 6:38 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Deepak Dixit to become a new member of the > committee; and the committee members are happy to anno

Re: Welcome Swapnil Shah as a New Committer!

2017-02-21 Thread Devanshu Vyas
Many Congratulations Swapnil Shah!!! Thanks & Regards, Devanshu Vyas. On Mon, Feb 20, 2017 at 3:29 PM, Swapnil Shah < swapnil.s...@hotwaxsystems.com> wrote: > Thank you everyone for this warm welcome to the club. While looking > forward to work with all of you, I am pretty sure,

Inconsistent String Comparisons

2017-01-09 Thread Devanshu Vyas
pattern can be found at several places and if you all agree with this I can provide a patch for correcting code. Let me know your thoughts. Thanks & Regards, Devanshu Vyas.

Validation messages to auto-attributes of a service

2016-10-12 Thread Devanshu Vyas
the validate messages on the fields. Something like this: Please share your thoughts. :) -- Thanks and Regards, Devanshu Vyas

[jira] [Updated] (OFBIZ-7577) Accounting: Correct all the checkboxes and radio buttons in all the accounting FTLs.

2016-07-02 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-7577: - Attachment: OFBIZ-7577.patch This patch contains all the corrected checkboxes and radio buttons

Re: Use of utility method for checking null GenericValue

2016-06-17 Thread Devanshu Vyas
Completely makes sense. +1 -- Thanks and Regards, Devanshu Vyas HotWax Systems *https://www.hotwaxsystems.com <https://www.hotwaxsystems.com>* On Fri, Jun 17, 2016 at 8:00 PM, Ratnesh Upadhyay < upadhyay.ratn...@gmail.com> wrote: > Hello community, > > There are lots of

[jira] [Commented] (OFBIZ-6361) createQuoteItem should display EditQuoteItem page instead of ListQuoteItems when error occurs like updateQuoteItem controller settings

2016-05-21 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295000#comment-15295000 ] Devanshu Vyas commented on OFBIZ-6361: -- And Changes are looking good to me. > createQuoteItem sho

[jira] [Commented] (OFBIZ-6361) createQuoteItem should display EditQuoteItem page instead of ListQuoteItems when error occurs like updateQuoteItem controller settings

2016-05-21 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294997#comment-15294997 ] Devanshu Vyas commented on OFBIZ-6361: -- I have verified the patch and it is working as expected. I

[jira] [Updated] (OFBIZ-7046) Non existent Bulk Item throwing errors while its respective qty get updated

2016-05-07 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-7046: - Attachment: OFBIZ-7046-14.12.patch > Non existent Bulk Item throwing errors while its respect

[jira] [Updated] (OFBIZ-7045) Non existent item when added as "Bulk Item" while creating purchase order is throwing null pointer exception

2016-05-07 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-7045: - Attachment: OFBIZ-7045-14.12.patch > Non existent item when added as "Bulk Item" w

[jira] [Updated] (OFBIZ-7046) Non existent Bulk Item throwing errors while its respective qty get updated

2016-05-07 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-7046: - Attachment: OFBIZ-7046-trunk.patch > Non existent Bulk Item throwing errors while its respect

[jira] [Updated] (OFBIZ-7045) Non existent item while added as "Bulk Item" throwing null pointer exception

2016-05-07 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-7045: - Attachment: OFBIZ-7045-trunk.patch > Non existent item while added as "Bulk Item"

[jira] [Commented] (OFBIZ-7046) Non existent Bulk Item throwing errors while its respective qty get updated

2016-05-06 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275098#comment-15275098 ] Devanshu Vyas commented on OFBIZ-7046: -- Thanks Swapnil for reporting the issue. I am working

[jira] [Commented] (OFBIZ-7045) Non existent item while added as "Bulk Item" throwing null pointer exception

2016-05-06 Thread Devanshu Vyas (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275097#comment-15275097 ] Devanshu Vyas commented on OFBIZ-7045: -- Thanks Swapnil for reporting the issue. I am working

<    1   2