Re: Issue with OFBiz Job Scheduler and Daylight Saving Time

2023-11-06 Thread Scott Gray
. > - Reporting jobs that runs on specific time > - Some business process, like order routing job etc. that should run on > specific time, > > Please correct me if I am missing something? > > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org >

Re: Issue with OFBiz Job Scheduler and Daylight Saving Time

2023-11-03 Thread Scott Gray
Hi Deepak, IMO the best general solution is to not run OFBiz or the database configured with a timezone that observes DST, instead use UTC or similar. This achieves the same result but without needing any extra fields. I'm not objecting to your solution, just sharing this tip out loud since the

Re: Are thruDates inclusive or exclusive?

2023-02-01 Thread Scott Gray
Hi Daniel, IMO the rule is defined by EntityDateFilterCondition#makeCondition(Timestamp, String, String) since this method is used throughout the framework to make date-based conditions. It builds the condition as "fromDate <= moment AND thruDate > moment", therefore rows where thruDate ==

Re: Possible issue in balanceInventoryItems/reassignInventoryReservation service

2022-07-12 Thread Scott Gray
, so this will not be an > ultimate solution to this, but we could make the e-commerce > managers/operators more aware of what is going on. > > What do you think about it? > > Thanks in advance, > Giulio > > > Il giorno ven 8 lug 2022 alle ore 17:34 Scott Gray < >

Re: Codenarc integration, rules to use.

2022-07-11 Thread Scott Gray
+1 in general from me although some of those rules might be challenging to resolve. For example DuplicateStringLiteral could be referring to an entity name being used in delegator queries more than once, I don't think we'd prefer to see that extracted to a constant. SpaceAroundMapEntryColon I'm

Re: Possible issue in balanceInventoryItems/reassignInventoryReservation service

2022-07-08 Thread Scott Gray
Hi Giulio, I think the hardcoded "N" is used there because a reservation is being deleted and then recreated. The assumption there is that if a reservation existed before the process, then it should also exist after the process and should not simply disappear because a physical inventory was

Re: New proposal on Jira to drop support for derby and use docker instead

2022-03-09 Thread Scott Gray
> > As for my first issue that I expect will end up as a derby constraint, > I'll start with my most recent issue that I run into regularly: > Before that, I should mention that I don't actually use derby so may be > blaming some things are derby that are undue, by misunderstanding some of > its

Re: [jira] [Commented] (OFBIZ-12489) Product Prices - VIEW permissions

2022-01-25 Thread Scott Gray
I just want to make it clear to anyone reading that actually yes, there has been discussion in the past about understanding the context of labels and that the same word in English can mean different things depending on that context. For this reason labels shouldn't be merged when they are used for

Re: [Conclusion] PartyRole usage in OFBiz

2021-11-19 Thread Scott Gray
(Removing the private list since the discussion has no place there) I don't think this topic needs any further debate at this stage. Pierre objects to having the tickets closed, so we can leave them open since that is the easiest path and doesn't really come at any cost. We don't need to

Re: Help required - calling Minilang Experts

2020-05-27 Thread Scott Gray
Hi Carsten, call-simple-method executes in the same manner as if you copied the code from the method being called directly into your code, i.e. it has the same variable scope as the method it's being called from. So the "custRequest" variable from checkStatusCustRequest was available to

Re: EntityBatchIterator for large data set queries

2020-05-27 Thread Scott Gray
Hi Pritam, I'm not sure about PostgreSQL or Derby but I know with MySQL that using a cursor doesn't really work. You have to set the result set to TYPE_FORWARD_ONLY and CONCUR_READ_ONLY and also set the fetch size to INTEGER.MIN_VALUE. Only then will the driver stream the results and even then,

Re: Default transaction timeout on screen widget

2019-10-01 Thread Scott Gray
. Regards Scott On Thu, 26 Sep 2019 at 00:46, Paul Foxworthy wrote: > On Tue, 17 Sep 2019 at 18:45, Scott Gray > wrote: > > > Has anyone ever had a good experience with transaction timeouts? I feel > > like they achieve nothing useful in that: > > 1. They don't interrupt

Re: Default transaction timeout on screen widget

2019-09-22 Thread Scott Gray
> > On 9/17/19 10:45 AM, Scott Gray wrote: > > Has anyone ever had a good experience with transaction timeouts? I feel > > like they achieve nothing useful in that: > > 1. They don't interrupt any work that is taking too long (they just > prevent > > i

Re: Default transaction timeout on screen widget

2019-09-17 Thread Scott Gray
Has anyone ever had a good experience with transaction timeouts? I feel like they achieve nothing useful in that: 1. They don't interrupt any work that is taking too long (they just prevent it from being committed) 2. By the time the exception is thrown, all the work is already done and the

Re: ReturnReason: Is this really required?

2019-09-05 Thread Scott Gray
gt; *Enterprise open source experts* > cell: 96697-50002 > http://www.hotwaxsystems.com > > > > > > > On Thu, Sep 5, 2019 at 12:40 AM Scott Gray > wrote: > > > Hi Suraj, > > > > It really depends on what the data will be used for. If you simply want > to &g

Re: ReturnReason: Is this really required?

2019-09-04 Thread Scott Gray
for example CancelReason. > > Please share your thoughts on this. > -- > Best Regards, > Suraj Khurana > Technical Consultant > *HotWax Systems* > *Enterprise open source experts* > cell: 96697-50002 > http://www.hotwaxsystems.com > > > > > > > On Fri, A

Re: ReturnReason: Is this really required?

2019-08-29 Thread Scott Gray
Hi Suraj, One good reason for custom enum/type tables is that it allows you to specify behaviors for the values. As a quick made-up example: I could add columns like "storeCredit", "exchange", "replace", "fullRefund" to the ReturnReason table and then set those flags to Y/N depending on the

Re: weird behavior in reply lately

2019-06-28 Thread Scott Gray
Yeah I don't see any need to vote or discuss going back to the behavior everyone was used to for the past decade and was changed by accident. Regards Scott On Sat, 29 Jun 2019, 00:49 Deepak Dixit, wrote: > I think we should ask infra to set it as it was. > I agree everybody was happy with it.

Re: weird behavior in reply lately

2019-06-28 Thread Scott Gray
Appears to me that it happened around the same time that Pierre asked infra to add unsubscribe footers to list emails. Was working late May, had stopped by 4th June. Regards Scott On Fri, 28 Jun 2019 at 21:51, Deepak Dixit wrote: > Hi Jacques, > > Here are the two reference link one of from

Re: weird behavior in reply lately

2019-06-28 Thread Scott Gray
I didn't mean any disrespect, my apologies Mathieu. My email was written out of frustration that something worked well for many years and suddenly changed for the worse (in my opinion). Regards Scott On Fri, 28 Jun 2019 at 20:13, Mathieu Lirzin wrote: > Scott Gray writes: > > >

Re: weird behavior in reply lately

2019-06-27 Thread Scott Gray
I just did it as well and it's super annoying. I don't ever want to directly reply to messages on our lists, at least without some manual effort on my part. Personally I couldn't care less about whether or not some idealists think setting reply-to is harmful. On Mon, 24 Jun 2019 at 04:10,

Re: Files w/o licenses

2019-06-03 Thread Scott Gray
I hope you'll name the reviewers that missed them as well :-) On Sun, 2 Jun 2019 at 07:33, Jacques Le Roux wrote: > OK, I'll do it in a week if nobody beats me on it. > > But I'll name those that should have done it before :p > > Jacques > > Le 28/05/2019 à 14:49, Jacques Le Roux a écrit : > >

Re: [PROPOSAL] DataModel - Improve entities using fromPartyId & toPartyId

2019-05-20 Thread Scott Gray
In my experience very few things in the business world are immutable. Dated *Role entities enhance flexibility and provide a decent audit trail for the inevitable changes that businesses need to support (I placed this order against the wrong customer, customer A has bought customer B so we need to

Re: Code Improvement for Groovy

2019-05-16 Thread Scott Gray
Hi Pawan Sounds good, just one point to be careful of: maxRetry = 0 if (!maxRetry) { // Not set, use a default maxRetry = -1 } Because groovy evaluates zero to be false, it wouldn't be possible to set maxRetry to zero. So it's best not to use groovy truth for null-checks on numbers in some

Re: ExternalId support in relevant entities

2019-05-02 Thread Scott Gray
I'd tend to agree with Pierre here, following the {entity}Identification pattern is probably a better approach long term simply because the externalId pattern breaks as soon as you need more than one identifier. If the likelihood of multiple IDs is low, then the {entity}Attribute pattern might be

Re: [PROPOSAL] DataModel - Improve Internal Fields injection

2019-04-26 Thread Scott Gray
Fwiw more often than not I can identify who made a specific change by searching the logs, assuming they're retained for long enough. Most http requests log the session ID (when the view is rendered) which can then be matched to a user via the Visit table. I'm not sure if that has changed in

Re: [DISCUSSION] JIRA notifications and reaching contributors

2019-04-25 Thread Scott Gray
The problem is that jira notification volume far exceeds dev list volume which has the effect of stifling dev list discussions due to them being pushed far down the list of recent emails. The only solution to that is to filter the jira notifications. Right now in gmail I can see one week's worth

Re: [OPTIONS] Java 11 and Java JDK origin

2019-04-16 Thread Scott Gray
gt;> release branch 21.x, meaning that we change to JDK 11 right before the > >> release branch will be created. This gives us plenty of time to test > >> with Java 11 and we can introduce Java 11 features in the trunk after > >> that. So release branch 22.x

Re: [OPTIONS] Java 11 and Java JDK origin

2019-04-14 Thread Scott Gray
With that being said, I don't have a firm opinion on upgrading and I just > wanted to highlight things, I leave it to other folks to decide. > > [1] https://www.oracle.com/technetwork/java/java-se-support-roadmap.html > > On Sun, Apr 14, 2019, 10:38 PM Scott Gray > wrote: > >

Re: [OPTIONS] Java 11 and Java JDK origin

2019-04-14 Thread Scott Gray
That would probably halt any further contributions from me in the short to medium term. Can I ask why we need to require 11 when 8 is supported through to 2023? Regards Scott On Sun, 14 Apr 2019, 23:37 Jacques Le Roux, wrote: > If nobody disagree, I'll make the last move (ie ask for Java 11

Re: svn commit: r1857084 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/FormRenderer.java

2019-04-07 Thread Scott Gray
You'll need to be careful with this one, based on the limited usage of the iterator here it seems likely that it will be used again later in the process. Regards Scott On Mon, 8 Apr 2019 at 07:38, wrote: > Author: mthl > Date: Sun Apr 7 19:38:09 2019 > New Revision: 1857084 > > URL:

Re: JobManager/JobPoller issues

2019-04-07 Thread Scott Gray
Job prioritization is committed in r1857071, thanks everyone who provided their thoughts. Regards Scott On Sat, 16 Mar 2019, 22:30 Scott Gray, wrote: > Patch available at https://issues.apache.org/jira/browse/OFBIZ-10865 > > Reviews welcome, I probably won't have time to commit it

Re: svn commit: r1855798 - /ofbiz/ofbiz-framework/trunk/build.gradle

2019-03-26 Thread Scott Gray
I think minor refactors (lots or few is irrelevant) shouldn't need a jira ticket and aren't worth mentioning in a blog post. Anything that requires discussion and/or changes the behavior of the application, the API or documentation should go through jira. Regards Scott On Thu, 21 Mar 2019 at

Re: svn commit: r1855403 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/ObjectType.java

2019-03-20 Thread Scott Gray
t; > > > > > - Best Regards, > > Swapnil M Mane, > > ofbiz.apache.org > > > > > > > > On Fri, Mar 15, 2019 at 5:36 AM Scott Gray > > > wrote: > > > >> Hi Swapnil, > >> > >> A minor thing, but I wonder if it would be better

Re: JobSandbox temporal expression timezone

2019-03-19 Thread Scott Gray
nvention Center, > Indore, > M.P 452010 > Linkedin: *Rishi Solanki* > <https://www.linkedin.com/in/rishi-solanki-62271b7/> > Direct: +91-9893287847 > > > On Tue, Mar 19, 2019 at 10:56 AM Scott Gray > wrote: > > > Hi all, > > > > Trying to decide

JobSandbox temporal expression timezone

2019-03-18 Thread Scott Gray
Hi all, Trying to decide on the best way to define a temporal expression for a recurring job where the temporal expression should be evaluated using a timezone other than whatever the default timezone is for the system. Use case is having a system that runs on UTC time, but needs to send a

Re: JobManager/JobPoller issues

2019-03-16 Thread Scott Gray
. They would have to be very slow jobs to not have the executor be idle most of the time. If no one objects I'd like to increase this to 2000 jobs with a 10 second poll time. Thanks Scott On Tue, 26 Feb 2019 at 09:13, Scott Gray wrote: > Hi Jacques, > > I'm working on implementing the prior

Re: svn commit: r1855403 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/ObjectType.java

2019-03-14 Thread Scott Gray
Hi Swapnil, A minor thing, but I wonder if it would be better to move this check underneath node.getTextContent()? If we assume that most nodes will contain text then it might be more efficient to do a null check after retrieving nodeValue. e.g. Node node = (Node) obj; String nodeValue =

Re: Create return till ...

2019-03-10 Thread Scott Gray
The ability to create a return doesn't necessarily mean that return will be accepted. IMO this is a business process where human intervention is required in order to maintain good customer relations. Approving/declining RMAs depend on a number of factors including: - the reason for return -

Re: JobManager/JobPoller issues

2019-02-25 Thread Scott Gray
OM detected we reanalyse the origin job and tried > to decompose it by persistent async service to help loading repartition. > > > > If I had more time, I would be oriented job improvement to : > > > > * Define an execution plan rule to link services and poller without >

Re: sendMail causes NPE (OFBIZ-10706)

2019-02-24 Thread Scott Gray
Hi Benjamin, I sent feedback when you asked for it back in December: https://ofbiz.markmail.org/thread/zgxbefdd2jn3otgk Regards Scott On Sat, 23 Feb 2019 at 05:11, Benjamin Jugl wrote: > Hello fellow developers, > > I just checked my open Jira-Issues and look, what I found: > > OFBIZ-10706

Re: JobManager/JobPoller issues

2019-02-04 Thread Scott Gray
it's not a drop-in > replacement though. It matches the signature of the call in the > executor service unless i'm missing something somewhere? > > [1] https://issues.apache.org/jira/browse/OFBIZ-10592 > > On Wed, Jan 30, 2019 at 10:59 PM Scott Gray > wrote: &

JobManager/JobPoller issues

2019-01-30 Thread Scott Gray
Hi folks, Just jotting down some issues with the JobManager over noticed over the last few days: 1. min-threads in serviceengine.xml is never exceeded unless the job count in the queue exceeds 5000 (or whatever is configured). Is this not obvious to anyone else? I don't think this was the

Re: OFBiz shell

2019-01-14 Thread Scott Gray
Hi Mathieu, https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Attic#OFBizAttic-GroovyShell might be of interest to you. Regards Scott On Sun, 13 Jan 2019, 07:14 Mathieu Lirzin Hello, > > One issue with the current way of writing Groovy tests is that the > feedback between writing an

Re: EmailServices.sendMail causes a NPE, when sendFrom is missing

2018-12-14 Thread Scott Gray
Hi Benjamin, If I were to place a bet, I would say that the system used to provide a default email address and that code has disappeared for some reason. It might pay to look at the history of the service and try to determine why it changed or if it was always broken. FWIW I always try and look

Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration

2018-11-25 Thread Scott Gray
One thing to consider, is it better to have a single table for configuring communication content generation or multiple? i.e. would it be better to have a single ProductStoreCommunicationSetting table instead of ProductStoreEmailSetting and ProductStoreSmsSetting (or whatever name has been

Re: Using alternate dispatcher and delegator for integration tests

2018-10-28 Thread Scott Gray
The use of separate individual dispatchers/delegators per test suite was introduced at the same time as the delegator rollback/reset code, and was intended to allow for test suites to be run (and data to be reset) in parallel. The test framework never sees much love though so that never happened.

Re: Upgrading the Authorize.net AIM API

2018-09-25 Thread Scott Gray
Maybe, but I see no reason to have an architecture discussion as a prerequisite for a simple API update. Regards Scott On Tue, 25 Sep 2018, 06:03 Jacques Le Roux, wrote: > I guess Pierre is referring to > https://markmail.org/message/zf5tz7qpgokldvtl and above... > > Jacques > > > Le

Re: ProductFacility creation on 'Receive Inventory'

2018-09-19 Thread Scott Gray
Sounds like there are 3 options available: 1. Improve any view/report screens to not rely on ProductFacility but instead report on what is actually in the warehouse via InventoryItem. 2. Require ProductFacility but silently create it when it is absent 3. Require ProductFacility and reject receipt

Re: HTTP Compression not working for some files (JS and CSS)

2018-08-20 Thread Scott Gray
See the note under the compression config here: https://tomcat.apache.org/tomcat-8.5-doc/config/http.html#Standard_Implementation Regards Scott On 20 August 2018 at 07:38, girish.vasmat...@hotwaxsystems.com < girish.vasmat...@hotwaxsystems.com> wrote: > > > On 2018/08/20 07:20:38, Michael

Re: OFBIZ-10307: Navigate from a domain to another with automated signed in authentication

2018-08-16 Thread Scott Gray
Hi Jacques, Assuming I was looking at the correct patch, it looks like I could use this feature to login as anyone. All I need to do is send any userLoginId to getJwtToken and then I can login as that user with the token that comes back. Am I missing something? Regards Scott On 15 August 2018

Re: svn commit: r1813640 - in /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity: GenericDelegator.java GenericEntity.java GenericPK.java GenericValue.java

2018-07-27 Thread Scott Gray
Thanks Michael! On Fri, 27 Jul 2018, 08:48 Michael Brohl, wrote: > Hi Scott, > > thanks for spotting this, I will fix it! > > Regards, > > Michael > > > Am 26.07.18 um 23:40 schrieb Scott Gray: > > FYI, I think this commit accidentally introduced a weird i

Re: ‘MapStack’ weirdness.

2018-07-26 Thread Scott Gray
ieu Lirzin wrote: > Hello Scott, > > Scott Gray writes: > > > I think it relates to the "context" variable that is frequently used in > > groovy data prep scripts for the script output. > > > > I'm not in front of a computer, but looking at it i

Re: svn commit: r1813640 - in /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity: GenericDelegator.java GenericEntity.java GenericPK.java GenericValue.java

2018-07-26 Thread Scott Gray
FYI, I think this commit accidentally introduced a weird import into GenericPK: import org.apache.sis.internal.jdk7.Objects probably intended to be java.util.Objects Regards Scott On 28 October 2017 at 15:19, wrote: > Author: mbrohl > Date: Sat Oct 28 15:19:56 2017 > New Revision: 1813640 > >

Re: ‘MapStack’ weirdness.

2018-07-19 Thread Scott Gray
I think it relates to the "context" variable that is frequently used in groovy data prep scripts for the script output. I'm not in front of a computer, but looking at it in that light may help. Regards Scott On Thu, 19 Jul 2018, 09:24 Taher Alkhateeb, wrote: > I didn't get into it before, but

Re: License issue with iText 4.2.0

2018-06-14 Thread Scott Gray
Are there any genuine doubts about 2.1.7? Or just a warning from the company trying to sell the AGL licensed versions? If we revert back to 2.1.7 then I don't think we need to ask legal anything. Regards Scott On 14 June 2018 at 18:56, Jacques Le Roux wrote: > Le 14/06/2018 à 07:22, Sc

Re: License issue with iText 4.2.0

2018-06-13 Thread Scott Gray
My first inclination is that taking legal advice from a company that is trying to sell you a license, probably isn't a good idea. They have a vested interest in trying to convince you not to use the MIT version. Regardless, I think Taher's solution works in the short term and the other

Re: License issue with iText 4.2.0

2018-06-08 Thread Scott Gray
com.itextpdf:itextpdf:5.5.6' > } > > On Fri, Jun 8, 2018, 11:40 AM Scott Gray > wrote: > > > Hey Jacques, > > > > Maybe I wasn't clear, OFBiz is downloading 5.5.6 as a dependency of > 4.2.0, > > does it make sense? > > > > Regards > > Scott

Re: License issue with iText 4.2.0

2018-06-08 Thread Scott Gray
cense > >> <https://en.wikipedia.org/wiki/Affero_General_Public_License> version > 3.>> > >> > >> MPL being OK as binary > >> > >> Jacques > >> > >> Le 08/06/2018 à 03:57, Scott Gray a écrit : > >>>

License issue with iText 4.2.0

2018-06-07 Thread Scott Gray
Hi All, I just noticed that the iText maven bundle is a bit tricksy and includes iText 5.6.6 as a dependency, with the latter being GPL licensed. You can see it by running "./gradlew -q dependencies": +--- com.lowagie:itext:4.2.0 |\--- com.itextpdf:itextpdf:5.5.6 I haven't checked to see if

Re: [Discussion] Introduction of Bootstrap and Vue.js

2018-05-15 Thread Scott Gray
bit more elaboration to get a better understanding of > your point of view since this seems to be a critical architectural > decision. > > > On Mon, May 14, 2018, 9:39 PM Scott Gray <scott.g...@hotwaxsystems.com> > wrote: > > > On Mon, 14 May 2018, 20:38 Taher Alk

Re: [Discussion] Introduction of Bootstrap and Vue.js

2018-05-14 Thread Scott Gray
On Mon, 14 May 2018, 20:38 Taher Alkhateeb, <slidingfilame...@gmail.com> wrote: > Hello Scott, thank you for your thoughts, inline ... > > On Mon, May 14, 2018 at 10:45 AM, Scott Gray > <scott.g...@hotwaxsystems.com> wrote: > > I think no matter what we use some

Re: [Discussion] Introduction of Bootstrap and Vue.js

2018-05-14 Thread Scott Gray
I think no matter what we use someone will always want something different. I'm beginning to lose count of the number of custom APIs I've written over the years to support custom UIs. I think the bigger win would be to start providing APIs and rewriting our existing screens to use them. From

Re: [Proposal] Make accounting entry configurable

2018-05-07 Thread Scott Gray
Another additional option we could consider at some point is to extract the GL out to it's own component. It would simplify evaluation for people who do want to use it, and removal for that don't or replacement for anyone who wants to use something else. Regards Scott On Thu, 3 May 2018, 18:12

Re: svn commit: r1830236 - /ofbiz/ofbiz-framework/trunk/framework/webtools/widget/ServiceForms.xml

2018-05-01 Thread Scott Gray
crashed job mechanism, i'll revert this > > commit. > > > > Regards, > > > > Gil > > > > > > Le jeudi 26 avril 2018 à 19:33:48 (+), Scott Gray a écrit : > >> Hi Gil, > >> > >> Maybe I'm missing something but crashe

Re: svn commit: r1830236 - /ofbiz/ofbiz-framework/trunk/framework/webtools/widget/ServiceForms.xml

2018-04-26 Thread Scott Gray
Hi Gil, Maybe I'm missing something but crashed jobs are reset at the same time that they're marked as crashed (during startup). I don't have the latest code in front of me but it used to be in JobManager.reloadCrashedJobs(). Basically when an instance restarts, any jobs marked as running are

Re: Confusing entity names

2018-04-18 Thread Scott Gray
Just to throw in my 2 cents, I don't think the naming is so confusing that it warrants changing. The number of replies in this thread highlights that it isn't a straightforward thing to change, and personally I don't think the names are so bad that it's worth any of the pain that might come from

Re: Check for only QOH while doing reservations

2018-04-06 Thread Scott Gray
Hi Suraj, I haven't reviewed the code in question so I don't have any comment at this stage. But one thing I want to point out is that OFBiz has many years of history available in commit logs, jira and mailing lists. It's often quite a simple task to look back over that history and determine why

Re: Deprecate properties in favour of SystemProperties

2018-04-05 Thread Scott Gray
ystem properties. Of course then renaming > the > > SystemProperty entity to BusinessProperty is necessary. Having a specific > > UI for DB access for these properties is also necessary. I foresee the > > webtools as the best place for this UI. It should be accessible by > t

Re: Deprecate properties in favour of SystemProperties

2018-04-04 Thread Scott Gray
If there's an ongoing discussion on the dev list then I don't think it's a good idea to try to move it to jira until there's some consensus on the path forward. Regards Scott On 4 April 2018 at 10:14, Taher Alkhateeb wrote: > I am a little lost in this JIRA and

Re: why some fields are set to enable-audit-log true by default?

2018-04-04 Thread Scott Gray
It would be good to leave it on somewhere in the system like the example entities maybe On Wed, 4 Apr 2018, 22:13 Jacques Le Roux, wrote: > Le 04/04/2018 à 12:07, Taher Alkhateeb a écrit : > > I'm not sure about the field in the entity component though! it > >

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-26 Thread Scott Gray
Yeah, I said exactly that elsewhere in the same email. Regards Scott On 26 March 2018 at 21:17, Jacques Le Roux <jacques.le.r...@les7arts.com> wrote: > Le 24/03/2018 à 18:49, Scott Gray a écrit : > >> I'm also not even sure if our custom ObjectType methods for checking thi

Fwd: [jira] [Commented] (OFBIZ-6882) Extend the PostalAddress entity with additional elements

2018-03-25 Thread Scott Gray
in the dev mailing list. It's also absolutely critical that issues raised in review are discussed rather than ignored, nothing should ever be committed when the only reviews are doubtful ones. Regards Scott -- Forwarded message -- From: Scott Gray (JIRA) <j...@apache.org> Da

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-24 Thread Scott Gray
there. e.g. UtilValidate.isHttpServletRequest(Object request) { // do the new test here } In the service definition: That would solve the problem for now until the service engine is improved and tested or the tomcat SSO login design is improved. Regards Scott On 24 March 2018 at 17:49,

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-24 Thread Scott Gray
ote: > Le 23/03/2018 à 17:09, Scott Gray a écrit : > >> I don't need to try anything, I *know* that the service engine is supposed >> to accept a concrete class of an interface if the interface is specified >> as >> the attribute type. >> >> Eit

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-23 Thread Scott Gray
> > > > Le 23/03/2018 à 03:39, Scott Gray a écrit : > >> Something else must be wrong Jacques, I can't understand what you're >> saying >> in the ticket description or in your reply above but I do know the >> following: >> OFBiz is perfectly capable o

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-22 Thread Scott Gray
Something else must be wrong Jacques, I can't understand what you're saying in the ticket description or in your reply above but I do know the following: OFBiz is perfectly capable of knowing that org.apache.catalina.connector.RequestFacade implements the javax.servlet.http.HttpServletRequest and

Re: Demo Trunk Break

2018-03-16 Thread Scott Gray
te: > I'm sorry, this is a temporary poor man solution. I have no other domain > available. > > Jacques > > > Le 16/03/2018 à 03:08, Scott Gray a écrit : > >> I guess what Michael is getting at, is that the demo server is for demos, >> it's not intended for use as a development

Re: Demo Trunk Break

2018-03-15 Thread Scott Gray
I guess what Michael is getting at, is that the demo server is for demos, it's not intended for use as a development sandbox. As far as I can tell you don't *need* to be using the demo servers for this, it's just convenient for you. But the problem is, if you're modifying the code on the demos

Re: tenant handling in XMLRPC

2018-03-15 Thread Scott Gray
t;); > +delegator = (Delegator) request.getAttribute("delegator"); > if (report != null) { > BufferedReader reader = null; > StringBuilder buf = new StringBuilder(); > try { > // read the inputstream buffe

Re: tenant handling in XMLRPC

2018-03-15 Thread Scott Gray
Hi Rajesh, It looks like the XmlRpcEventHandler class doesn't support this but it could easily be modified to do so. I'd suggest filing a ticket, and perhaps even providing a patch :-) The tenantId just needs to be derived from the url and then passed into the userLogin service in the

Re: buildbot failure in on ofbizTrunkFramework

2018-03-13 Thread Scott Gray
It's easy to just search the log output for "JUNIT (failure)", which reports this test failed: 2018-03-13 13:18:52,725 |main |TestRunContainer |W| [JUNIT (failure)] - auto-accounting-transaction-tests-purchase.testAcctgTransOnPaymentSentToSupplier : Assertion failed:

Re: svn commit: r1825436 - /ofbiz/ofbiz-framework/trunk/framework/security/ofbiz-component.xml

2018-02-28 Thread Scott Gray
n for the crash is actually the order of > writing the readers in the command line. There are still some issues > in other areas of loading, so I need to study it a bit further. > > On Thu, Mar 1, 2018 at 12:46 AM, Scott Gray > <scott.g...@hotwaxsystems.com> wrote: > > H

Re: svn commit: r1825436 - /ofbiz/ofbiz-framework/trunk/framework/security/ofbiz-component.xml

2018-02-28 Thread Scott Gray
Hi Taher, I'm not sure I understand or if something has changed in the last few years but seed-initial should always expect to be loaded after seed data so it shouldn't be a problem for seed-initial to depend on seed data. You would never just load seed-initial into an empty database. Regards

Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

2018-02-19 Thread Scott Gray
Jacques, as a first step, please consider not using "no functional change" any longer. It used to be that it was simply used for basic formatting fixes, but now that I look closer, I notice you've had a trend going for a while now that you're using it for anything you consider to be minor.

Re: svn commit: r1823562 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/ExternalLoginKeysManager.java

2018-02-09 Thread Scott Gray
Every code change is at a minimum an improvement. Our other tags are just more specific improvements e.g. a fix is an improvement to something that was previously broken. Regards Scott On 9/02/2018 06:19, "Jacques Le Roux" wrote: > I use completed for these cases

Re: [Proposal] OR search criteria within performFind

2018-02-07 Thread Scott Gray
A little bit off topic but I recently wrote an EntityCondition converter for use with the rsql-parser[1] library. Using it on an html client to write free-form queries would need some javascript wizardry but it's worth looking at if we ever wanted to implement something like Jira's JQL

Re: Permission overrides auth parameter of service

2018-01-23 Thread Scott Gray
ts and do checks for the permissions then it must > >>> have the auth set as true. If any occurrences found then it should be > by > >>> mistake and service definition should be fix to match. > >>> > >>> So I think the behavior we have is correc

Re: [DISCUSSION] Disentanglement of the ExampleExt component

2018-01-08 Thread Scott Gray
rk, e.g.: > > 1) entity-core-api.jar + entity-core-impl.jar: entity engine available to > > legacy applications (built from scratch) > > 2) service-core-api.jar + service-core-impl.jar: service engine available > > to legacy applications (built from scratch) > > 3)

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-08 Thread Scott Gray
The argument was that the configs weren't being used by default, so the same would, in theory, apply to those files. Regards Scott On 9/01/2018 5:14 AM, "Jacques Le Roux" <jacques.le.r...@les7arts.com> wrote: Le 08/01/2018 à 01:36, Scott Gray a écrit : > The same goe

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-07 Thread Scott Gray
I'm in favor of the status quo. It's useful to have them available out of the box to be able to pick the one you need and proceed without having to look elsewhere. The same goes for the fieldtype definitions. Regards Scott On 8/01/2018 6:26 AM, "Pierre Smits" wrote: We

Re: [DISCUSSION] Disentanglement of the ExampleExt component

2018-01-07 Thread Scott Gray
I'm not familiar with commonext or exampleext, but the purpose of the entity-ext component was to allow the entity engine to exist without the service engine. That's why all the entity-related logic that relies on the service engine is implemented there (EECAs, EntitySync, DCC). The alternative

Re: [OFBIZ] - Job schedules and Multi instance

2018-01-02 Thread Scott Gray
You can treat each instance as a separate pool in serviceengine.xml, so that instance A sends jobs and runs jobs from poolA and instance B uses poolB. Regards Scott On 3/01/2018 03:04, "Nicolas Malin" wrote: When a job is created by an instance, there are no

Re: Permission overrides auth parameter of service

2017-11-29 Thread Scott Gray
auth="false" and a permission service are completely incompatible scenarios. In what situation could you possibly have no userLogin and successfully run a permission service? What would you expect to happen instead of the current behavior? Regards Scott On 3 November 2017 at 17:35, Suraj

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Scott Gray
I agree with Paul that FinAccountTrans shouldn't reference orderId or returnId. I have nothing to add, his reasoning is spot on. Regards Scott On 21 November 2017 at 16:56, Paul Foxworthy wrote: > Hi Vaibhav, > > I'm really uncomfortable about this. > > As Pierre said,

Re: Service returning incorrect records

2017-11-15 Thread Scott Gray
I'm in favor of removing, it's been there since at least 2003 and is most likely from a legacy search screen that has since been superseded. Regards Scott On 15 November 2017 at 21:14, Suraj Khurana wrote: > Thanks, Jacques and Michael for your inputs, > > I

Re: Unable to Launch 16.11.x in Isolation

2017-11-14 Thread Scott Gray
Yeah I learned this one the hard way after boarding a 12 hour flight. Fortunately I had a few old copies of OFBiz lying around from back in the good old days. Regards Scott On 15 November 2017 at 05:15, Michael Brohl wrote: > Reminder to self: update the (great)

Re: Updates to EntityQuery

2017-10-25 Thread Scott Gray
I think it's better to have for-update available for use for the majority of use-cases than it is to exclude it altogether. I'd rather lose the databases that don't support it than constrain the ones that do and are used most by pretty much everyone. It would be nice to hear from anyone using a

Re: svn commit: r1811699 - /ofbiz/ofbiz-framework/trunk/framework/service/src/main/java/org/apache/ofb iz/service/config/model/ThreadPool.java

2017-10-12 Thread Scott Gray
Honestly I think the topic is generic enough that OFBiz doesn't need to provide any information at all. Thread pool sizing is not exclusive to OFBiz and it would be strange for anyone to modify the numbers without first researching sources that provide far more detail than a few sentences in our

Re: All roleType entities should maintain lifespan

2017-09-29 Thread Scott Gray
Hi Suraj, I still haven't seen an example of a useful use case for adding from/thruDate fields to the PartyRole table. Did you have anything in mind that it might help with? I'd honestly prefer to remove it rather than expand it. Regards Scott On 29 September 2017 at 20:41, Suraj Khurana <

  1   2   3   4   5   6   7   8   9   10   >