Re: Javascript clean up and improvements

Thanks Amardeep! Best regards, Pranay Pandey HotWax Systems http://www.hotwaxsystems.com/ On Sat, Jul 2, 2016 at 8:51 PM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Here is the parent ticket for this effort - > https://issues.apache.org/jira/browse/OFBIZ-1319. > > Thanks

Re: Javascript clean up and improvements

Here is the parent ticket for this effort - https://issues.apache.org/jira/browse/OFBIZ-1319. Thanks & Regards, -- Amardeep Singh Jhajj www.hotwaxsystems.com On Wed, Jun 29, 2016 at 5:44 PM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > I agree with you Pierre. I am working

Re: Javascript clean up and improvements

I agree with you Pierre. I am working on planning of this work and will break work logically for different components to keep it very simple. I will share ticket here. Thanks & Regards, -- Amardeep Singh Jhajj www.hotwaxsystems.com On Wed, Jun 29, 2016 at 5:21 PM, Pierre Smits

Re: Javascript clean up and improvements

The suggestion sound very reasonable and actionable, so: +1 I suggest a JIRA issue is opened for this that references this thread, accompanied by the necessary sub-tasks (if any, and to be able to keep the patch files(s) as concise as possible per component [1]) regarding depending aspects (e.g.

Re: Javascript clean up and improvements

+1 On Wed, Jun 29, 2016 at 1:10 PM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Thanks all for approval. I will start work on it. > > Regards, > -- > Amardeep Singh Jhajj > www.hotwaxsystems.com > > On Tue, Jun 28, 2016 at 11:51 AM, Jacques Le Roux < >

Re: Javascript clean up and improvements

Thanks all for approval. I will start work on it. Regards, -- Amardeep Singh Jhajj www.hotwaxsystems.com On Tue, Jun 28, 2016 at 11:51 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Fair enough, +1 > > Jacques > > > > Le 28/06/2016 à 07:59, Taher Alkhateeb a écrit : > >> +1 on

Re: Javascript clean up and improvements

Fair enough, +1 Jacques Le 28/06/2016 à 07:59, Taher Alkhateeb a écrit : +1 on approach On Jun 28, 2016 8:53 AM, "Pranay Pandey" wrote: +1 Amardeep, mentioned approach is looking reasonable to me. Best regards, Pranay Pandey HotWax Systems

Re: Javascript clean up and improvements

+1 Amardeep, approach looks good to me. Thanks and Regards -- Akash Jain On Tue, Jun 28, 2016 at 11:21 AM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Hello Jacques, > > Making branch is a good idea to handle regressions but I would prefer to > work in trunk itself. Here

Re: Javascript clean up and improvements

After merging the separate branch we may have regression, picking one item do regression testing over trunk will minimize the regression. +1 Amardeep, good way to go. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847

Re: Javascript clean up and improvements

+1 on approach On Jun 28, 2016 8:53 AM, "Pranay Pandey" wrote: > +1 Amardeep, mentioned approach is looking reasonable to me. > > Best regards, > > Pranay Pandey > HotWax Systems > http://www.hotwaxsystems.com/ > > On Tue, Jun 28, 2016 at 11:21 AM, Amardeep Singh

Re: Javascript clean up and improvements

+1 Amardeep, mentioned approach is looking reasonable to me. Best regards, Pranay Pandey HotWax Systems http://www.hotwaxsystems.com/ On Tue, Jun 28, 2016 at 11:21 AM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Hello Jacques, > > Making branch is a good idea to handle

Re: Javascript clean up and improvements

Hello Jacques, Making branch is a good idea to handle regressions but I would prefer to work in trunk itself. Here are the things we should consider before creating new branch: 1. Branch can be abandoned, I would prefer to have code changes in trunk in proper steps instead of merging the

Re: Javascript clean up and improvements

Hi Amardeep, What I mean is we should be cautious. Hence the suggestion to create a branch for the refactoring. And to benefit from this opportunity to put some Selenium tests related with js (eg: calendar - could also use HTML5 now -, autocompletion, lookups, dependent dropdowns). That would

Re: Javascript clean up and improvements

Thanks all for approval. Thanks Taher and Deepak for valuable suggestions. I will think on them. Jacques, I am bit confused by your reply, could you please elaborate your point. Regards, -- Amardeep Singh Jhajj On Fri, Jun 24, 2016 at 4:17 PM, Jacques Le Roux < jacques.le.r...@les7arts.com>

Re: Javascript clean up and improvements

Amardeep, I agree with your points, I'd just request that we do that in a branch with a load of UI tests (good occasion to use Selenium). Our js code is complex and fragile, I think notably at the global variables in fieldlookup.js and selectall.js which are maybe hard to avoid. IMO those

Re: Javascript clean up and improvements

Very good idea Amardeep. Big +1. -- Kind Regards Ashish Vijaywargiya HotWax Systems - est. 1997 https://www.linkedin.com/in/ashishvijaywargiya1 On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Hello everyone, > > Currently, OFBiz javascript

Re: Javascript clean up and improvements

+1. Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Fri, Jun 24, 2016 at 2:13 PM, Divesh Dutta < divesh.du...@hotwaxsystems.com> wrote: > +1 Amardeep. > > > Thanks > -- > Divesh Dutta. > > On Fri, Jun 24,

Re: Javascript clean up and improvements

+1 Amardeep. Thanks -- Divesh Dutta. On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Hello everyone, > > Currently, OFBiz javascript code (except third party libraries) is not > written with the best practices which can cause following

Re: Javascript clean up and improvements

Hi Amardeep, I agree with you current js code is not written as per the best practice. Here are some inputs from my side. Please see comments inline: On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Hello everyone, > > Currently, OFBiz

Re: Javascript clean up and improvements

+1 for the recommendation Amardeep. Best regards, Pranay Pandey HotWax Systems http://www.hotwaxsystems.com/ On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Hello everyone, > > Currently, OFBiz javascript code (except third party libraries)

Re: Javascript clean up and improvements

and +1 for your recommendations On Friday, 24 June 2016, Amardeep Singh Jhajj < amardeep.jh...@hotwaxsystems.com> wrote: > Hello everyone, > > Currently, OFBiz javascript code (except third party libraries) is not > written with the best practices which can cause following problems - > > 1.

Re: Javascript clean up and improvements

Hi Amardeep, In my opinion, the absolute best thing you can do for JavaScript is to run it through jslint. If you are serious about the work, I would suggest you take all the JavaScript files and snippets inside FTL files and run them inside jslint and fix the issues one by one. That would

Javascript clean up and improvements

Hello everyone, Currently, OFBiz javascript code (except third party libraries) is not written with the best practices which can cause following problems - 1. Increases the code maintenance effort. 2. Impact page performance. 3. Present not good examples to new contributors which leads to C/P to