Re: Github PR template

2020-05-31 Thread Suraj Khurana
Thanks Jacques. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, May 31, 2020 at 1:21 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Done also in R17 and R18, it can still be improved if necessary > > I removed a

Re: Github PR template

2020-05-31 Thread Jacques Le Roux
Done also in R17 and R18, it can still be improved if necessary I removed a "ecomify-OFBIZ-11468_Convert_ShipmentReceiptServices-squashed" branch that I pushed by mistake in ofbiz-framework.git Jacques Le 31/05/2020 à 05:55, Aditya Sharma a écrit : +1 Thanks and Regards, Aditya Sharma On

Re: Github PR template

2020-05-30 Thread Aditya Sharma
+1 Thanks and Regards, Aditya Sharma On Sat, May 30, 2020 at 10:43 PM Suraj Khurana wrote: > Hello team, > > IMO, we should imply these changes to plugins repository as well. > > -- > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Sat, May 30, 2020 at 1:29 PM Suraj

Re: Github PR template

2020-05-30 Thread Suraj Khurana
Hello team, IMO, we should imply these changes to plugins repository as well. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 30, 2020 at 1:29 PM Suraj Khurana wrote: > This is awesome. > > Thanks everyone involved in this effort. > > -- > > Best Regards, > Suraj

Re: Github PR template

2020-05-30 Thread Suraj Khurana
This is awesome. Thanks everyone involved in this effort. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 28/05/2020 à 07:45, Aditya Sharma a écrit : > > I think this might not be a

Re: Github PR template

2020-05-28 Thread Jacques Le Roux
Le 28/05/2020 à 07:45, Aditya Sharma a écrit : I think this might not be a problem until you got to change it;) Thanks Aditya, Actually I simply forgot to commit from my Linux VM :) https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0

Re: Github PR template

2020-05-27 Thread Aditya Sharma
Thanks Jacques! It works I tried creating a PR by comparing trunk to my fork branches and content from template show up. >> I don't think it's a problem, since it's only related to GH, but I don't see .github in Windows. I think this might not be a problem until you got to change it ;) Thanks

Re: Github PR template

2020-05-27 Thread Jacques Le Roux
Note (also added as a comment in OFBIZ-11722): As the Github PR template is not related to OFBiz I followed this GH advice: To store your file in a hidden directory, name the pull request template .github/pull_request_template.md. I don't think it's a problem, since it's only related to

Re: Github PR template

2020-05-27 Thread Jacques Le Roux
Done, please review and amend if necessary Le 22/05/2020 à 12:45, Jacques Le Roux a écrit : I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that Jacques Le 13/05/2020 à 12:13, Jacques Le Roux a écrit : Hi Deepak, Agreed, we had this discussion earlier:

Re: Github PR template

2020-05-22 Thread Jacques Le Roux
I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that Jacques Le 13/05/2020 à 12:13, Jacques Le Roux a écrit : Hi Deepak, Agreed, we had this discussion earlier: https://markmail.org/message/3l6dwx4vkknmovew We just miss a sub-task under

Re: Github PR template

2020-05-13 Thread Jacques Le Roux
Hi Deepak, Agreed, we had this discussion earlier: https://markmail.org/message/3l6dwx4vkknmovew We just miss a sub-task under https://issues.apache.org/jira/browse/OFBIZ-11268 HTH Jacques Le 13/05/2020 à 12:06, Pierre Smits a écrit : +1. And our current contributor pages in the wiki

Re: Github PR template

2020-05-13 Thread Pierre Smits
+1. And our current contributor pages in the wiki should be updated accordingly. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion , Vice President* *Apache