Re: Modify OFBiz commit message template

2020-05-23 Thread Mridul Pathak
+1 Thanks. -- Mridul Pathak > On 20-May-2020, at 2:31 PM, Jacques Le Roux > wrote: > > Hi, > > With Git IMO it's convenient (more information) to have the Jira number in > the title, eg: https://markmail.org/message/cyslglyoh5gf7l7t > > If nobody disagree I'd like to modify > >

Re: Modify OFBiz commit message template

2020-05-22 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 20, 2020 at 2:33 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > With Git IMO it's convenient (more information) to have the Jira number in > the title, eg:

Re: Modify OFBiz commit message template

2020-05-22 Thread Jacques Le Roux
I created https://issues.apache.org/jira/browse/OFBIZ-11298 for that Le 22/05/2020 à 08:58, Jacques Le Roux a écrit : Thanks All, I'll do that in 5 days, simple, efficient in Git. Jacques Le 20/05/2020 à 16:43, James Yong a écrit : +1 to [Implemented | Improved | Fixed | Completed|

Re: Modify OFBiz commit message template

2020-05-22 Thread Jacques Le Roux
See the thread Le 22/05/2020 à 11:01, Pierre Smits a écrit : I meant this one: https://ofbiz.markmail.org/message/zllitqewumbefwd2?q=Github+PR+request+list:org%2Eapache%2Eofbiz%2Edev+order:date-backward=1 Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz

Re: Modify OFBiz commit message template

2020-05-22 Thread Pierre Smits
I meant this one: https://ofbiz.markmail.org/message/zllitqewumbefwd2?q=Github+PR+request+list:org%2Eapache%2Eofbiz%2Edev+order:date-backward=1 Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache

Re: Modify OFBiz commit message template

2020-05-22 Thread Jacques Le Roux
You mean the sonarcloud[bot]  thread? Le 22/05/2020 à 09:34, Pierre Smits a écrit : A few days ago a thread was also started regarding the PR. Is that now void? Or will it be handled in the same breath? Op vr 22 mei 2020 09:08 schreef Jacques Le Roux < jacques.le.r...@les7arts.com>: Thanks

Re: Modify OFBiz commit message template

2020-05-22 Thread Pierre Smits
A few days ago a thread was also started regarding the PR. Is that now void? Or will it be handled in the same breath? Op vr 22 mei 2020 09:08 schreef Jacques Le Roux < jacques.le.r...@les7arts.com>: > Thanks All, > > I'll do that in 5 days, simple, efficient in Git. > > Jacques > > Le

Re: Modify OFBiz commit message template

2020-05-22 Thread Jacques Le Roux
Thanks All, I'll do that in 5 days, simple, efficient in Git. Jacques Le 20/05/2020 à 16:43, James Yong a écrit : +1 to [Implemented | Improved | Fixed | Completed| Documented | Reverted]: [Jira title | Free text] [(OFBIZ-)] [More detailed explanation of what has been done and

Re: Modify OFBiz commit message template

2020-05-20 Thread James Yong
+1 to [Implemented | Improved | Fixed | Completed| Documented | Reverted]: [Jira title | Free text] [(OFBIZ-)] [More detailed explanation of what has been done and what the fix achieves, sideeffects etc.] [Thanks:] [ for ... and for] Regards, James On 2020/05/20

Re: Modify OFBiz commit message template

2020-05-20 Thread Benjamin Jugl
Hello everyone, Am 20.05.20 um 11:36 schrieb Pierre Smits: The subject can be quite lengthy (as I have experienced a few times when doing PRs). I suggest to moving the ticket Id to the front of the first line. Also, whatever the categorisation is ([Implemented | Improved | Fixed | Completed|

Re: Modify OFBiz commit message template

2020-05-20 Thread Pierre Smits
Can GitHub be configured that when a ticket Id is present it is shown as a link to the ticket in Jira. IIRC I have seen it happening. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion

Re: Modify OFBiz commit message template

2020-05-20 Thread Pierre Smits
The subject can be quite lengthy (as I have experienced a few times when doing PRs). I suggest to moving the ticket Id to the front of the first line. Also, whatever the categorisation is ([Implemented | Improved | Fixed | Completed| Documented | Reverted]: this should be referenced (at least) in