Re: svn commit: r1594758 - /ofbiz/trunk/.gitignore

2014-05-18 Thread Jacques Le Roux
-hot-deploy/*/build +hot-deploy/* +!hot-deploy/README.txt This change does not make sense. It will force people who use Git to search why their added component/s are ignored, I will revert it! I add 2 other changes I have pending for months: runtime/indexes/products/ So I agree with this

[jira] [Created] (OFBIZ-5648) Extend primary keys

2014-05-18 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-5648: -- Summary: Extend primary keys Key: OFBIZ-5648 URL: https://issues.apache.org/jira/browse/OFBIZ-5648 Project: OFBiz Issue Type: Bug Components:

Re: Duplicate webapp loads by birt component

2014-05-18 Thread Jacques Le Roux
Jacopo introduced a change to be able to move the Birt component from framework to specialpupose So yes it's an intended change but I see no problems with it using trunk. Those are loaded and used for Birt reports which are in those components Jacques Le 15/05/2014 18:18, c.schin...@gmail.com

[jira] [Updated] (OFBIZ-5648) Extend primary keys

2014-05-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5648: --- Attachment: test.entity-extend.patch ModelEntity.java.patch Extend primary

Re: Adding agreementId to OrderHeader

2014-05-18 Thread Jacques Le Roux
I don't think so Jacques Le 09/05/2014 11:57, Pierre Smits a écrit : Is there a JIRA issue for this? Regards, Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail Trade http://www.orrtiz.com On Fri, Jul 9,

Re: Duplicate webapp loads by birt component

2014-05-18 Thread Carsten Schinzer
Thanks for the info, I comfirm it is harmless. Just wanted to be sure. Regards Carsten 2014-05-18 14:27 GMT+02:00 Jacques Le Roux jacques.le.r...@les7arts.com: Jacopo introduced a change to be able to move the Birt component from framework to specialpupose So yes it's an intended change but

Re: Duplicate webapp loads by birt component

2014-05-18 Thread Jacques Le Roux
Just spotted the lines [java] 2014-05-18 20:55:57,869 (main) [ CatalinaContainer.java:567:INFO ] createContext(ar) [java] 2014-05-18 20:55:57,869 (main) [ CatalinaContainer.java:770:INFO ] Duplicate webapp mount; not loading : accounting /

[jira] [Commented] (OFBIZ-5648) Extend primary keys

2014-05-18 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001168#comment-14001168 ] Adrian Crum commented on OFBIZ-5648: I would oppose this change. Changing the pk might

[jira] [Commented] (OFBIZ-5648) Extend primary keys

2014-05-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001179#comment-14001179 ] Jacques Le Roux commented on OFBIZ-5648: Yes did not thought about adding, only

[jira] [Commented] (OFBIZ-5648) Extend primary keys

2014-05-18 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001285#comment-14001285 ] Adrian Crum commented on OFBIZ-5648: You can change the pk by redefining the entity.

Re: svn commit: r1594758 - /ofbiz/trunk/.gitignore

2014-05-18 Thread Hans Bakker
With a proper installation, hot-deploy components will come from a different git repository and should not be stored together in order to be able to keep your ofbiz installation in sync with the ofbiz svn repository. If they are not ignored, and you install ofbiz and later the components in

Re: svn commit: r1594758 - /ofbiz/trunk/.gitignore

2014-05-18 Thread Adam Heath
I'm the one who originally added this file. Hans, you're wrong. Not everyone does git integration work the same way. Some might use symlinks in hot-deploy, linked to locations outside of the ofbiz tree. In those cases, the symlinks should be maintained in the parent repo. Other methods

Re: svn commit: r1594758 - /ofbiz/trunk/.gitignore

2014-05-18 Thread Hans Bakker
Adam, i looked at sub modules and git-tree, they are adding even more complexity to the already complex GIT and sorry i do not see the advantage. Loading the components into hot-deploy from a separate git repository is working well here, however one need to ignore the hot-deploy content

buildbot failure in ASF Buildbot on ofbiz-trunk

2014-05-18 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/15 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: portunus_ubuntu Build Reason: scheduler Build Source

Re: svn commit: r1594758 - /ofbiz/trunk/.gitignore

2014-05-18 Thread Adam Heath
Just because you don't see the need, doesn't mean it it should be actively discourage. Adding that wildcard commit to trunk will discourage these other tools. On 05/18/2014 10:10 PM, Hans Bakker wrote: Adam, i looked at sub modules and git-tree, they are adding even more complexity to the