Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-28 Thread Ross Laidlaw
Hi Lewis, Sounds like a smart plan to do things step by step. I'll start experimenting with java.util.Properties and see if I can get a patch together for one of the test packages in file manager. Ross On 26 July 2014 10:37, Lewis John Mcgibbney lewis.mcgibb...@gmail.com wrote: Ross, Can

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-26 Thread Lewis John Mcgibbney
Ross, Can you PLEASE make public any changes you have to filemgr? If we can get a test-by-test patch-fix then we are #winning. BTW I also have another local branch with various fixes. We also SHOULD NOT post calls to System.setProperties, as it makes it ultimately more difficult to debug when we

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-25 Thread Rishi Verma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23870/#review48750 --- Hi Ross, So for example, for

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-25 Thread Ross Laidlaw
On July 25, 2014, 3:16 p.m., Rishi Verma wrote: I call this a success: BEFORE PATCH: Tests run: 190, Failures: 54, Errors: 13, Skipped: 0 AFTER PATCH: Tests run: 190, Failures: 1, Errors: 1, Skipped: 0 The single error and failure is listed below: === Failed tests:

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-25 Thread Rishi Verma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23870/#review48735 --- I call this a success: BEFORE PATCH: Tests run: 190, Failures: 54,

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Lewis McGibbney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23870/#review48678 --- Ultimately committed @revision 1613264 in trunk via

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Tyler Palsulich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23870/#review48675 --- No joy for me. svn co, patch, mvn install led to: ... Tests run:

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Ross Laidlaw
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23870/ --- (Updated July 23, 2014, 11:33 p.m.) Review request for oodt, Lewis McGibbney,

Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Ross Laidlaw
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23870/ --- Review request for oodt, Lewis McGibbney, Chris Mattmann, and Paul Ramirez.

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Ross Laidlaw
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23870/ --- (Updated July 23, 2014, 11:31 p.m.) Review request for oodt, Lewis McGibbney,

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Lewis McGibbney
On July 23, 2014, 11:50 p.m., Lewis McGibbney wrote: Checked out fresh copy of trunk, applied patch mvn install Results : Failed tests: testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer): There aren't exactly 4 elements in the test samples!

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Lewis McGibbney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23870/#review48576 --- Checked out fresh copy of trunk, applied patch mvn install Results