Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-12-10 Thread Ben Pfaff
# Mark 691508 as fixed upstream. tags 691508 + fixed-upstream thanks On Fri, Dec 07, 2012 at 10:05:50PM +, Kyle Mestery (kmestery) wrote: On Dec 4, 2012, at 2:51 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Oct 29, 2012 at 09:34:37AM -0700, Ben Pfaff wrote: Until now, a command like

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-12-07 Thread Kyle Mestery (kmestery)
On Dec 4, 2012, at 2:51 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Oct 29, 2012 at 09:34:37AM -0700, Ben Pfaff wrote: Until now, a command like ovs-vsctl --may-exist add-br br0 yielded a confusing error message. Users had to realize that the correct form was ovs-vsctl -- --may-exist add-br

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-12-04 Thread Ben Pfaff
On Mon, Oct 29, 2012 at 09:34:37AM -0700, Ben Pfaff wrote: Until now, a command like ovs-vsctl --may-exist add-br br0 yielded a confusing error message. Users had to realize that the correct form was ovs-vsctl -- --may-exist add-br br0, but instead they often reported a bug or gave up in

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-06 Thread Ben Pfaff
On Fri, Nov 02, 2012 at 02:26:20PM -0700, Ben Pfaff wrote: On Fri, Nov 02, 2012 at 04:21:56PM -0500, Adam Heath wrote: On 11/02/2012 04:19 PM, Ben Pfaff wrote: I still don't understand. Why would an existing script call ovs-vsctl with --may-exist as a global option? The call would not

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-06 Thread Adam Heath
On 11/06/2012 11:10 AM, Ben Pfaff wrote: On Fri, Nov 02, 2012 at 02:26:20PM -0700, Ben Pfaff wrote: On Fri, Nov 02, 2012 at 04:21:56PM -0500, Adam Heath wrote: On 11/02/2012 04:19 PM, Ben Pfaff wrote: I still don't understand. Why would an existing script call ovs-vsctl with --may-exist as a

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-02 Thread Ben Pfaff
On Mon, Oct 29, 2012 at 03:03:13PM -0500, Adam Heath wrote: On 10/29/2012 11:34 AM, Ben Pfaff wrote: Until now, a command like ovs-vsctl --may-exist add-br br0 yielded a confusing error message. Users had to realize that the correct form was ovs-vsctl -- --may-exist add-br br0, but instead

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-02 Thread Adam Heath
On 11/02/2012 12:49 PM, Ben Pfaff wrote: On Mon, Oct 29, 2012 at 03:03:13PM -0500, Adam Heath wrote: On 10/29/2012 11:34 AM, Ben Pfaff wrote: Until now, a command like ovs-vsctl --may-exist add-br br0 yielded a confusing error message. Users had to realize that the correct form was ovs-vsctl

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-02 Thread Ben Pfaff
On Fri, Nov 02, 2012 at 03:40:20PM -0500, Adam Heath wrote: On 11/02/2012 12:49 PM, Ben Pfaff wrote: On Mon, Oct 29, 2012 at 03:03:13PM -0500, Adam Heath wrote: On 10/29/2012 11:34 AM, Ben Pfaff wrote: Until now, a command like ovs-vsctl --may-exist add-br br0 yielded a confusing error

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-02 Thread Adam Heath
On 11/02/2012 04:19 PM, Ben Pfaff wrote: I still don't understand. Why would an existing script call ovs-vsctl with --may-exist as a global option? The call would not do anything useful, because it would exit with a fatal error every time. Taking this argument to its logical conclusion, one

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-02 Thread Ben Pfaff
On Fri, Nov 02, 2012 at 04:21:56PM -0500, Adam Heath wrote: On 11/02/2012 04:19 PM, Ben Pfaff wrote: I still don't understand. Why would an existing script call ovs-vsctl with --may-exist as a global option? The call would not do anything useful, because it would exit with a fatal error

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-10-29 Thread Adam Heath
On 10/29/2012 11:34 AM, Ben Pfaff wrote: Until now, a command like ovs-vsctl --may-exist add-br br0 yielded a confusing error message. Users had to realize that the correct form was ovs-vsctl -- --may-exist add-br br0, but instead they often reported a bug or gave up in frustration. Even