Re: t/api/server_const.t test failure from Red Hat developer vanity patches

2012-10-01 Thread Joe Orton
On Wed, Aug 01, 2012 at 01:41:34PM -0700, Fred Moyer wrote: The reason this test failure occurs is because the RedHat rpm devs patched the version component code to replace 'Unix' with @VENDOR@, in these cases either Centos or Fedora. But their patch isn't complete - they didn't patch the

Re: t/api/server_const.t test failure from Red Hat developer vanity patches

2012-10-01 Thread Fred Moyer
On Oct 1, 2012 5:28 AM, Joe Orton jor...@redhat.com wrote: On Wed, Aug 01, 2012 at 01:41:34PM -0700, Fred Moyer wrote: The reason this test failure occurs is because the RedHat rpm devs patched the version component code to replace 'Unix' with @VENDOR@, in these cases either Centos or

Re: Fwd: Re: trying mod_perl patches for httpd 2.4

2012-09-26 Thread Jan Kaluža
On 09/26/2012 02:10 AM, Andy Colson wrote: sorry, didn't cc the list. Original Message Subject: Re: trying mod_perl patches for httpd 2.4 Date: Tue, 25 Sep 2012 19:08:16 -0500 From: Andy Colson a...@squeakycode.net To: Jan Kaluža jkal...@redhat.com Try as I might, I cannot

Re: Fwd: Re: trying mod_perl patches for httpd 2.4

2012-09-26 Thread Jan Kaluža
On 09/26/2012 10:20 AM, Jan Kaluža wrote: On 09/26/2012 02:10 AM, Andy Colson wrote: sorry, didn't cc the list. Original Message Subject: Re: trying mod_perl patches for httpd 2.4 Date: Tue, 25 Sep 2012 19:08:16 -0500 From: Andy Colson a...@squeakycode.net To: Jan Kaluža

Re: Fwd: Re: trying mod_perl patches for httpd 2.4

2012-09-26 Thread Andy Colson
On 9/26/2012 3:23 AM, Jan Kaluža wrote: Oh, I've checked the patches we use in Fedora and I think this problem is fixed by this patch: http://jkaluza.fedorapeople.org/mod_perl/mod_perl-2.0.5-nolfs.patch It's unrelated to httpd24, but I think this patch could fix it for you. At least I think I

Re: trying mod_perl patches for httpd 2.4

2012-09-25 Thread Jan Kaluža
On 09/24/2012 03:55 PM, Andy Colson wrote: On 9/24/2012 1:02 AM, Jan Kaluža wrote: On 09/22/2012 06:58 PM, Andy Colson wrote: Bummer... make test totally dies: /usr/sbin/httpd -d /home/andy/apps/mod_perl-2.0/t -f /home/andy/apps/mod_perl-2.0/t/conf/httpd.conf -D APACHE2 -D

Fwd: Re: trying mod_perl patches for httpd 2.4

2012-09-25 Thread Andy Colson
sorry, didn't cc the list. Original Message Subject: Re: trying mod_perl patches for httpd 2.4 Date: Tue, 25 Sep 2012 19:08:16 -0500 From: Andy Colson a...@squeakycode.net To: Jan Kaluža jkal...@redhat.com Try as I might, I cannot get mod_perl debug symbols to work: perl

Re: trying mod_perl patches for httpd 2.4

2012-09-24 Thread Jan Kaluža
On 09/22/2012 06:58 PM, Andy Colson wrote: Bummer... make test totally dies: ulimit -c unlimited; /usr/bin/perl5.16.1 /home/andy/apps/mod_perl-2.0/t/TEST -bugreport -verbose=0 AH00558: httpd: Could not reliably determine the server's fully qualified domain name, using 192.168.1.3. Set the

Re: trying mod_perl patches for httpd 2.4

2012-09-24 Thread Andy Colson
On 9/24/2012 1:02 AM, Jan Kaluža wrote: On 09/22/2012 06:58 PM, Andy Colson wrote: Bummer... make test totally dies: /usr/sbin/httpd -d /home/andy/apps/mod_perl-2.0/t -f /home/andy/apps/mod_perl-2.0/t/conf/httpd.conf -D APACHE2 -D PERL_USEITHREADS using Apache/2.4.3 (event MPM) waiting

Re: trying mod_perl patches for httpd 2.4

2012-09-22 Thread Andy Colson
On 09/22/2012 11:20 AM, Andy Colson wrote: Hi all, I downloaded 2.0.7 source, then applied these patches: http://jkaluza.fedorapeople.org/mod_perl/all.tgz My first attempt: $ perl Makefile.PL MP_APXS unspecified, using /usr/bin/apxs no conflicting prior mod_perl version found - good

Re: trying mod_perl patches for httpd 2.4

2012-09-22 Thread Andy Colson
Bummer... make test totally dies: ulimit -c unlimited; /usr/bin/perl5.16.1 /home/andy/apps/mod_perl-2.0/t/TEST -bugreport -verbose=0 AH00558: httpd: Could not reliably determine the server's fully qualified domain name, using 192.168.1.3. Set the 'ServerName' directive globally to

t/api/server_const.t test failure from Red Hat developer vanity patches

2012-08-01 Thread Fred Moyer
This failing test on Centos/Fedora platforms has been bugging me: [rhp@app mod_perl-2.0.7]$ ./t/TEST -verbose t/api/server_const.t ... # testing : Apache2::ServerUtil::get_server_banner() # expected: Apache/2.2.15 (Unix) world domination series/2.0 mod_apreq2-20090110/2.8.0 mod_perl/2.0.7

2 A-T patches and a bug without patch

2010-08-23 Thread Torsten Förtsch
Hi, the first patch fixes a behavior that is a bug in my humble opinion. t/TEST -start-httpd can be used to start the httpd. Later on one can use t/TEST -run-tests t/*.t to perform the actual test run. Unfortunately, this 2nd call overwrites the configuration. Normally, this should not be a

[apache2-rename] compat test patches

2005-03-08 Thread Randy Kobes
The following diffs allow for me all the compat tests in the apache2-rename-unstable branch to pass: == Index: lib/Apache2/compat.pm === --- lib/Apache2/compat.pm

Re: [apache2-rename] compat test patches

2005-03-08 Thread Geoffrey Young
Randy Kobes wrote: The following diffs allow for me all the compat tests in the apache2-rename-unstable branch to pass: cool. in general I'd think we're in ctr mode with the unstable branch - we've pretty much outlined what the goals are and there's so much to be done that you shouldn't need

Re: [apache2-rename] compat test patches

2005-03-08 Thread Joe Schaefer
Randy Kobes [EMAIL PROTECTED] writes: The following diffs allow for me all the compat tests in the apache2-rename-unstable branch to pass: Nice! +1. If all tests pass for you with this patch, please update todo/apache2_rename as well. -- Joe Schaefer

Re: eliminating modperl-2.0/patches dir?

2004-08-23 Thread Philippe M. Chiasson
Stas Bekman wrote: You discover interesting things when doing release packaging. Apparently we had an apache patch to do static modperl for years at: modperl-2.0/patches/link-hack.pat I suppose it's no longer needed, right Philippe? My godness, we sure don't need that thing around anymore

eliminating modperl-2.0/patches dir?

2004-08-19 Thread Stas Bekman
You discover interesting things when doing release packaging. Apparently we had an apache patch to do static modperl for years at: modperl-2.0/patches/link-hack.pat I suppose it's no longer needed, right Philippe? There is also modperl-2.0/patches/c-scan.pat which is the patch against

[mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Stas Bekman
I'm trying to resolve two related items in todo/release: -- some autogenerated record accessors shouldn't be get/set but only get (e.g. Apache-server-is_virtual(1) is wrong). Need to add a new flag supported by MapUtil and map files, where we can say which accessors should be

Re: [mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Geoffrey Young
Stas Bekman wrote: I'm trying to resolve two related items in todo/release: The first step: provide support for read-only structure accessors, made all perl server_rec and process_rec accessors read-only (the patch is below). I agree with most of this, save certain attributes of the

Re: [mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: I'm trying to resolve two related items in todo/release: The first step: provide support for read-only structure accessors, made all perl server_rec and process_rec accessors read-only (the patch is below). I agree with most of this, save certain

Re: [mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Geoffrey Young
in general, I don't agree with this - modifying several of the server_rec slots at request time is something that some (few) mp1 user required. Did they wanted to affect the server for the future requests, or just the current request? the only value I see is in scoping server_rec

Re: [mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Stas Bekman
Geoffrey Young wrote: in general, I don't agree with this - modifying several of the server_rec slots at request time is something that some (few) mp1 user required. Did they wanted to affect the server for the future requests, or just the current request? the only value I see is in scoping

Re: [mp2 Patch] Resubmitting OpenBSD related patches

2003-06-10 Thread Philippe M. Chiasson
On Mon, 2003-06-09 at 16:25, Stas Bekman wrote: Philippe M. Chiasson wrote: Dunno where they all went in the past, but as Stas reminded me, I am still holding off on 2 OpenBSD-related patches to make sure Apache-Test generates httpd.conf that will bind on IPv4 addresses. This is important

Re: [mp2 Patch] Resubmitting OpenBSD related patches

2003-06-10 Thread Philippe M. Chiasson
On Tue, 2003-06-10 at 14:17, Stas Bekman wrote: Philippe M. Chiasson wrote: On Mon, 2003-06-09 at 16:25, Stas Bekman wrote: Philippe M. Chiasson wrote: Dunno where they all went in the past, but as Stas reminded me, I am still holding off on 2 OpenBSD-related patches to make sure Apache

[mp2 Patch] Resubmitting OpenBSD related patches

2003-06-09 Thread Philippe M. Chiasson
Dunno where they all went in the past, but as Stas reminded me, I am still holding off on 2 OpenBSD-related patches to make sure Apache-Test generates httpd.conf that will bind on IPv4 addresses. This is important on a platform like OpenBSD where IPv6 is prefered by default and IPv4 mapped

Re: [mp2 Patch] Resubmitting OpenBSD related patches

2003-06-09 Thread Stas Bekman
Philippe M. Chiasson wrote: Dunno where they all went in the past, but as Stas reminded me, I am still holding off on 2 OpenBSD-related patches to make sure Apache-Test generates httpd.conf that will bind on IPv4 addresses. This is important on a platform like OpenBSD where IPv6 is prefered

Re: [mp2 Patch] Resubmitting OpenBSD related patches

2003-06-09 Thread Philippe M. Chiasson
On Mon, 2003-06-09 at 16:25, Stas Bekman wrote: Philippe M. Chiasson wrote: Dunno where they all went in the past, but as Stas reminded me, I am still holding off on 2 OpenBSD-related patches to make sure Apache-Test generates httpd.conf that will bind on IPv4 addresses. This is important

Re: [mp1] warnings patches

2003-03-13 Thread Stas Bekman
Randy Kobes wrote: Just for completeness, attached is a diff against the src/modules/perl mod_perl 1.0 cvs directory which gets rid of (all but one) warning on Win32. There's a few typecast insertions, plus some avoiding declaring variables that won't be used for Win32. One thing that I wasn't

Re: [mp1] warnings patches

2003-03-13 Thread Stas Bekman
One thing that I wasn't quite sure about the portability - old_warn, in, eg, perl_util.c, was defined as I32, but Windows preferred it to be unsigned char. -I32 oldwarn = dowarn; /*XXX, hmm*/ +unsigned char oldwarn = dowarn; /*XXX, hmm*/ dowarn = FALSE; U8? it's really a 'bool' in

Re: [mp1] warnings patches

2003-03-13 Thread Randy Kobes
On Fri, 14 Mar 2003, Stas Bekman wrote: Randy Kobes wrote: Just for completeness, attached is a diff against the src/modules/perl mod_perl 1.0 cvs directory which gets rid of (all but one) warning on Win32. see below: Thanks, Stas! Index: src/modules/perl/Apache.xs +

Re: [mp1] warnings patches

2003-03-13 Thread Stas Bekman
Randy Kobes wrote: Index: src/modules/perl/Apache.xs +SvGROW(buffer, (STRLEN) bufsiz+1); should we instead change the declaration of bufsiz to STRLEN bufsize; That worked out - I had to also add STRLEN T_IV to Apache/typemap. But I think it should be: T_UV At least it's T_UV in

Re: [mp1] warnings patches

2003-03-13 Thread Randy Kobes
On Fri, 14 Mar 2003, Stas Bekman wrote: Randy Kobes wrote: Index: src/modules/perl/Apache.xs +SvGROW(buffer, (STRLEN) bufsiz+1); should we instead change the declaration of bufsiz to STRLEN bufsize; That worked out - I had to also add STRLEN T_IV to

Re: [mp1] warnings patches

2003-03-13 Thread Stas Bekman
Randy Kobes wrote: On Fri, 14 Mar 2003, Stas Bekman wrote: Randy Kobes wrote: Index: src/modules/perl/Apache.xs +SvGROW(buffer, (STRLEN) bufsiz+1); should we instead change the declaration of bufsiz to STRLEN bufsize; That worked out - I had to also add STRLEN T_IV to

Re: [mp1] warnings patches

2003-03-13 Thread Randy Kobes
On Fri, 14 Mar 2003, Stas Bekman wrote: since its a STRLEN and it can't be negative, I think the right type is UV. Not that it much matters, but since we perfect things, let's have it perfect ;) I'll send a patch for B/typemap to p5p. That sounds good ... I'll change Apache/typemap to use

Re: [mp1] warnings patches

2003-03-13 Thread Stas Bekman
/typemap to use T_UV. Thanks. I've tested with 5.6.1 and 5.8.0, all seems to work fine with your recent patches. I can't test 5.005_03, my perl build it borked :( probably add an entry to Changes: Several variable types were adjusted/casted to avoid warnings during the compilation. or similar

couple of patches, now that it's live {grin}

2002-07-12 Thread Randal L. Schwartz
On http://perl.apache.org/start/index.html: Imagine the flexibility of rewriting writing URLs Say whuh? And for http://perl.apache.org/outstanding/sites.html, you can add: www.stonehenge.com provides an online easy-to-navigate archive of the 150+ magazine articles written by Perl

Patches for path with spaces

2002-07-04 Thread Gerald Richter
Hi, last week I tried to installed mod_perl-1.99_04 on a Windows system. I though it was a good idea to use the Apache binary package. Unfortunately the Apache installer suggest the path \Programme\Apache Group\Apache which contain a space (the english version will be \Program Files\Apache

Re: two small patches

2002-06-05 Thread Stas Bekman
Per Einar Ellefsen wrote: And what should happen to old refernces to the guide? Should they link to perl.apache.org, or to /docs ? Or deleted completly? Probably point them to the 1.0 guide. Depends on the context really. If it's more a general notion of the documentation as a whole, it should

Re: two small patches

2002-06-05 Thread Doug MacEachern
On Wed, 5 Jun 2002, Stas Bekman wrote: No, Doug is an official maintainer of this page. You should ask him about it. This page is not only for our site, this is supposed be a part of CPAN I believe. actually, nobody is maintaining apache-modlist.html, it should be deleted, now that the

Re: two small patches

2002-06-05 Thread Stas Bekman
Doug MacEachern wrote: On Wed, 5 Jun 2002, Stas Bekman wrote: No, Doug is an official maintainer of this page. You should ask him about it. This page is not only for our site, this is supposed be a part of CPAN I believe. actually, nobody is maintaining apache-modlist.html, it should be

Re: two small patches

2002-06-05 Thread Per Einar Ellefsen
At 04:40 05.06.2002, Stas Bekman wrote: Per Einar Ellefsen wrote: docs/1.0/ or docs/2.0/ won't work as it's not a docset. So may be it's a time to split /docs/ into 3 docsets? I like the way you can get a good overview over all the documentation from the docs/ page. It would make it slightly

Re: two small patches

2002-06-05 Thread Per Einar Ellefsen
At 04:57 05.06.2002, Stas Bekman wrote: Doug MacEachern wrote: On Wed, 5 Jun 2002, Stas Bekman wrote: No, Doug is an official maintainer of this page. You should ask him about it. This page is not only for our site, this is supposed be a part of CPAN I believe. actually, nobody is maintaining

Re: two small patches

2002-06-05 Thread Stas Bekman
Per Einar Ellefsen wrote: At 04:40 05.06.2002, Stas Bekman wrote: Per Einar Ellefsen wrote: docs/1.0/ or docs/2.0/ won't work as it's not a docset. So may be it's a time to split /docs/ into 3 docsets? I like the way you can get a good overview over all the documentation from the docs/ page. It

Re: two small patches

2002-06-05 Thread Stas Bekman
Per Einar Ellefsen wrote: At 04:57 05.06.2002, Stas Bekman wrote: Doug MacEachern wrote: On Wed, 5 Jun 2002, Stas Bekman wrote: No, Doug is an official maintainer of this page. You should ask him about it. This page is not only for our site, this is supposed be a part of CPAN I believe.

Re: two small patches

2002-06-05 Thread Per Einar Ellefsen
At 07:34 05.06.2002, Stas Bekman wrote: Per Einar Ellefsen wrote: At 04:40 05.06.2002, Stas Bekman wrote: Per Einar Ellefsen wrote: docs/1.0/ or docs/2.0/ won't work as it's not a docset. So may be it's a time to split /docs/ into 3 docsets? I like the way you can get a good overview over all the

two small patches

2002-06-04 Thread Thomas Klausner
Hi! Two more very small patches: - src/contribute/maillist.pod changed is the mailing lists to are the mailing lists. Although I'm not sure about this, but in german there is a correlation between the number of the subject and of the verb, and I think it's the same in english... - src/products

Re: two small patches

2002-06-04 Thread Per Einar Ellefsen
At 21:00 04.06.2002, Thomas Klausner wrote: Hi! Two more very small patches: - src/contribute/maillist.pod changed is the mailing lists to are the mailing lists. Although I'm not sure about this, but in german there is a correlation between the number of the subject and of the verb, and I think

Re: two small patches

2002-06-04 Thread Stas Bekman
Per Einar Ellefsen wrote: At 21:00 04.06.2002, Thomas Klausner wrote: Hi! Two more very small patches: - src/contribute/maillist.pod changed is the mailing lists to are the mailing lists. Although I'm not sure about this, but in german there is a correlation between the number of the subject

a patch tip: sending patches for new files.

2002-04-28 Thread Stas Bekman
it's ok to send complete files when you add new files, the trouble is when a new directory should be added as well. The simplest solution is to create a patch against /dev/null diff -u /dev/null newdir/newfilename.pod when this patch is applied and the new dir and the new file will be

Re: a patch tip: sending patches for new files.

2002-04-28 Thread Per Einar Ellefsen
At 10:21 28.04.2002, Stas Bekman wrote: it's ok to send complete files when you add new files, the trouble is when a new directory should be added as well. The simplest solution is to create a patch against /dev/null diff -u /dev/null newdir/newfilename.pod when this patch is applied and the

Re: a patch tip: sending patches for new files.

2002-04-28 Thread Stas Bekman
Per Einar Ellefsen wrote: At 10:21 28.04.2002, Stas Bekman wrote: it's ok to send complete files when you add new files, the trouble is when a new directory should be added as well. The simplest solution is to create a patch against /dev/null diff -u /dev/null newdir/newfilename.pod when this

Re: more content patches

2002-04-27 Thread Stas Bekman
Thomas Klausner wrote: Hi! Some more small patches: - in contribute/docs, added link to download/docs and removed reference to the documentation source package -in docs/1.0/guide/help.pod, replaced all mailing-list indo with link to mailinglist section -in src/download/docs.pod, removed a typo

Re: Some content patches..

2002-04-26 Thread Stas Bekman
Thomas Klausner wrote: Hi! I made some minor changes to the Contribute section, mainly - added some links to the mailing-list page - removed some errors (I think, at least, but my english isn't perfect...) - changed from 101 ways to How to (as there aren't 101 ways mentioned...) - edited some text

more content patches

2002-04-26 Thread Thomas Klausner
Hi! Some more small patches: - in contribute/docs, added link to download/docs and removed reference to the documentation source package -in docs/1.0/guide/help.pod, replaced all mailing-list indo with link to mailinglist section -in src/download/docs.pod, removed a typo and changed a logical

Re: more content patches

2002-04-26 Thread Per Einar Ellefsen
At 21:24 26.04.2002, Thomas Klausner wrote: Hi! Some more small patches: - in contribute/docs, added link to download/docs and removed reference to the documentation source package -in docs/1.0/guide/help.pod, replaced all mailing-list indo with link to mailinglist section -in src/download

Re: some patches

2002-03-05 Thread Stas Bekman
Bill Moseley wrote: At 09:54 AM 03/05/02 +0800, Stas Bekman wrote: Seems far more likely that CSS will mess up someone's browser ;). As Wim says, google uses it, and we all like google. CSS may render pages in a weird way, but the site will be still usable. I saw enough js that won't let me use

Re: some patches

2002-03-05 Thread Bill Moseley
At 10:47 AM 03/05/02 +0800, Stas Bekman wrote: Ok, I'll grab it from google later tonight when I get some time. Thanks Well, this seems to work in tmpl/custom/html/head body background=[% doc.dir.abs_doc_root %]/images/bgline.gif bgcolor=#ff onLoad=document.forms[0].elements[0].focus() I

Re: some patches

2002-03-05 Thread Thomas Klausner
Hi! On Tue, Mar 05, 2002 at 02:40:31PM +0800, Stas Bekman wrote: that happened because of the width or rather height that the form tag and hidden tags consume, so we ended up we a lot of un-necesary whitespace. for the above js-code to work we need to put the form tag just next to the

RE: some patches

2002-03-05 Thread Jonathan M. Hollin
:: As far as I know, a form-tag automatically adds some :: whitespace (like a p :: tag) around it's content. Yes it does. I've noticed this behaviour too. :: Another posibillity would be to define a style for form, :: specifing top-margin:0px But IMO that's to hackish and might :: brake some

Re: some patches

2002-03-04 Thread Stas Bekman
Bill Moseley wrote: At 10:07 PM 3/2/2002 -, Jonathan M. Hollin wrote: 1) I don't think it's intuitive. The Press enter text in the search field is not 100% explanatory - I think it could be misinterpreted (e.g: So I press enter and that will let me search); but when I press enter nothing

Re: some patches

2002-03-03 Thread Stas Bekman
Thomas Klausner wrote: Hi! here are some things I just did: http://domm.zsi.at/modperl-site-domm/ * removed some already solved things out of TODO * removed the nbsp hack in tail, it seems to work without it in all browsers I have access to (Mozilla, Opera, IE5, NS4) * I moved some stuff in

some patches

2002-03-02 Thread Thomas Klausner
Hi! here are some things I just did: http://domm.zsi.at/modperl-site-domm/ * removed some already solved things out of TODO * removed the nbsp hack in tail, it seems to work without it in all browsers I have access to (Mozilla, Opera, IE5, NS4) * I moved some stuff in style.css around a little

Re: Fw: Apache::SizeLimit patches

2001-07-06 Thread Doug MacEachern
On Tue, 3 Jul 2001, Perrin Harkins wrote: Here's a patch I submitted for Apache::SizeLimit, presented for your general amusement and critique. thanks perrin, this is in cvs now. - To unsubscribe, e-mail: [EMAIL PROTECTED]

patches

2001-06-26 Thread Doug MacEachern
for those who don't have mailers that will mangle inline patches, please send patches inline rather than as attachments, makes it much easier to comment on the patch. thanks. - To unsubscribe, e-mail: [EMAIL PROTECTED

Re: Apache::SizeLimit patches

2001-04-18 Thread Joshua Chamas
Doug MacEachern wrote: if you and perrin want to take over as Apache::SizeLimit owners, that would be fantastic. for now you can submit patches to this list. if you want to maintain a version on cpan too, that would be fine. the key thing to keep in mind of course, is keep 'SizeLimit.pm

Apache::SizeLimit patches

2001-02-06 Thread Joshua Chamas
Hey Modperl Devs, Perrin I have both contributed patches for Apache::SizeLimit. Both seem like good implementations resulting in the similar MAX_SHARED memory configs. So who now integrates which into Apache::SizeLimit ?? Another question ... should either Perrin or I take over

Re: ActiveState related patches

2000-09-11 Thread Gerald Richter
Hi Randy, I have tried your patches: 1.) Win32 non ActiveState Perl: ok 2.) Win32 ActiveState Perl: Insecure dependency in require while running with -T switch at d:/perl/cpan/build/modperl-as/t//docs/startup.pl line 33. line 33 is "use IO::File" 3.) Unix: modules/file: FAILED