[mp2] tests : Is this how test should be added?

2003-01-15 Thread Lyle Brooks
I thought I'd help out with some of the mp2 documentation, and as part of that effort, I thought I'd try to write some tests. The idea being that it'd be a nice if the documentation reflected how the code actually worked. :-) So I thought I'd try writing my first test script and adding it to mp2

Re: [mp2] tests : Is this how test should be added?

2003-01-15 Thread Stas Bekman
Lyle Brooks wrote: I thought I'd help out with some of the mp2 documentation, and as part of that effort, I thought I'd try to write some tests. That's a very helpful thing to do. We need many more tests. The idea being that it'd be a nice if the documentation reflected how the code actually w

Re: [mp2] tests : Is this how test should be added?

2003-01-15 Thread Stas Bekman
Stas Bekman wrote: Lyle Brooks wrote: What section of code is doing this operation? I looked around but it wasn't immediately obvious to me. [...] The code that generates it is easy to find, look at the caller trace in one of the .t files that were autogenerated. e.g. t/api/request_rec.t t

how to gracefully resolve problems in bad filters?

2003-01-15 Thread Stas Bekman
Any filter must always send something down-stream, this something should be at least an empty bucket brigade. If the input filter doesn't send anything down the stream, apache asserts: [Thu Jan 16 15:49:56 2003] [crit] [Thu Jan 16 15:49:56 2003] file http_protocol.c, line 1915, assertion "!(((&

rfc: new filtering APIs

2003-01-15 Thread Stas Bekman
[cross-posting dev/users list, since I'm not sure whether all those who can give a useful input are on the dev list] I've implemented a few filtering APIs recently. Rather than prototyping in Perl I've decided to go with C from the very beginning since most of the code was there already thanks