[GitHub] [roller] mbien commented on a diff in pull request #119: minor dependency updates + test-summary workflow action

2023-03-23 Thread via GitHub
mbien commented on code in PR #119: URL: https://github.com/apache/roller/pull/119#discussion_r1145926223 ## app/pom.xml: ## @@ -39,24 +39,24 @@ limitations under the License. 1.4.7 1.2 1.7.8 -1.10.12 -9.3 +1.10.13 +9.4

[GitHub] [roller] mbien commented on pull request #119: minor dependency updates + test-summary workflow action

2023-03-23 Thread via GitHub
mbien commented on PR #119: URL: https://github.com/apache/roller/pull/119#issuecomment-1480884171 all green. @snoopdave approved via dev list -> merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [roller] mbien merged pull request #119: minor dependency updates + test-summary workflow action

2023-03-23 Thread via GitHub
mbien merged PR #119: URL: https://github.com/apache/roller/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@roller.apache.org

[GitHub] [roller] mbien commented on pull request #119: minor dependency updates + test-summary workflow action

2023-03-23 Thread via GitHub
mbien commented on PR #119: URL: https://github.com/apache/roller/pull/119#issuecomment-1480880756 - rebased on top of latest master - refreshed minor dep updates - switched from JDK 19 to 20 since a release happened in the meantime tested locally -- This is an automated

[GitHub] [roller] mbien commented on pull request #124: Upgrade to struts 6.1.2

2023-03-23 Thread via GitHub
mbien commented on PR #124: URL: https://github.com/apache/roller/pull/124#issuecomment-1480915374 i wouldn't recommend to skip so many major versions at once, this rarely works. The very next minor release already causes problems. migration guide

[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2

2023-03-23 Thread via GitHub
gregh3269 commented on PR #124: URL: https://github.com/apache/roller/pull/124#issuecomment-1480909793 Checking the page the id has extra underscores. I will check if this is intentional. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [roller] mbien commented on pull request #124: Upgrade to struts 6.1.2

2023-03-23 Thread via GitHub
mbien commented on PR #124: URL: https://github.com/apache/roller/pull/124#issuecomment-1480832131 > Were there any failing tests? yes. see CI. Or try starting roller and open the management UI -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [roller] gregh3269 commented on pull request #124: Upgrade to struts 6.1.2

2023-03-23 Thread via GitHub
gregh3269 commented on PR #124: URL: https://github.com/apache/roller/pull/124#issuecomment-148108 Your are probably right here. Looking into this more, I did not realise the dependency soup with the bootstrap plugin. Plugin v5.00 uses bootstrap v5.2.0 where roller is using v3.4.1.

[GitHub] [roller] gregh3269 closed pull request #124: Upgrade to struts 6.1.2

2023-03-23 Thread via GitHub
gregh3269 closed pull request #124: Upgrade to struts 6.1.2 URL: https://github.com/apache/roller/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,