Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-09-04 Thread Kohei Yoshida
On Wed, 2008-09-03 at 12:17 +0200, Daniel Rentz wrote: Daniel Rentz schrieb: Hello Kohei looking at XExternalSheetCache::[sg]etCellValue(), I suggest to swap the parameters nRow and nColumn, because cell addresses are passed around in the entire sc module that way, and it is the

Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-09-04 Thread Kohei Yoshida
On Wed, 2008-09-03 at 13:16 +0200, Daniel Rentz wrote: Hi Kohei, some more thoughts... :-) Do we really need the SheetName string member in the ExternalReference struct? How about transporting the index of the cache in the Sheet member of the SingleReference/ComplexReference? The

Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-09-04 Thread Kohei Yoshida
On Wed, 2008-09-03 at 13:25 +0200, Daniel Rentz wrote: Hi Kohei, for the XExternalDocLink::TokenIndex attribute, we should assure in the documentation and implementation that the returned index can be used to access that cache via the XIndexAcess interface of the ExternalDocLink

Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-09-03 Thread Daniel Rentz
Hello Kohei looking at XExternalSheetCache::[sg]etCellValue(), I suggest to swap the parameters nRow and nColumn, because cell addresses are passed around in the entire sc module that way, and it is the member order in com::sun::star::table::CellAddress. Daniel

Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-09-03 Thread Daniel Rentz
Daniel Rentz schrieb: Hello Kohei looking at XExternalSheetCache::[sg]etCellValue(), I suggest to swap the parameters nRow and nColumn, because cell addresses are passed around in the entire sc module that way, and it is the member order in com::sun::star::table::CellAddress. ... see also

Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-09-03 Thread Daniel Rentz
Hi Kohei, some more thoughts... :-) Do we really need the SheetName string member in the ExternalReference struct? How about transporting the index of the cache in the Sheet member of the SingleReference/ComplexReference? The index should be available as attribute in XExternalSheetCache

Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-08-29 Thread Kohei Yoshida
Hey Daniel, On Fri, 2008-08-29 at 09:29 +0200, Daniel Rentz wrote: Hi Kohei some thoughts about the new ExternalDocLinks API in CWS mooxlsc... First, there is no documentation in the IDL files, please consider to add some ;-) Well, real men use code as the documentation. ;-) On a

Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-08-29 Thread Daniel Rentz
Kohei Yoshida schrieb: Hey Daniel, On Fri, 2008-08-29 at 09:29 +0200, Daniel Rentz wrote: Hi Kohei some thoughts about the new ExternalDocLinks API in CWS mooxlsc... First, there is no documentation in the IDL files, please consider to add some ;-) Well, real men use code as the

Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-08-29 Thread Daniel Rentz
Kohei Yoshida schrieb: On Fri, 2008-08-29 at 09:29 +0200, Daniel Rentz wrote: To do: do we need API to remove something from the cache, or an entire cache, or even an entire external linked document? I don't think it makes sense to add API to remove individual cell cache from a table, since I

Re: [sc-dev] About the ExternalDocLinks API in CWS mooxlsc

2008-08-29 Thread Kohei Yoshida
On Fri, 2008-08-29 at 14:33 +0200, Daniel Rentz wrote: I saw that Juergen Schmidt asked something too, on the [EMAIL PROTECTED] list. Oh. Well, I'm not subscribed to that list, so let me look at the archive there Kohei -- Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc. [EMAIL