Re: [VOTE] Release Apache Sling Tenants 1.0.2

2014-08-18 Thread Stefan Egli
+1 (checked md5/sha1) Cheers, Stefan On 8/17/14 11:11 AM, Carsten Ziegeler cziege...@apache.org wrote: Anyone else? 2014-08-12 9:30 GMT+02:00 Robert Munteanu romb...@apache.org: +1 Robert On Tue, Aug 12, 2014 at 10:06 AM, Carsten Ziegeler cziege...@apache.org wrote: +1

[RT] The various roles of (multitenant) content

2014-08-18 Thread Bertrand Delacretaz
Hi, I'm working on various experiments (like [1]) related to continuous deployment with Sling, and having a clearer definition of the various roles of the content that a typical Sling applications manages would help. I'm saying roles instead of types on purpose, to avoid confusion with

Sling Request Filter filtering

2014-08-18 Thread Felix Meschberger
Hi all I had various discussions around execution of Servlet API Filters in the Sling Engine. To recap: Currently all filters are always called. The service.ranking (or filter.order) service registration property can be used to define the order in which the filters are called and the

Re: Sling Request Filter filtering

2014-08-18 Thread Bertrand Delacretaz
Hi, On Mon, Aug 18, 2014 at 11:23 AM, Felix Meschberger fmesc...@adobe.com wrote: ... * filter.resourceType: The Filter is only called if the resourceType of the current Resource (SlingHttpServletRequest.getResource) matches any of the given resource types... I've long been

Re: Sling Request Filter filtering

2014-08-18 Thread Antonio Sanso
big and fat +1 from me :) regards antonio On Aug 18, 2014, at 11:23 AM, Felix Meschberger fmesc...@adobe.com wrote: Hi all I had various discussions around execution of Servlet API Filters in the Sling Engine. To recap: Currently all filters are always called. The service.ranking (or

Re: Sling Request Filter filtering

2014-08-18 Thread Jeff Young
Hi Felix, I think to reduce the unexpected you'd need filter.resourceType to match on the resource's supertype hierarchy too. Cheers, Jeff. On 18/08/2014 10:23, Felix Meschberger fmesc...@adobe.com wrote: Hi all I had various discussions around execution of Servlet API Filters in the Sling

Re: Sling Request Filter filtering

2014-08-18 Thread Bertrand Delacretaz
On Mon, Aug 18, 2014 at 12:08 PM, Jeff Young j...@adobe.com wrote: ...I think to reduce the unexpected you'd need filter.resourceType to match on the resource's supertype hierarchy too... Which is where reusing the existing script resolution logic would help, instead of reimplementing.

Re: [VOTE] Apache Sling Commons Mime 2.1.6 and Apache Sling Commons OSGi 2.2.2

2014-08-18 Thread Carsten Ziegeler
Hmm, org.apache.tika.mime;resolution:=optional;version=[1.0,2) 2014-08-17 19:24 GMT+02:00 Oliver Lietz apa...@oliverlietz.de: On Tuesday 12 August 2014 08:37:18 Carsten Ziegeler wrote: Hi, in order to get Launchpad 7 out, this is a vote to release Commons Mime 2.1.6

Re: Sling Request Filter filtering

2014-08-18 Thread Felix Meschberger
Hi Am 18.08.2014 um 12:08 schrieb Jeff Young j...@adobe.com: Hi Felix, I think to reduce the unexpected you'd need filter.resourceType to match on the resource's supertype hierarchy too. Yeah, match could be ResourceUtil.isA(). But it should not be adding to much overhead for the request

Re: Sling Request Filter filtering

2014-08-18 Thread Felix Meschberger
Hi I am not sure, whether we should go down that route. A filter ist something which is a cross-cutting concern that the application places on the request processing. As such it is transparent to the client and it should not be client adressable. Otherwise unexpected behaviour is guaranteed.

Re: Sling Request Filter filtering

2014-08-18 Thread Carsten Ziegeler
Do we really really need this? At least path based filtering can be done with plain servlet filters already. What are the use cases for this? Carsten 2014-08-18 13:07 GMT+02:00 Felix Meschberger fmesc...@adobe.com: Hi I am not sure, whether we should go down that route. A filter ist

[VOTE RESULT] Release Apache Sling Tenants 1.0.2

2014-08-18 Thread Carsten Ziegeler
The vote passes with three binding +1 votes from Stefan Egli, Carsten Ziegeler, and Robert Munteanu. Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org

[jira] [Closed] (SLING-3247) ClassCastException may be thrown if Session is not a JackrabbitSession

2014-08-18 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3247. --- ClassCastException may be thrown if Session is not a JackrabbitSession

[jira] [Closed] (SLING-3245) TenantAdapterFactory can return incorrect 'null' tenants depending on order of pathMatchers

2014-08-18 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3245. --- TenantAdapterFactory can return incorrect 'null' tenants depending on order of pathMatchers

[jira] [Closed] (SLING-3376) TenantProvider passes tenant with old state to TenantCustomizer

2014-08-18 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3376. --- TenantProvider passes tenant with old state to TenantCustomizer

Re: [VOTE] Apache Sling Commons Mime 2.1.6 and Apache Sling Commons OSGi 2.2.2

2014-08-18 Thread Carsten Ziegeler
Oliver, could you please revert your -1? Tika is not required and the bundle runs without it, the Tika provider does not run, but that's expected - and I think this has already been the case for 2.1.4. So no new requirements for this bundle. Thanks Carsten 2014-08-18 12:44 GMT+02:00 Carsten

Re: [RT] The various roles of (multitenant) content

2014-08-18 Thread Ian Boston
Hi, Is configuration part of application content or system content or both? I can see that in a clustered environment you might want to have configuration shared centrally amongst many versions of the running application, but you might also need configuration local to a running version, so that

Re: [RT] The various roles of (multitenant) content

2014-08-18 Thread Bertrand Delacretaz
Hi, On Mon, Aug 18, 2014 at 2:56 PM, Ian Boston i...@tfd.co.uk wrote: ... Is configuration part of application content or system content or both? ... We probably need a more fine-grained definition for configs - for now I see the following types of configuration: a) Global system-level config,

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-18 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100694#comment-14100694 ] Carsten Ziegeler commented on SLING-3848: - I've applied the api patch in rev

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-18 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100727#comment-14100727 ] Felix Meschberger commented on SLING-3848: -- One noticeable improvement in the

Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Launchpad Testing #41

2014-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/41/

Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Pax Exam Utilities #41

2014-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.paxexam.util/41/

Jenkins build is still unstable: sling-trunk-1.8 #41

2014-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.8/changes

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-18 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100743#comment-14100743 ] Carsten Ziegeler commented on SLING-3848: - Thanks Felix, I'll add this to the

Re: Sling Request Filter filtering

2014-08-18 Thread Justin Edelson
Hi, On Mon, Aug 18, 2014 at 1:30 PM, Dominik Süß dominik.su...@gmail.com wrote: Hi Felix, you probably remember our discussion - I checked and found out that resourceresolution is done with adminsession anyways and superTypeHierarchy being cached (at least from what I remember) therefore

Re: [RT] The various roles of (multitenant) content

2014-08-18 Thread Ruben Reusser
looking at this it seems the same functionality would be handy for feature flags, no? Ruben On 8/18/2014 6:19 AM, Bertrand Delacretaz wrote: Hi, On Mon, Aug 18, 2014 at 2:56 PM, Ian Boston i...@tfd.co.uk wrote: ... Is configuration part of application content or system content or both? ...

Re: Sling Request Filter filtering

2014-08-18 Thread Dominik Süß
Hi Carsten, I've played around with filters a lot and the problem with them really is that they often have way to much impact and are not constrainted as they would need to be. Even those filters skipping often create a lot of overhead because they do not skip fast and with cheap evaluations but

Re: Sling Request Filter filtering

2014-08-18 Thread Dominik Süß
Hi Justin, I'm not talking about global disable because the filter often is extremely necessary but to be able to disable it for dedicated cases. I just remember some obscure ColumnControlFilter only checking for the Pathending colctrl and autorewriting the node underneath. Turning off that filter

Re: Sling Request Filter filtering

2014-08-18 Thread Carsten Ziegeler
Well, so the main argument is badly written code? 2014-08-18 19:35 GMT+02:00 Dominik Süß dominik.su...@gmail.com: Hi Carsten, I've played around with filters a lot and the problem with them really is that they often have way to much impact and are not constrainted as they would need to be.

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-18 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101244#comment-14101244 ] Carsten Ziegeler commented on SLING-3848: - Thanks for your patch to the jcr

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-18 Thread Rob Ryan (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101298#comment-14101298 ] Rob Ryan commented on SLING-3848: - [~cziegeler] Thanks for the quick action. WRT your

Re: [VOTE] Apache Sling Commons Mime 2.1.6 and Apache Sling Commons OSGi 2.2.2

2014-08-18 Thread Oliver Lietz
On Monday 18 August 2014 13:38:15 Carsten Ziegeler wrote: Oliver, could you please revert your -1? Tika is not required and the bundle runs without it, the Tika provider does not run, but that's expected - and I think this has already been the case for 2.1.4. So no new requirements for this

Re: [VOTE] Apache Sling Commons Mime 2.1.6 and Apache Sling Commons OSGi 2.2.2

2014-08-18 Thread Oliver Lietz
On Monday 18 August 2014 23:21:44 Oliver Lietz wrote: On Monday 18 August 2014 13:38:15 Carsten Ziegeler wrote: Oliver, could you please revert your -1? Tika is not required and the bundle runs without it, the Tika provider does not run, but that's expected - and I think this has already

Build failed in Jenkins: sling-trunk-1.8 #42

2014-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.8/42/ -- [...truncated 226 lines...] at org.tmatesoft.svn.core.internal.util.SVNSocketFactory.createPlainSocket(SVNSocketFactory.java:73) at

Build failed in Jenkins: sling-trunk-1.6 #2379

2014-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/2379/ -- [...truncated 211 lines...] Caused by: svn: E175002: timed out waiting for server at org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:208) at

Re: [VOTE] Apache Sling Commons Mime 2.1.6 and Apache Sling Commons OSGi 2.2.2

2014-08-18 Thread Carsten Ziegeler
I agree that the current way is not nice, but I think it's nothing which should block the release. Anyone else who wants to vote? Regards Carsten 2014-08-18 23:44 GMT+02:00 Oliver Lietz apa...@oliverlietz.de: On Monday 18 August 2014 23:21:44 Oliver Lietz wrote: On Monday 18 August 2014