[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-19 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101910#comment-14101910 ] Carsten Ziegeler commented on SLING-3848: - [~rr...@adobe.com] Ok, yes I agree and

[jira] [Created] (SLING-3856) NPE in JobManager.getJob if no map is provided

2014-08-19 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-3856: --- Summary: NPE in JobManager.getJob if no map is provided Key: SLING-3856 URL: https://issues.apache.org/jira/browse/SLING-3856 Project: Sling Issue

Re: Sling Request Filter filtering

2014-08-19 Thread Dominik Süß
To be honest, for me it currently is the main reason. And the code I'm refering to is owned by a vendor and getting hotfixes can take way to long. Aditionally right now writting working code is pretty easy but there is no support that helps to write proper skipping (cheap and early) of filters

Re: Sling Request Filter filtering

2014-08-19 Thread Julian Sedding
Could this be solved with an abstract class that supports additional properties to decide whether to bypass the filter or not? This would of course not help with implementations that aren't well-behaved. However, it would lower the hurdle to implement well-behaved filters. Personally I would

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-19 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102061#comment-14102061 ] Julian Sedding commented on SLING-3848: --- I recently had a use-case where I executed

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-19 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102068#comment-14102068 ] Antonio Sanso commented on SLING-3848: -- bq. , but his work has to be disabled if

[jira] [Assigned] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

2014-08-19 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso reassigned SLING-3844: Assignee: Antonio Sanso Resolver.map() spends too much time looking up sling:alias

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

2014-08-19 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102084#comment-14102084 ] Antonio Sanso commented on SLING-3844: -- [~rr...@adobe.com] thanks a lot for your

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

2014-08-19 Thread Rob Ryan (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102237#comment-14102237 ] Rob Ryan commented on SLING-3844: - [~asanso] I don't follow the reverse mapping is

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

2014-08-19 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102244#comment-14102244 ] Antonio Sanso commented on SLING-3844: -- bq I don't follow the reverse mapping is

Re: Sling Request Filter filtering

2014-08-19 Thread Justin Edelson
Hi Dominik, IIUC, the idea of Felix's original proposal was that the filter developer and deployer could declaratively determine the specific set of resource types to which a filter should be executed (whereas currently that can only be done programatically and is largely ad hoc when done at all).

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

2014-08-19 Thread Rob Ryan (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102255#comment-14102255 ] Rob Ryan commented on SLING-3844: - Please take the patch with the reverse mapping in

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

2014-08-19 Thread Rob Ryan (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102254#comment-14102254 ] Rob Ryan commented on SLING-3844: - See my updated comment above. There is no way without

[jira] [Comment Edited] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

2014-08-19 Thread Rob Ryan (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102237#comment-14102237 ] Rob Ryan edited comment on SLING-3844 at 8/19/14 2:43 PM: --

[jira] [Commented] (SLING-3017) improve Karaf integration tests

2014-08-19 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102284#comment-14102284 ] Robert Munteanu commented on SLING-3017: The Karaf module is part of the Sling

[jira] [Updated] (SLING-3849) Exporting sub-node causes parent cq:Page change to nt:folder

2014-08-19 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3849: --- Fix Version/s: Sling Eclipse IDE 1.0.4 Exporting sub-node causes parent cq:Page change to

[jira] [Commented] (SLING-3849) Exporting sub-node causes parent cq:Page change to nt:folder

2014-08-19 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102289#comment-14102289 ] Robert Munteanu commented on SLING-3849: [~lukasz.szwajkowski] - thanks for the

[jira] [Created] (SLING-3857) Provide basic ui for replication agents

2014-08-19 Thread Marius Petria (JIRA)
Marius Petria created SLING-3857: Summary: Provide basic ui for replication agents Key: SLING-3857 URL: https://issues.apache.org/jira/browse/SLING-3857 Project: Sling Issue Type: Bug

[jira] [Commented] (SLING-3857) Provide basic ui for replication agents

2014-08-19 Thread Marius Petria (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102322#comment-14102322 ] Marius Petria commented on SLING-3857: -- The uris for replication settings: {code}

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-19 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102335#comment-14102335 ] Carsten Ziegeler commented on SLING-3848: - [~jsedding] Good point, actually the

[jira] [Updated] (SLING-3857) Provide basic ui for replication agents

2014-08-19 Thread Marius Petria (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria updated SLING-3857: - Attachment: SLING-3857.patch Adding patch that supports navigation and replication triggering

Re: Sling Request Filter filtering

2014-08-19 Thread Carsten Ziegeler
Right, can we list some use cases for that stuff here? Carsten 2014-08-19 16:46 GMT+02:00 Justin Edelson jus...@justinedelson.com: Hi Carsten, While path-based filtering can be done with plain servlet filters, those don't have access to a ResourceResolver/Session/current Resource. Which

Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2380

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2380/

Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2380

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2380/

Jenkins build is unstable: sling-trunk-1.6 #2380

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/2380/changes

Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Resource Access Security Integration Tests #2380

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/2380/

Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2380

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2380/

Re: [VOTE] Apache Sling Commons Mime 2.1.6 and Apache Sling Commons OSGi 2.2.2

2014-08-19 Thread Carsten Ziegeler
We're still missing a vote, anyone, please? 2014-08-19 5:30 GMT+02:00 Carsten Ziegeler cziege...@apache.org: I agree that the current way is not nice, but I think it's nothing which should block the release. Anyone else who wants to vote? Regards Carsten 2014-08-18 23:44 GMT+02:00

Re: [VOTE] Apache Sling Commons Mime 2.1.6 and Apache Sling Commons OSGi 2.2.2

2014-08-19 Thread Justin Edelson
+1 On Tue, Aug 19, 2014 at 1:49 PM, Carsten Ziegeler cziege...@apache.org wrote: We're still missing a vote, anyone, please? 2014-08-19 5:30 GMT+02:00 Carsten Ziegeler cziege...@apache.org: I agree that the current way is not nice, but I think it's nothing which should block the release.

[VOTE RESULT] Apache Sling Commons Mime 2.1.6 and Apache Sling Commons OSGi 2.2.2

2014-08-19 Thread Carsten Ziegeler
The vote passes with four binding +1 votes for releasing Commons OSGi 2.2.2 and three binding +1 votes for releasing Commons Mime 2.1.6 Thanks Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org

[jira] [Closed] (SLING-3793) Field in MimeTypeServiceImpl must be declared volatile

2014-08-19 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3793. --- Field in MimeTypeServiceImpl must be declared volatile

[jira] [Closed] (SLING-2278) Convert DS setup and package export to annotations

2014-08-19 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-2278. --- Convert DS setup and package export to annotations

[jira] [Closed] (SLING-1059) Mime Type Detection should use Apache Tika

2014-08-19 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-1059. --- Mime Type Detection should use Apache Tika --

Re: [VOTE] Apache Sling Commons Mime 2.1.6 and Apache Sling Commons OSGi 2.2.2

2014-08-19 Thread Daniel Klco
+1 On Tue, Aug 19, 2014 at 1:49 PM, Carsten Ziegeler cziege...@apache.org wrote: We're still missing a vote, anyone, please? 2014-08-19 5:30 GMT+02:00 Carsten Ziegeler cziege...@apache.org: I agree that the current way is not nice, but I think it's nothing which should block the

[jira] [Created] (SLING-3858) Avoid logging of exception if Tika is not available

2014-08-19 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-3858: --- Summary: Avoid logging of exception if Tika is not available Key: SLING-3858 URL: https://issues.apache.org/jira/browse/SLING-3858 Project: Sling

[jira] [Created] (SLING-3859) ResourceResolver from JcrItemAdapterFactory is not closed

2014-08-19 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-3859: --- Summary: ResourceResolver from JcrItemAdapterFactory is not closed Key: SLING-3859 URL: https://issues.apache.org/jira/browse/SLING-3859 Project: Sling

Removing or at least deprecating JcrItemAdapterFactory

2014-08-19 Thread Carsten Ziegeler
While working on some changes in the jcr resource bsundle I came across JcrItemAdapterFactory which allows to adapt a Node/Property to a resource (and other things). While this alone is already questionable, as noted in SLING-3859 this creates a potential memory leak as the returend resource

[jira] [Resolved] (SLING-3856) NPE in JobManager.getJob if no map is provided

2014-08-19 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3856. - Resolution: Fixed Fixed in rev 1618926 NPE in JobManager.getJob if no map is provided

Re: Sling Request Filter filtering

2014-08-19 Thread Justin Edelson
Hi Carsten, Here's a few: * I need to be able to modify a JSON object returned by a servlet, for example to reorder objects in an array. In these cases, I have written a filter which gets the serialized object returned by the servlet, parses it, transforms it, and serializes it. * I need to be

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-19 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102627#comment-14102627 ] Carsten Ziegeler commented on SLING-3848: - I've added some code to avoid calls to

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-19 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102685#comment-14102685 ] Carsten Ziegeler commented on SLING-3848: - In rev 1618944 I've unified handling

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

2014-08-19 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102692#comment-14102692 ] Carsten Ziegeler commented on SLING-3848: - Removed some more unnecessary calls to

[jira] [Commented] (SLING-3017) improve Karaf integration tests

2014-08-19 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102829#comment-14102829 ] Oliver Lietz commented on SLING-3017: - source and target is still 1.6, we just run

Build failed in Jenkins: sling-healthcheck-1.6 #452

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-healthcheck-1.6/452/ -- [...truncated 226 lines...] at org.tmatesoft.svn.core.internal.util.SVNSocketFactory.createPlainSocket(SVNSocketFactory.java:73) at

[jira] [Updated] (SLING-3709) Sling Models: Allow caller to deal with exceptions

2014-08-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3709: -- Component/s: Extensions Sling Models: Allow caller to deal with exceptions

[jira] [Updated] (SLING-3716) Sling Models: Add support for constructor dependency injection

2014-08-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3716: -- Labels: models (was: ) Sling Models: Add support for constructor dependency injection

Build failed in Jenkins: sling-trunk-1.7 #755

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.7/755/ -- [...truncated 226 lines...] at org.tmatesoft.svn.core.internal.util.SVNSocketFactory.createPlainSocket(SVNSocketFactory.java:73) at

Build failed in Jenkins: sling-trunk-1.8 #43

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.8/43/ -- [...truncated 226 lines...] at org.tmatesoft.svn.core.internal.util.SVNSocketFactory.createPlainSocket(SVNSocketFactory.java:73) at

Build failed in Jenkins: sling-trunk-1.6 #2381

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/2381/ -- [...truncated 213 lines...] Caused by: svn: E175002: timed out waiting for server at org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:208) at

[jira] [Updated] (SLING-3715) Sling Models: Support for class-based dependency injection

2014-08-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3715: -- Labels: models (was: ) Sling Models: Support for class-based dependency injection

[jira] [Updated] (SLING-3822) Sling Models Documentation: Please document the separator for Sling-Model-Packages

2014-08-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3822: -- Labels: models (was: ) Sling Models Documentation: Please document the separator for

[jira] [Updated] (SLING-3716) Sling Models: Add support for constructor dependency injection

2014-08-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3716: -- Fix Version/s: Sling Models API 1.0.4 Sling Models Implementation 1.0.8

[jira] [Assigned] (SLING-3716) Sling Models: Add support for constructor dependency injection

2014-08-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson reassigned SLING-3716: - Assignee: Justin Edelson Sling Models: Add support for constructor dependency injection

[jira] [Updated] (SLING-3718) Sling Models: Add self Injector for supporting chains of object injecting dependencies from a common source

2014-08-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3718: -- Fix Version/s: Sling Models API 1.0.4 Sling Models Implementation 1.0.8

[jira] [Resolved] (SLING-3716) Sling Models: Add support for constructor dependency injection

2014-08-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-3716. --- Resolution: Fixed Patch applied in r1619007. Thanks and sorry for the delay! I made a few

[jira] [Resolved] (SLING-3718) Sling Models: Add self Injector for supporting chains of object injecting dependencies from a common source

2014-08-19 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-3718. --- Resolution: Fixed Resolved in r1619007. See SLING-3716 for more details. Sling Models: Add

[jira] [Created] (SLING-3860) Sling Models - max recursion depth should be configurable

2014-08-19 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-3860: - Summary: Sling Models - max recursion depth should be configurable Key: SLING-3860 URL: https://issues.apache.org/jira/browse/SLING-3860 Project: Sling

Build failed in Jenkins: sling-contrib-1.6 #1205

2014-08-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-contrib-1.6/1205/ -- [...truncated 227 lines...] at org.tmatesoft.svn.core.internal.util.SVNSocketFactory.createPlainSocket(SVNSocketFactory.java:73) at

Re: Removing or at least deprecating JcrItemAdapterFactory

2014-08-19 Thread Bertrand Delacretaz
Hi, On Tue, Aug 19, 2014 at 8:38 PM, Carsten Ziegeler cziege...@apache.org wrote: ...I think this adaption is conceptually wrong and I have no idea why we added this in the first place, so adding this to the memory leak problem, I would simply remove this thing It was added by Justin for