[jira] [Updated] (SLING-7436) Wrong content/type in the Default JSON Renderer

2018-01-23 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-7436: - Description: Steps to reproduce: 1.Render a page (Renderer enabled) with JSON renderer. E.g:

[jira] [Updated] (SLING-7436) Wrong content/type in the Default JSON Renderer

2018-01-23 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-7436: - Description: Steps to reproduce: 1.Render a page (Renderer enabled) with JSON renderer. E.g:

[jira] [Created] (SLING-7436) Wrong content/type in the Default JSON Renderer

2018-01-23 Thread Antonio Sanso (JIRA)
Antonio Sanso created SLING-7436: Summary: Wrong content/type in the Default JSON Renderer Key: SLING-7436 URL: https://issues.apache.org/jira/browse/SLING-7436 Project: Sling Issue Type:

[jira] [Commented] (SLING-2778) initial Sling/Jolokia integration bundle

2018-01-23 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336890#comment-16336890 ] Chetan Mehrotra commented on SLING-2778: [~justinedelson] Can you provide the path in sling repo

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336397#comment-16336397 ] Robert Munteanu commented on SLING-7432: Interesting, I did not know about that. I looked briefly

[jira] [Comment Edited] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336397#comment-16336397 ] Robert Munteanu edited comment on SLING-7432 at 1/23/18 9:27 PM: -

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336388#comment-16336388 ] Konrad Windszus commented on SLING-7432: New threads by default carry some thread locals (which

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336371#comment-16336371 ] Robert Munteanu commented on SLING-7432: While going deeper and deeper in the code we currently

Re: [VOTE] Release Apache Sling Commons Threads 3.2.12

2018-01-23 Thread Carsten Ziegeler
Agree: -1 Carsten Robert Munteanu wrote > On Mon, 2018-01-22 at 14:21 +0200, Robert Munteanu wrote: >> On Mon, 2018-01-22 at 12:12 +0100, Stefan Egli wrote: >>> Please vote to approve this release: >> >> +1 > > I am changing my vote to -1 in light of a blocking issue I discovered > while

[jira] [Commented] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing

2018-01-23 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336259#comment-16336259 ] Carsten Ziegeler commented on SLING-7428: - [~kwin] No, it might be a timing issue, when everything

Re: Git force push

2018-01-23 Thread Robert Munteanu
Hi, On Tue, 2018-01-23 at 15:05 +0100, Stefan Egli wrote: > Sounds like a good idea to start with disallowing --force for now, > given > there is --force-with-lease for emergencies. The unfortunate bit is > perhaps that this opens up a way to modify history without noticing > (which > is what

[jira] [Created] (SLING-7434) Authorizable pipe autocreate group does not handle dryRun

2018-01-23 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7434: -- Summary: Authorizable pipe autocreate group does not handle dryRun Key: SLING-7434 URL: https://issues.apache.org/jira/browse/SLING-7434 Project: Sling

[jira] [Created] (SLING-7435) Authorizable pipe autocreate group does not handle dryRun

2018-01-23 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7435: -- Summary: Authorizable pipe autocreate group does not handle dryRun Key: SLING-7435 URL: https://issues.apache.org/jira/browse/SLING-7435 Project: Sling

Re: documentation locations

2018-01-23 Thread Oliver Lietz
On Tuesday 23 January 2018 16:43:37 Bertrand Delacretaz wrote: > Hi, > > On Tue, Jan 23, 2018 at 3:40 PM, Oliver Lietz wrote: > > ...AFAIR we agreed on having basic documentation in the README and higher > > level documentation or documentation spanning multiple modules on

Re: documentation locations

2018-01-23 Thread Bertrand Delacretaz
Hi, On Tue, Jan 23, 2018 at 3:40 PM, Oliver Lietz wrote: > ...AFAIR we agreed on having basic documentation in the README and higher > level > documentation or documentation spanning multiple modules on Sling's site under > /documentation... That works for me - however

[jira] [Commented] (SLING-7320) NPE in sling commons threads

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335915#comment-16335915 ] Konrad Windszus commented on SLING-7320: Prevented the NPE in copy with

[jira] [Updated] (SLING-7320) NPE in sling commons threads

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7320: --- Fix Version/s: Commons Threads 3.2.14 > NPE in sling commons threads >

[jira] [Resolved] (SLING-7433) Improve logging in case ThreadLocalCleaner does not work

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-7433. Resolution: Fixed Fix Version/s: Commons Threads 3.2.14 Fixed in

[jira] [Updated] (SLING-7433) Improve logging in case ThreadLocalCleaner does not work

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7433: --- Description: Currently {{ThreadLocalCleaner}} relies on exceptions in case anything in it

[jira] [Created] (SLING-7433) Improve logging in case ThreadLocalCleaner does not work

2018-01-23 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-7433: -- Summary: Improve logging in case ThreadLocalCleaner does not work Key: SLING-7433 URL: https://issues.apache.org/jira/browse/SLING-7433 Project: Sling

[jira] [Assigned] (SLING-7320) NPE in sling commons threads

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-7320: -- Assignee: Konrad Windszus > NPE in sling commons threads >

[jira] [Commented] (SLING-7320) NPE in sling commons threads

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335881#comment-16335881 ] Konrad Windszus commented on SLING-7320: The latter NPE can only happen if listener is {{null}}.

[jira] [Resolved] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-7428. - Resolution: Fixed Fixed in [commit

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335864#comment-16335864 ] Robert Munteanu commented on SLING-7432: Well, I apparently fixed one problem, but I am still able

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335860#comment-16335860 ] Konrad Windszus commented on SLING-7432: Looks good to me. I am wondering whether

[jira] [Updated] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-7428: Fix Version/s: Scripting HTL Testing Content 1.0.8-1.3.1 > StartupFilter not reliably stopped (and

[jira] [Resolved] (SLING-7431) Allow the HTL IT to run against the latest stable launchpad artifact and against the latest snapshot

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-7431. - Resolution: Fixed Fixed in [commit

Re: documentation locations

2018-01-23 Thread Oliver Lietz
On Tuesday 23 January 2018 13:54:30 Jason Bailey wrote: > Is there a determination on where the true source of documentation is? > We have the sling-site project, we have the README in each individual > project and the plugins are using the maven-sites-plugin. AFAIR we agreed on having basic

[jira] [Comment Edited] (SLING-7406) Provide HTL specification version info in artifact names

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335822#comment-16335822 ] Radu Cotescu edited comment on SLING-7406 at 1/23/18 2:35 PM: -- Fixed in the

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335840#comment-16335840 ] Robert Munteanu commented on SLING-7432: Applied a potential fix in

[jira] [Commented] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335831#comment-16335831 ] Konrad Windszus commented on SLING-7421: I added an IT for this in

Re: [VOTE] Release Apache Sling Commons Threads 3.2.12

2018-01-23 Thread Oliver Lietz
On Monday 22 January 2018 12:12:44 Stefan Egli wrote: > Hi, > > we solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12341693 +1 O.

[jira] [Resolved] (SLING-7406) Provide HTL specification version info in artifact names

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-7406. - Resolution: Fixed Fixed in the following commits: * [commit

[jira] [Commented] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335803#comment-16335803 ] Radu Cotescu commented on SLING-7428: - ACK: I'll move the README file. :) > StartupFilter not

Re: Git force push

2018-01-23 Thread Stefan Egli
Sounds like a good idea to start with disallowing --force for now, given there is --force-with-lease for emergencies. The unfortunate bit is perhaps that this opens up a way to modify history without noticing (which is what I've used it for too). Cheers, Stefan On 23.01.18, 14:59, "Jason Bailey"

[jira] [Comment Edited] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335806#comment-16335806 ] Radu Cotescu edited comment on SLING-7428 at 1/23/18 2:08 PM: -- [~cziegeler],

[CANCELLED][VOTE] Release Apache Sling Commons Threads 3.2.12

2018-01-23 Thread Stefan Egli
Cancelling this release as per comment from Robert re SLING-7432. I'd suggest to use 3.2.14 for a next commons threads release once that is ready. Cheers, Stefan On 22.01.18, 12:12, "Stefan Egli" wrote: >Hi, > >we solved 1 issue in this release:

[jira] [Commented] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335806#comment-16335806 ] Konrad Windszus commented on SLING-7428: Any idea why this issue did not occur with every

[jira] [Updated] (SLING-7406) Provide HTL specification version info in artifact names

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-7406: Fix Version/s: Scripting HTL Testing 1.0.6-1.3.1 Scripting HTL Testing Content

RE: Git force push

2018-01-23 Thread Jason Bailey
The methodology with GIT is usually around never committing anything directly to master, rather branch and merge. Internally I have our github projects set up to prevent force pushes to master and to allow it on branches so that the developer working on that branch has the option of fixing

[jira] [Comment Edited] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335793#comment-16335793 ] Robert Munteanu edited comment on SLING-7432 at 1/23/18 1:58 PM: - Added

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335793#comment-16335793 ] Robert Munteanu commented on SLING-7432: Added ignore test in

Re: [VOTE] Release Apache Sling Commons Threads 3.2.12

2018-01-23 Thread Robert Munteanu
On Mon, 2018-01-22 at 14:21 +0200, Robert Munteanu wrote: > On Mon, 2018-01-22 at 12:12 +0100, Stefan Egli wrote: > > Please vote to approve this release: > > +1 I am changing my vote to -1 in light of a blocking issue I discovered while doing some extensive tests.

documentation locations

2018-01-23 Thread Jason Bailey
Is there a determination on where the true source of documentation is? We have the sling-site project, we have the README in each individual project and the plugins are using the maven-sites-plugin. In Git projects it's usually the README or a unique docs folder. In a related note, if the

[jira] [Created] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

2018-01-23 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-7432: -- Summary: Thread pool clean up code can lead to infinite loops in ThreadLocal.get Key: SLING-7432 URL: https://issues.apache.org/jira/browse/SLING-7432 Project:

Re: Git force push

2018-01-23 Thread Bertrand Delacretaz
On Tue, Jan 23, 2018 at 2:33 PM, Stefan Seifert wrote: > i would also vote for *not* allowing push --force.. +1, my understanding is that one can destroy history with that...which we don't want. I have never used --force-with-lease so far but according to [1] it only

RE: Git force push

2018-01-23 Thread Stefan Seifert
i would also vote for *not* allowing push --force stefan >-Original Message- >From: Oliver Lietz [mailto:apa...@oliverlietz.de] >Sent: Tuesday, January 23, 2018 1:21 PM >To: dev@sling.apache.org >Subject: Git force push > >Hi, > >can we have a simple rule (allow vs deny) for git push

Re: Git force push

2018-01-23 Thread Stefan Egli
I just stumbled upon a problem where I did a commit with a wrong author email (in SLING-7407) and "thanks" to force push I was able to correct this. Not saying it is a good idea to do this often though .. ;) Cheers, Stefan On 23.01.18, 13:26, "Radu Cotescu" wrote: >Hi Oliver,

[jira] [Commented] (SLING-7430) Invalid assumptions in SlingSpecificsSightlyIT#testI18nBasename

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335751#comment-16335751 ] Konrad Windszus commented on SLING-7430: Actually both values "die Bank" as well as "das Ufer" are

[jira] [Commented] (SLING-7426) Use bnd Maven plugins

2018-01-23 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335750#comment-16335750 ] Oliver Lietz commented on SLING-7426: - bq. We export packages as soon as they have a Version

[jira] [Commented] (SLING-7430) Invalid assumptions in SlingSpecificsSightlyIT#testI18nBasename

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335748#comment-16335748 ] Radu Cotescu commented on SLING-7430: - [~kwin], I'm afraid you didn't check the test properly. The

[jira] [Created] (SLING-7431) Allow the HTL IT to run against the latest stable launchpad artifact and against the latest snapshot

2018-01-23 Thread Radu Cotescu (JIRA)
Radu Cotescu created SLING-7431: --- Summary: Allow the HTL IT to run against the latest stable launchpad artifact and against the latest snapshot Key: SLING-7431 URL: https://issues.apache.org/jira/browse/SLING-7431

[jira] [Commented] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335739#comment-16335739 ] Konrad Windszus commented on SLING-7421: [~radu.cotescu] IMHO the documentation of Sling i18n with

[jira] [Created] (SLING-7430) Invalid assumptions in SlingSpecificsSightlyIT#testI18nBasename

2018-01-23 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-7430: -- Summary: Invalid assumptions in SlingSpecificsSightlyIT#testI18nBasename Key: SLING-7430 URL: https://issues.apache.org/jira/browse/SLING-7430 Project: Sling

[jira] [Commented] (SLING-7426) Use bnd Maven plugins

2018-01-23 Thread Nicolas Peltier (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335734#comment-16335734 ] Nicolas Peltier commented on SLING-7426: thanks [~cziegeler] (cc [~olli]) will run additional

[jira] [Created] (SLING-7429) Improve basename handling

2018-01-23 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-7429: -- Summary: Improve basename handling Key: SLING-7429 URL: https://issues.apache.org/jira/browse/SLING-7429 Project: Sling Issue Type: Improvement

[jira] [Comment Edited] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335686#comment-16335686 ] Konrad Windszus edited comment on SLING-7421 at 1/23/18 12:41 PM: -- Yes

[jira] [Commented] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335722#comment-16335722 ] Radu Cotescu commented on SLING-7421: - It could very well be that the Sightly IT is making wrong

[jira] [Commented] (SLING-7426) Use bnd Maven plugins

2018-01-23 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335716#comment-16335716 ] Carsten Ziegeler commented on SLING-7426: - I think it makes sense to slowly move to the maven

[jira] [Updated] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7428: --- Summary: StartupFilter not reliably stopped (and still returning 503) when executing

[jira] [Commented] (SLING-7428) StartupFilter nor reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing

2018-01-23 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335711#comment-16335711 ] Carsten Ziegeler commented on SLING-7428: - I think waiting for untransformed resources makes

New i18n release and basename handling (was: [VOTE] Release Apache Sling Starter 10 + associated testing projects and archetypes (take 2))

2018-01-23 Thread Robert Munteanu
Hi Konrad, On Tue, 2018-01-23 at 13:13 +0100, Konrad Windszus wrote: > But before spinning a new release I would like to get some more > opinions on the basename handling of the i18n bundle in general > (compare with https://issues.apache.org/jira/browse/SLING-7421?focuse >

Re: Git force push

2018-01-23 Thread Radu Cotescu
Hi Oliver, Shouldn't we *never* allow force push? Cheers, Radu On Tue, 23 Jan 2018 at 14:20 Oliver Lietz wrote: > Hi, > > can we have a simple rule (allow vs deny) for git push --force? > > Thanks, > O. > >

[CANCELLED] [VOTE] Release Apache Sling Starter 10 + associated testing projects and archetypes (take 2)

2018-01-23 Thread Robert Munteanu
This release is cancelled since it is affected by SLING-7421 [1]. Thanks to Radu for catching this regression and for Konrad for assessing the impact of the release. The plan is to drop the starter 10 release artifact and respin once we have a new i18n release (maybe include them in the same

Git force push

2018-01-23 Thread Oliver Lietz
Hi, can we have a simple rule (allow vs deny) for git push --force? Thanks, O.

[jira] [Commented] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335686#comment-16335686 ] Konrad Windszus commented on SLING-7421: Yes exactly. But even after having this one fixed Sightly

[jira] [Commented] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335683#comment-16335683 ] Robert Munteanu commented on SLING-7421: [~kwin] - that's what we risk by releasing Sling 10

Re: [VOTE] Release Apache Sling Starter 10 + associated testing projects and archetypes (take 2)

2018-01-23 Thread Konrad Windszus
After having evaluated the impact of https://issues.apache.org/jira/browse/SLING-7421 more closely I am also voting -1 for this release. But before spinning a new release I would like to get some more opinions on the basename handling of the

[jira] [Updated] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-7421: --- Priority: Critical (was: Major) > JcrResourceBundle does not correctly support multiple base

[jira] [Commented] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335679#comment-16335679 ] Konrad Windszus commented on SLING-7421: To clarify the impact of this bug: Whenever a resource

[jira] [Comment Edited] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335677#comment-16335677 ] Konrad Windszus edited comment on SLING-7421 at 1/23/18 12:06 PM: -- I

[jira] [Commented] (SLING-7421) JcrResourceBundle does not correctly support multiple base names

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335677#comment-16335677 ] Konrad Windszus commented on SLING-7421: I think the base name handling should be rethought a bit.

Re: [VOTE] Release Apache Sling Starter 10 + associated testing projects and archetypes (take 2)

2018-01-23 Thread Robert Munteanu
On Tue, 2018-01-23 at 11:49 +0100, Karl Pauls wrote: > Sounds like it isn't necessarily a showstopper - I guess Robert has > to > make the call if he wants to cancel the release or have it pass. > > FWIW, I would have liked to have the latest servlets.post 2.3.24 > release included as well so if

[jira] [Created] (SLING-7428) StartupFilter nor reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing

2018-01-23 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-7428: -- Summary: StartupFilter nor reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing Key: SLING-7428 URL:

[jira] [Commented] (SLING-7073) Update bundle versions

2018-01-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335648#comment-16335648 ] Konrad Windszus commented on SLING-7073: After looking at the Sightly IT more closely I am pretty

Re: [VOTE] Release Apache Sling Starter 10 + associated testing projects and archetypes (take 2)

2018-01-23 Thread Karl Pauls
Sounds like it isn't necessarily a showstopper - I guess Robert has to make the call if he wants to cancel the release or have it pass. FWIW, I would have liked to have the latest servlets.post 2.3.24 release included as well so if we respin the release we might include it as well :-). regards,

Re: [VOTE] Release Apache Sling Starter 10 + associated testing projects and archetypes (take 2)

2018-01-23 Thread Radu Cotescu
Hi Karl, A project deployed on the Sling 10 Starter that would use i18n with a resource bundle provider that should take into account the basename requested by the client might fail to get the correct translation. Cheers, Radu On Tue, 23 Jan 2018 at 12:17 Karl Pauls wrote:

Re: [VOTE] Release Apache Sling Starter 10 + associated testing projects and archetypes (take 2)

2018-01-23 Thread Karl Pauls
Hi Radu, what is the impact of this bug (mostly want to find out if it breaks us in a major way or if it is just a special case)? regards, Karl On Tue, Jan 23, 2018 at 11:01 AM, Radu Cotescu wrote: > -1. See >

[jira] [Closed] (SLING-7346) Issues with custom fields in PostResponse as a result of fix for SLING-6681(Replace commons.json usage in org.apache.sling.servlets.post)

2018-01-23 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-7346. - > Issues with custom fields in PostResponse as a result of fix for > SLING-6681(Replace commons.json usage

Re: [RESULT][VOTE] Release Apache Sling Servlets Post 2.3.24

2018-01-23 Thread Karl Pauls
Time to call the vote on the Apache Sling Servlets Post 2.3.24 release. * +1 votes from Carsten Ziegeler, Stefan Seifert, and Karl Pauls. * No other votes. The vote is successful. I will make the artifacts available as soon as possible.

Re: [VOTE] Release Apache Sling Servlets Post 2.3.24

2018-01-23 Thread Karl Pauls
+1 regards, Karl On Fri, Jan 19, 2018 at 11:31 AM, Stefan Seifert wrote: > +1 > -- Karl Pauls karlpa...@gmail.com

[jira] [Commented] (SLING-7426) Use bnd Maven plugins

2018-01-23 Thread Oliver Lietz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335582#comment-16335582 ] Oliver Lietz commented on SLING-7426: - Yes. The bnd Maven Plugin was added by [~cziegeler] in mid 2016

[jira] [Comment Edited] (SLING-6952) Release Sling 10

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335586#comment-16335586 ] Radu Cotescu edited comment on SLING-6952 at 1/23/18 10:02 AM: --- [~rombert],

Re: [VOTE] Release Apache Sling Starter 10 + associated testing projects and archetypes (take 2)

2018-01-23 Thread Radu Cotescu
-1. See https://issues.apache.org/jira/browse/SLING-6952?focusedCommentId=16335586=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16335586 . Sorry for this... :( Radu On Mon, 22 Jan 2018 at 23:16 Karl Pauls wrote: > +1 > > regards, > > Karl > >

[jira] [Comment Edited] (SLING-6952) Release Sling 10

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335586#comment-16335586 ] Radu Cotescu edited comment on SLING-6952 at 1/23/18 9:59 AM: -- [~rombert],

[jira] [Commented] (SLING-6952) Release Sling 10

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335586#comment-16335586 ] Radu Cotescu commented on SLING-6952: - [~rombert], please check my comment from \[0\]. The staged

[jira] [Comment Edited] (SLING-7073) Update bundle versions

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335529#comment-16335529 ] Radu Cotescu edited comment on SLING-7073 at 1/23/18 9:55 AM: -- Worked with

[jira] [Resolved] (SLING-7426) Use bnd Maven plugins

2018-01-23 Thread Nicolas Peltier (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7426. Resolution: Fixed Fix Version/s: pipes 2.0.0 Thanks [~olli] ! > Use bnd Maven

Re: Please welcome Jason Bailey, Sling committer

2018-01-23 Thread Bertrand Delacretaz
Hi Jason, welcome! On Mon, Jan 22, 2018 at 8:45 PM, Jason Bailey wrote: > I've been primarily a Java developer since the 1.2 days... > ...audio codec implementations, swing apps... Same here...Swing apps in 1999, and they even worked, those were the days! -Bertrand

[jira] [Commented] (SLING-7426) Use bnd Maven plugins

2018-01-23 Thread Nicolas Peltier (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335558#comment-16335558 ] Nicolas Peltier commented on SLING-7426: is the rationale the arguments detailed here:

[jira] [Resolved] (SLING-7427) Package names should be all lowercase

2018-01-23 Thread Nicolas Peltier (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7427. Resolution: Fixed > Package names should be all lowercase >

[jira] [Commented] (SLING-7427) Package names should be all lowercase

2018-01-23 Thread Nicolas Peltier (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335554#comment-16335554 ] Nicolas Peltier commented on SLING-7427: thanks for your vigilance [~olli]! > Package names

[jira] [Commented] (SLING-7073) Update bundle versions

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335529#comment-16335529 ] Radu Cotescu commented on SLING-7073: - Worked with 2.5.8, doesn't work with 2.5.10, works again with

[jira] [Commented] (SLING-7073) Update bundle versions

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335506#comment-16335506 ] Robert Munteanu commented on SLING-7073: If this works with 2.5.10 but not with 2.5.12 then it's

[jira] [Commented] (SLING-7073) Update bundle versions

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335486#comment-16335486 ] Radu Cotescu commented on SLING-7073: - {{basename}} doesn't seem to be correctly taken into

[jira] [Comment Edited] (SLING-7073) Update bundle versions

2018-01-23 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335486#comment-16335486 ] Radu Cotescu edited comment on SLING-7073 at 1/23/18 8:17 AM: -- {{basename}}

[jira] [Commented] (SLING-7073) Update bundle versions

2018-01-23 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335481#comment-16335481 ] Robert Munteanu commented on SLING-7073: [~radu.cotescu] - what errors do you see? SLING-7421