[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[ https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609975#comment-16609975 ] Jason E Bailey commented on SLING-7890: --- [~bdelacretaz] So something is odd here. The reason this

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[ https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609770#comment-16609770 ] Bertrand Delacretaz commented on SLING-7890: Ok, got it - sorry that I didn't figure it out

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[ https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609761#comment-16609761 ] Jason E Bailey commented on SLING-7890: --- [~bdelacretaz] yes there is a difference in the output,

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[ https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609733#comment-16609733 ] Bertrand Delacretaz commented on SLING-7890: The commit that you mention is

Re: integration fail for VersionInfoServletTest

Hi Jason, On Mon, Sep 10, 2018 at 2:48 PM Jason E Bailey wrote: > ...I changed the integration test I have commented at https://issues.apache.org/jira/browse/SLING-7890 -Bertrand

[GitHub] hasinidilanka commented on issue #14: First commit for oidc handler.

hasinidilanka commented on issue #14: First commit for oidc handler. URL: https://github.com/apache/sling-whiteboard/pull/14#issuecomment-420021014 @rombert Sorry for taking a long time to fix this. I have fixed the first three requests for initial submission. Can you please review and

[GitHub] dichaudh commented on issue #6: SLING-7793 ACLs pipes

dichaudh commented on issue #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#issuecomment-420007241 Raising a new one as there are too many commits and squashing has failed refer :

[GitHub] dichaudh opened a new pull request #7: SLING-7793 ACLs pipe

dichaudh opened a new pull request #7: SLING-7793 ACLs pipe URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [VOTE] Release Apache Sling Servlet Annotations 1.1.0

+1 On Mon, Sep 10, 2018 at 4:19 AM Nicolas Peltier wrote: > Hi, > > with my +1, we miss one binding vote to get this released > > Thanks, > Nicolas > > Le mer. 5 sept. 2018 à 09:32, Stefan Seifert a > écrit : > > > +1 > > >

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216374722 ## File path: pom.xml ## @@ -114,7 +114,7 @@ * * - + Review

[GitHub] dichaudh commented on a change in pull request #6: SLING-7793 ACLs pipes

dichaudh commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216374008 ## File path: pom.xml ## @@ -114,7 +114,7 @@ * * - + Review

[GitHub] npeltier commented on issue #6: SLING-7793 ACLs pipes

npeltier commented on issue #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#issuecomment-419953661 we are almost there @dichaudh ! - pls remove the trailing space in pom - fix javadoc for acl pipe `mvn javadoc:javadoc` returns for it

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216364675 ## File path: pom.xml ## @@ -114,7 +114,7 @@ * * - + Review

[GitHub] dichaudh commented on a change in pull request #6: SLING-7793 ACLs pipes

dichaudh commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216358817 ## File path: src/test/java/org/apache/sling/pipes/internal/ACLPipeTest.java ## @@ -0,0 +1,136 @@ +package

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216353616 ## File path: src/test/java/org/apache/sling/pipes/internal/ACLPipeTest.java ## @@ -0,0 +1,136 @@ +package

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216351468 ## File path: src/main/java/org/apache/sling/pipes/PipeBuilder.java ## @@ -252,6 +253,36 @@

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216351430 ## File path: src/main/java/org/apache/sling/pipes/PipeBuilder.java ## @@ -252,6 +253,36 @@

[GitHub] dichaudh commented on a change in pull request #6: SLING-7793 ACLs pipes

dichaudh commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216347846 ## File path: src/main/java/org/apache/sling/pipes/PipeBuilder.java ## @@ -252,6 +253,36 @@

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216326522 ## File path: pom.xml ## @@ -111,10 +111,10 @@ provided -* -*

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216326759 ## File path: src/main/java/org/apache/sling/pipes/PipeBuilder.java ## @@ -252,6 +253,36 @@

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216326463 ## File path: pom.xml ## @@ -208,9 +208,9 @@ provided -org.apache.sling -

integration fail for VersionInfoServletTest

Okay, So I did a refactoring of the Default GET servlet bundle a while back and missed validating against the integration tests. As I'm working through issues that popped up, I have one where the test was failing because a boolean value was being accessed as a String, and that no longer

[GitHub] dichaudh commented on issue #6: SLING-7793 ACLs pipes

dichaudh commented on issue #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#issuecomment-419894884 @npeltier please find my changes done with latest commit . Thanks Dinesh

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

Thanks Stefan, I just realized I replied to myself earlier: My apologies, corrected staging repository ID, please use repository 1962: Hi, We solved 1 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12343855 Staging repository:

[jira] [Commented] (SLING-7902) The http.conn.timeout property on ForwardDistributionAgentFactory does not pick user entered values.

[ https://issues.apache.org/jira/browse/SLING-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609059#comment-16609059 ] Adityasharma commented on SLING-7902: - A PR for the same has been raised

[GitHub] addy0001 opened a new pull request #9: SLING-7902 Reading the http.conn.timeout values from the config.

addy0001 opened a new pull request #9: SLING-7902 Reading the http.conn.timeout values from the config. URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/9 @tmaret , @mpetria , @npeltier Could you please review the same. I would be raising a separate PR for the

[jira] [Closed] (SLING-7884) Sanitize output of appender names

[ https://issues.apache.org/jira/browse/SLING-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-7884. -- > Sanitize output of appender names > - > > Key:

[RESULT] [VOTE] Release Apache Sling Commons Log 5.1.10

Hi, The vote has passed with the following result : +1 (binding): Daniel Klco, Carsten Ziegeler, Daniel Klco I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks, Robert `

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216233941 ## File path: src/main/java/org/apache/sling/pipes/internal/ACLPipe.java ## @@ -0,0 +1,260 @@ +/* + * Licensed

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216234960 ## File path: src/main/java/org/apache/sling/pipes/internal/ACLPipe.java ## @@ -0,0 +1,260 @@ +/* + * Licensed

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216231612 ## File path: src/main/java/org/apache/sling/pipes/PipeBuilder.java ## @@ -252,6 +253,16 @@

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216237395 ## File path: src/main/java/org/apache/sling/pipes/internal/ACLPipe.java ## @@ -0,0 +1,260 @@ +/* + * Licensed

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216234077 ## File path: src/main/java/org/apache/sling/pipes/internal/ACLPipe.java ## @@ -0,0 +1,260 @@ +/* + * Licensed

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216237815 ## File path: src/main/java/org/apache/sling/pipes/internal/ACLPipe.java ## @@ -0,0 +1,260 @@ +/* + * Licensed

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216234229 ## File path: src/main/java/org/apache/sling/pipes/internal/ACLPipe.java ## @@ -0,0 +1,260 @@ +/* + * Licensed

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216237610 ## File path: src/main/java/org/apache/sling/pipes/internal/ACLPipe.java ## @@ -0,0 +1,260 @@ +/* + * Licensed

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216239296 ## File path: src/main/java/org/apache/sling/pipes/internal/ACLPipe.java ## @@ -0,0 +1,260 @@ +/* + * Licensed

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216231316 ## File path: pom.xml ## @@ -248,6 +254,17 @@ 1.3.2 test + + org.apache.sling +

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216242702 ## File path: src/test/java/org/apache/sling/pipes/internal/ACLPipeTest.java ## @@ -0,0 +1,136 @@ +package

[GitHub] npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes

npeltier commented on a change in pull request #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#discussion_r216231286 ## File path: pom.xml ## @@ -248,6 +254,17 @@ 1.3.2 test + + org.apache.sling +

[jira] [Assigned] (SLING-6344) Support filter.xmls being generated by the content-package-maven-plugin

[ https://issues.apache.org/jira/browse/SLING-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-6344: -- Assignee: Konrad Windszus > Support filter.xmls being generated by the

[jira] [Commented] (SLING-7888) Provide ability for SDI to ignore all query params

[ https://issues.apache.org/jira/browse/SLING-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608831#comment-16608831 ] Dawid Kłos commented on SLING-7888: --- This is active pull request for that

RE: [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

+1 the correct URL is https://repository.apache.org/content/repositories/orgapachesling-1962 and sh check_staged_release.sh 1962 /tmp/sling-staging stefan >-Original Message- >From: Daniel Klco >Sent: Friday, September 7, 2018 7:16 PM >To: dev@sling.apache.org >Subject: [VOTE]

[GitHub] dichaudh commented on issue #6: SLING-7793 ACLs pipes

dichaudh commented on issue #6: SLING-7793 ACLs pipes URL: https://github.com/apache/sling-org-apache-sling-pipes/pull/6#issuecomment-419817087 @npeltier I already tried with .acls('allow') or .acls('deny') but api expect conf params to be even in number so went with similar