[jira] [Closed] (SLING-7586) [Sling Models] Memory Leak in cached adapters

[ https://issues.apache.org/jira/browse/SLING-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7586. --- > [Sling Models] Memory Leak in cached adapters > - > >

[jira] [Closed] (SLING-7603) Add missing OSGi capabilities

[ https://issues.apache.org/jira/browse/SLING-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7603. --- > Add missing OSGi capabilities > - > > Key: SLING-7603 >

[jira] [Closed] (SLING-8043) create MissingElementsException only if there is at least one missing element

[ https://issues.apache.org/jira/browse/SLING-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8043. --- > create MissingElementsException only if there is at least one missing element >

[jira] [Closed] (SLING-7584) Only the last DisposalCallbackRegistry is disposed when multiple models are adapted in the same request

[ https://issues.apache.org/jira/browse/SLING-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7584. --- > Only the last DisposalCallbackRegistry is disposed when multiple models are > adapted in the same request >

RESULT] [VOTE] Release Apache Sling Models Impl version 1.4.10

Hi, The vote has passed with the following result : +1 (binding): Oliver Lietz, Stefan Egli, Robert Munteanu, Dan Klco I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.

Re: Sling 12 themes

Agreed with Justin. There are several different sources of URLs which may need to be rewritten including directly from scripts, WYSIWYG HTML or Java / Model generated HTML (bad practice, I know) and I'm not seeing how a pure-HTL solution would handle WYSIWYG HTML or Java / Model HTML without

Re: Sling 12 themes

On Wednesday 24 October 2018 06:55:06 Carsten Ziegeler wrote: > As usual we're giving ourselves and our users a hard time as we want to > support all the possible options in the world instead of focusing on one > or two options and make them as good as possible. I don't care what the > solution

Re: Sling 12 themes

Hi Jason, Am Mi., 24. Okt. 2018 um 14:45 Uhr schrieb Jason E Bailey : > > > On Wed, Oct 24, 2018, at 2:18 AM, Jörg Hoh wrote: > > > If we choose that way and want to prefer 1 and 2 we have to educate a lot > > of people first about the difference between a resource path and a URL > > pointing to

Re: Sling 12 themes

Hi Jason, > On 24 Oct 2018, at 14:45, Jason E Bailey wrote: > > On Wed, Oct 24, 2018, at 2:18 AM, Jörg Hoh wrote: > >> If we choose that way and want to prefer 1 and 2 we have to educate a lot >> of people first about the difference between a resource path and a URL >> pointing to that

Re: Sling 12 themes

As long as this doesn't require explicit action by the script developer, I could see this working. But that's not how, IIUC, HTL works. Rewriting has to work even if the script developer didn't anticipate that a particular element/attribute/text content needs rewriting. On Wed, Oct 24, 2018 at

[GitHub] simonetripodi commented on a change in pull request #14: Issue/sling 8038

simonetripodi commented on a change in pull request #14: Issue/sling 8038 URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/14#discussion_r227787621 ## File path: src/main/java/org/apache/sling/feature/maven/mojos/ArtifactsMojo.java ## @@ -38,8 +38,7 @@

[GitHub] simonetripodi commented on a change in pull request #14: Issue/sling 8038

simonetripodi commented on a change in pull request #14: Issue/sling 8038 URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/14#discussion_r227787130 ## File path: src/main/java/org/apache/sling/feature/maven/mojos/AbstractRepositoryMojo.java ## @@ -65,7

[GitHub] simonetripodi commented on a change in pull request #14: Issue/sling 8038

simonetripodi commented on a change in pull request #14: Issue/sling 8038 URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/14#discussion_r227787130 ## File path: src/main/java/org/apache/sling/feature/maven/mojos/AbstractRepositoryMojo.java ## @@ -65,7

[GitHub] simonetripodi commented on a change in pull request #14: Issue/sling 8038

simonetripodi commented on a change in pull request #14: Issue/sling 8038 URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/14#discussion_r227787130 ## File path: src/main/java/org/apache/sling/feature/maven/mojos/AbstractRepositoryMojo.java ## @@ -65,7

[GitHub] simonetripodi commented on a change in pull request #14: Issue/sling 8038

simonetripodi commented on a change in pull request #14: Issue/sling 8038 URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/14#discussion_r227785818 ## File path: src/main/java/org/apache/sling/feature/maven/mojos/AbstractRepositoryMojo.java ## @@ -47,7

Re: Sling 12 themes

These are orthogonal questions IMO. We can say that the one true way of generating HTML is HTL (or Thymeleaf or JSP or whatever). But that doesn't obviate the need to modify the *output* of the HTL script using some kind of AOP model (which is really what the rewriter is). On Wed, Oct 24, 2018

Re: Sling 12 themes

IMHO modifying the script would not even be necessary in the best case for HTL as the HTL context would lead to automatically invoking a certain HTL plugin which allows to modify the link itself. So I totally agree we need aspect-oriented programming here (i.e. only do it once in code instead

Re: Sling 12 themes

As I was trying to say, this assumes that modifying the script (or the model or even the content) is an option. In many cases it isn't. How often, I don't know, but I'm sure it is more than 5% (although I guess it depends on how this is measured). On Wed, Oct 24, 2018 at 1:20 AM Carsten

use cases for the rewriter that I have used

# Validation of endpoints of URLS's - looking for invalid URL's # Modifying a URL to have a different prefix as part of a multi-tenant implementation, user selects a resource to point to, or include into an existing page. That resource is accessible via the tree but technically lives in a

Re: Sling 12 themes

On Wed, Oct 24, 2018, at 2:18 AM, Jörg Hoh wrote: > If we choose that way and want to prefer 1 and 2 we have to educate a lot > of people first about the difference between a resource path and a URL > pointing to that resource. In 99% all cases I saw in the last decade, both > scripts and

Re: Sling 12 themes

So a couple of months ago I was trying to resolve the issue of HTML5 support in the rewriter and I realized that the current implementation isn't a good fit for HTML5 and is overly heavy and complex. As I was diving into the the HTML5 specs I came up with a solution that could correctly

Re: Archetype naming (was: [VOTE] Release Apache Sling 11)

On Tue, 2018-10-23 at 20:51 +0200, Oliver Lietz wrote: > On Tuesday 23 October 2018 10:38:52 Robert Munteanu wrote: > > Hi Olli, > > Hi Robert, > > > On Mon, 2018-10-22 at 22:08 +0200, Oliver Lietz wrote: > > > > > - sling-launchpad-archetype 1.0.8 > > > > > > should be sling-starter-archetype

[jira] [Comment Edited] (SLING-8008) Create dedicated parent for bundle projects

[ https://issues.apache.org/jira/browse/SLING-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662089#comment-16662089 ] Konrad Windszus edited comment on SLING-8008 at 10/24/18 10:49 AM: --- PR

[jira] [Commented] (SLING-8008) Create dedicated parent for bundle projects

[ https://issues.apache.org/jira/browse/SLING-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662089#comment-16662089 ] Konrad Windszus commented on SLING-8008: PR created in

[jira] [Assigned] (SLING-8008) Create dedicated parent for bundle projects

[ https://issues.apache.org/jira/browse/SLING-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-8008: -- Assignee: Konrad Windszus > Create dedicated parent for bundle projects >

[GitHub] kwin opened a new pull request #3: SLING-8008 separate parent pom for bundles

kwin opened a new pull request #3: SLING-8008 separate parent pom for bundles URL: https://github.com/apache/sling-parent/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (SLING-7903) Release Sling 11

[ https://issues.apache.org/jira/browse/SLING-7903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-7903. Resolution: Fixed Assignee: Robert Munteanu > Release Sling 11 > >

[jira] [Resolved] (SLING-7911) Send announcement to u...@sling.apache.org and annou...@apache.org

[ https://issues.apache.org/jira/browse/SLING-7911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-7911. Resolution: Fixed > Send announcement to u...@sling.apache.org and annou...@apache.org >

Re: Sling 12 themes

I think it would be good to start collecting use cases for rewriting. Then we see how much could be covered by an HTL plugin (in case HTL would be used). > On 24. Oct 2018, at 10:41, Carsten Ziegeler > wrote: > > Very valid point, thanks Jörg. > > I think in the

Re: Sling 12 themes

Very valid point, thanks Jörg. I think in the end it depends on whether we want to step back for a second and look what the best solution is or whether we just want to continue with what we have and put more stuff on top of it and try to make it work somehow. Carsten Am 24.10.2018 um 08:18

Re: Sling 12 themes

Hi Am Mi., 24. Okt. 2018 um 07:20 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > > > So I think there are three places where you potentially do the > modifications: > 1. You modify your model which is the input to your script > 2. You do it in a script > 3. You reparse the output of