[jira] [Created] (SLING-9703) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-9703: --- Summary: Enable code coverage with JaCoCo Key: SLING-9703 URL: https://issues.apache.org/jira/browse/SLING-9703 Project: Sling Issue Type: Task

[jira] [Created] (SLING-9702) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-9702: --- Summary: Enable code coverage with JaCoCo Key: SLING-9702 URL: https://issues.apache.org/jira/browse/SLING-9702 Project: Sling Issue Type: Task

[jira] [Created] (SLING-9701) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-9701: --- Summary: Enable code coverage with JaCoCo Key: SLING-9701 URL: https://issues.apache.org/jira/browse/SLING-9701 Project: Sling Issue Type: Task

[GitHub] [sling-org-apache-sling-starter] cmrockwell commented on pull request #13: SLING-9695 Added options for datastore

2020-08-26 Thread GitBox
cmrockwell commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-681152224 Update: I updated the pull request resolving the PM/FM conflict and created an aggregate feature file (oak_tar_fds.json) This satisfies my requirement for

[jira] [Resolved] (SLING-9700) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9700. - Resolution: Done > Enable code coverage with JaCoCo > > >

[jira] [Created] (SLING-9700) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-9700: --- Summary: Enable code coverage with JaCoCo Key: SLING-9700 URL: https://issues.apache.org/jira/browse/SLING-9700 Project: Sling Issue Type: Task

[jira] [Resolved] (SLING-9699) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9699. - Resolution: Done > Enable code coverage with JaCoCo > > >

[jira] [Created] (SLING-9699) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-9699: --- Summary: Enable code coverage with JaCoCo Key: SLING-9699 URL: https://issues.apache.org/jira/browse/SLING-9699 Project: Sling Issue Type: Task

[jira] [Resolved] (SLING-9698) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9698. - Resolution: Done > Enable code coverage with JaCoCo > > >

[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #13: SLING-9695 Added options for datastore

2020-08-26 Thread GitBox
sonarcloud[bot] commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-681076010 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=13=false=BUG)

[jira] [Created] (SLING-9698) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-9698: --- Summary: Enable code coverage with JaCoCo Key: SLING-9698 URL: https://issues.apache.org/jira/browse/SLING-9698 Project: Sling Issue Type: Task

[jira] [Resolved] (SLING-9697) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9697. - Resolution: Done > Enable code coverage with JaCoCo > > >

[jira] [Created] (SLING-9697) Enable code coverage with JaCoCo

2020-08-26 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-9697: --- Summary: Enable code coverage with JaCoCo Key: SLING-9697 URL: https://issues.apache.org/jira/browse/SLING-9697 Project: Sling Issue Type: Task

[jira] [Updated] (SLING-9696) HTL does not correctly cast the "false" string to Boolean

2020-08-26 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9696: Fix Version/s: Scripting HTL Runtime 1.2.4-1.4.0 > HTL does not correctly cast the "false" string

[jira] [Comment Edited] (SLING-9314) NPE in ObjectModel.toBoolean(Object) when object.toString() returns null

2020-08-26 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185308#comment-17185308 ] Radu Cotescu edited comment on SLING-9314 at 8/26/20, 4:22 PM: --- Fixed in

[jira] [Updated] (SLING-9696) HTL does not correctly cast the "false" string to Boolean

2020-08-26 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9696: Description: The HTL engine implementation from Apache Sling seems to have never correctly casted

[jira] [Resolved] (SLING-9314) NPE in ObjectModel.toBoolean(Object) when object.toString() returns null

2020-08-26 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9314. - Resolution: Fixed Fixed inĀ [commit

[jira] [Created] (SLING-9696) HTL does not correctly cast the "false" string to Boolean

2020-08-26 Thread Radu Cotescu (Jira)
Radu Cotescu created SLING-9696: --- Summary: HTL does not correctly cast the "false" string to Boolean Key: SLING-9696 URL: https://issues.apache.org/jira/browse/SLING-9696 Project: Sling Issue

[jira] [Commented] (SLING-9694) XSSAPIImpl#getValidHref does not escape the ampersand character

2020-08-26 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185258#comment-17185258 ] Radu Cotescu commented on SLING-9694: - Copying the answer from SLING-9011: I'm tempted to not pursue

[jira] [Resolved] (SLING-9694) XSSAPIImpl#getValidHref does not escape the ampersand character

2020-08-26 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9694. - Fix Version/s: (was: XSS Protection API 2.2.8) Resolution: Won't Fix >

[jira] [Resolved] (SLING-9011) HTL: "automatic" context=uri on href/src seems to be wrong - Should be uri *and* html

2020-08-26 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9011. - Resolution: Won't Fix > HTL: "automatic" context=uri on href/src seems to be wrong - Should be

[GitHub] [sling-org-apache-sling-starter] cmrockwell commented on pull request #13: SLING-9695 Added options for datastore

2020-08-26 Thread GitBox
cmrockwell commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-680933657 @rombert Thanks for the feedback. Launching the instance as you suggest with a series of feature.json is a bit cumbersome as compared to the prior way

[GitHub] [sling-org-apache-sling-starter] cmrockwell edited a comment on pull request #13: SLING-9695 Added options for datastore

2020-08-26 Thread GitBox
cmrockwell edited a comment on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-680933657 @rombert Thanks for the feedback. Launching the instance as you suggest with a series of feature.json is a bit cumbersome as compared to the prior

[jira] [Comment Edited] (SLING-9314) NPE in ObjectModel.toBoolean(Object) when object.toString() returns null

2020-08-26 Thread Paul Bjorkstrand (Jira)
[ https://issues.apache.org/jira/browse/SLING-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185209#comment-17185209 ] Paul Bjorkstrand edited comment on SLING-9314 at 8/26/20, 2:56 PM: ---

[jira] [Commented] (SLING-9314) NPE in ObjectModel.toBoolean(Object) when object.toString() returns null

2020-08-26 Thread Paul Bjorkstrand (Jira)
[ https://issues.apache.org/jira/browse/SLING-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185209#comment-17185209 ] Paul Bjorkstrand commented on SLING-9314: - [~radu], I add a comment (rather lengthy, sorry) to

[GitHub] [sling-org-apache-sling-superimposing] kwin commented on a change in pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations

2020-08-26 Thread GitBox
kwin commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r477295346 ## File path: pom.xml ## @@ -43,120 +42,120 @@ - + -org.apache.felix -

[jira] [Commented] (SLING-9688) Upgrade Sling superimposing to use OSGi R7 annotations

2020-08-26 Thread Saurabh Khare (Jira)
[ https://issues.apache.org/jira/browse/SLING-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185182#comment-17185182 ] Saurabh Khare commented on SLING-9688: -- Pull request:

[GitHub] [sling-org-apache-sling-superimposing] sonarcloud[bot] commented on pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations

2020-08-26 Thread GitBox
sonarcloud[bot] commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#issuecomment-680872125 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG)

[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare opened a new pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations

2020-08-26 Thread GitBox
saurabh-khare opened a new pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2 Please refer ticket SLING-9688 for more information https://issues.apache.org/jira/browse/SLING-9688

[jira] [Commented] (SLING-9662) Introduce a Resource Mapping SPI

2020-08-26 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185180#comment-17185180 ] Carsten Ziegeler commented on SLING-9662: - [~henzlerg] I think it would be good to move the spi

[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare closed pull request #1: API Upgrade

2020-08-26 Thread GitBox
saurabh-khare closed pull request #1: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (SLING-9622) Avoid registration of auth requirements for aliases and vanity paths

2020-08-26 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185057#comment-17185057 ] Robert Munteanu commented on SLING-9622: Thanks for the comments [~angela] - I've updated the

[jira] [Commented] (SLING-9011) HTL: "automatic" context=uri on href/src seems to be wrong - Should be uri *and* html

2020-08-26 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185029#comment-17185029 ] Radu Cotescu commented on SLING-9011: - [~Henry Kuijpers], I'm tempted to not pursue the fix here,

Re: [DISCUSS] Resource Mapping SPI

2020-08-26 Thread Carsten Ziegeler
Hi Georg, Am 25.08.2020 um 18:53 schrieb Georg Henzler: We should have an API that can be used for this, whether this is rr.map() or something new is a different question. I have no problem with having rr.map() doing this. I'm in favour of not introducing a new API if it's not absolutely