Re: [VOTE] Release Apache Sling Rewriter 1.3.0

2021-01-18 Thread Daniel Klco
Stefan, I verified by reproducing and fixing the test on Windows 10. The issue is the test expects a line ending of \n when checking the output from printing the doctype. Changing the test resolved the issue and otherwise there seem to be no issues with the implementation code. I will fix the

[jira] [Commented] (SLING-10069) The generated features target dir is created in the wrong place

2021-01-18 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267567#comment-17267567 ] Eric Norman commented on SLING-10069: - I've created a PR at:

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #67: SLING-10069 The generated features target dir is created in the wrong place

2021-01-18 Thread GitBox
sonarcloud[bot] commented on pull request #67: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/67#issuecomment-762512824 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=67=false=BUG)

[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman opened a new pull request #67: SLING-10069 The generated features target dir is created in the wrong place

2021-01-18 Thread GitBox
enapps-enorman opened a new pull request #67: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/67 After switching to the 1.4.22 release version of the plugin, I noticed that the change for SLING-10035 appears to be creating a set of empty folders in the wrong place in

[jira] [Comment Edited] (SLING-10035) Sling Feature fails when Generated Features Directory is missing

2021-01-18 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266330#comment-17266330 ] Eric Norman edited comment on SLING-10035 at 1/18/21, 9:40 PM: --- FYI: After

[jira] [Created] (SLING-10069) The generated features target dir is created in the wrong place

2021-01-18 Thread Eric Norman (Jira)
Eric Norman created SLING-10069: --- Summary: The generated features target dir is created in the wrong place Key: SLING-10069 URL: https://issues.apache.org/jira/browse/SLING-10069 Project: Sling

[jira] [Resolved] (SLING-10060) Substitutions for the "replacePropertyVariables" values should prefer the system property value

2021-01-18 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-10060. - Resolution: Fixed Fixed at: 

[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman merged pull request #66: SLING-10060 Substitutions for the "replacePropertyVariables" values should prefer the system property value

2021-01-18 Thread GitBox
enapps-enorman merged pull request #66: URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/66 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (SLING-10066) cleanup logging for content distribution

2021-01-18 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267450#comment-17267450 ] Timothee Maret commented on SLING-10066: Thanks [~joerghoh], I merged your PR. > cleanup

[jira] [Resolved] (SLING-10066) cleanup logging for content distribution

2021-01-18 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-10066. Fix Version/s: Content Distribution Journal Core 0.1.18 Resolution: Fixed >

[jira] [Assigned] (SLING-10066) cleanup logging for content distribution

2021-01-18 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reassigned SLING-10066: -- Assignee: Timothée Maret > cleanup logging for content distribution >

[jira] [Commented] (SLING-9999) Remove cyclic dependency between scripting and servlets features

2021-01-18 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267234#comment-17267234 ] Oliver Lietz commented on SLING-: - [~radu], [~karlpauls], Again, the new dependency added

[jira] [Commented] (SLING-9983) Add support for predefined date format styles

2021-01-18 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267148#comment-17267148 ] Konrad Windszus commented on SLING-9983: [~radu] Any comments from your side on the PRs? > Add

[jira] [Comment Edited] (SLING-10066) cleanup logging for content distribution

2021-01-18 Thread Jira
[ https://issues.apache.org/jira/browse/SLING-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267063#comment-17267063 ] Jörg Hoh edited comment on SLING-10066 at 1/18/21, 8:14 AM: Hi Timothee,

[jira] [Commented] (SLING-10066) cleanup logging for content distribution

2021-01-18 Thread Jira
[ https://issues.apache.org/jira/browse/SLING-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267063#comment-17267063 ] Jörg Hoh commented on SLING-10066: -- Hi Timothee, ok, then it will be message 2 and 3. I will open a

[jira] [Updated] (SLING-10066) cleanup logging for content distribution

2021-01-18 Thread Jira
[ https://issues.apache.org/jira/browse/SLING-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jörg Hoh updated SLING-10066: - Description: When submitting content for distribution I get these 4 log entries for a single