[GitHub] [sling-org-apache-sling-feature-cpconverter] cziegeler commented on a change in pull request #70: SLING-10127 optionally emit converted content packages to dedicated folder

2021-04-13 Thread GitBox
cziegeler commented on a change in pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#discussion_r612944561 ## File path: src/main/java/org/apache/sling/feature/cpconverter/artifacts/LocalMavenRepositoryArtifactsDeployer.java

Re: Release of Servlets Resolver and Scripting bundles

2021-04-13 Thread Carsten Ziegeler
Am 14.04.2021 um 00:09 schrieb Oliver Lietz: I don't get the eventing example. Resources are a substantial part of Sling and defined in Sling API. Sling API bundle already contains several utils around Resource (and HTTP Request/Response and Scripting). Resource and Resource Type are very

Re: Release of Servlets Resolver and Scripting bundles

2021-04-13 Thread Oliver Lietz
On Tuesday, 13 April 2021 15:08:25 CEST Carsten Ziegeler wrote: > Am 13.04.2021 um 14:35 schrieb Oliver Lietz: > > On Tuesday, 13 April 2021 08:03:02 CEST Carsten Ziegeler wrote: > > > > IMHO Resource versioning is now a common practice is Sling/AEM projects. > > I strongly suggest keeping API

[GitHub] [sling-org-apache-sling-feature-launcher] enapps-enorman commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
enapps-enorman commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612790461 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -174,8 +179,9 @@ protected static

[GitHub] [sling-org-apache-sling-feature-launcher] enapps-enorman commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
enapps-enorman commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612785693 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -174,8 +179,9 @@ protected static

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
stbischof commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612749947 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -174,8 +179,9 @@ protected static void

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
stbischof commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612753232 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -174,8 +179,9 @@ protected static void

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
stbischof commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612753232 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -174,8 +179,9 @@ protected static void

[GitHub] [sling-org-apache-sling-servlets-get] sonarcloud[bot] commented on pull request #6: SLING-10303 update to parent pom 41, other version updates, add testcases

2021-04-13 Thread GitBox
sonarcloud[bot] commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/6#issuecomment-819036352 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-get=6=false=BUG)

[jira] [Updated] (SLING-10303) Improve test coverage of StreamRenderer

2021-04-13 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-10303: -- Description: * Add some test coverage to the StreamRenderer * Update dependencies

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
stbischof commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612753232 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -174,8 +179,9 @@ protected static void

[jira] [Resolved] (SLING-10295) Unclosed inpustreams with DefaultGetServlet

2021-04-13 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-10295. --- Resolution: Resolved > Unclosed inpustreams with DefaultGetServlet >

[GitHub] [sling-org-apache-sling-servlets-get] joerghoh merged pull request #5: SLING-10295 fix stream leaks in StreamRenderer

2021-04-13 Thread GitBox
joerghoh merged pull request #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
stbischof commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612751774 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -264,20 +270,23 @@ protected static

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
stbischof commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612751195 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -264,20 +270,23 @@ protected static

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
stbischof commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612750717 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -174,8 +179,9 @@ protected static void

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
stbischof commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612749947 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -174,8 +179,9 @@ protected static void

[GitHub] [sling-org-apache-sling-feature-launcher] enapps-enorman commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
enapps-enorman commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612720295 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -264,20 +270,23 @@ protected

Re: [VOTE] Release Apache Sling Resource Resolver 1.7.4

2021-04-13 Thread Jörg Hoh
Thanks Stefan! +1 Jörg Am Mo., 12. Apr. 2021 um 22:22 Uhr schrieb Stefan Seifert : > Hi, > > Resource Resolver 1.7.4 (3 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12349581 > > Staging repository: >

Re: [VOTE] Release Apache Sling Event Support 4.2.18

2021-04-13 Thread Jörg Hoh
+1 Jörg Am Di., 13. Apr. 2021 um 15:45 Uhr schrieb Stefan Egli < stefane...@apache.org>: > Hi, > > We solved 4 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12350074 > > Staging repository: >

[GitHub] [sling-org-apache-sling-feature-launcher] enapps-enorman commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
enapps-enorman commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612721284 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -174,8 +179,9 @@ protected static

[jira] [Comment Edited] (SLING-10186) Enhance cli parsing on sling-feature-launcher

2021-04-13 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320503#comment-17320503 ] Eric Norman edited comment on SLING-10186 at 4/13/21, 8:08 PM: --- Below

[GitHub] [sling-org-apache-sling-servlets-get] sonarcloud[bot] removed a comment on pull request #5: SLING-10295 fix stream leaks in StreamRenderer

2021-04-13 Thread GitBox
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/5#issuecomment-818737715 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-servlets-get] sonarcloud[bot] commented on pull request #5: SLING-10295 fix stream leaks in StreamRenderer

2021-04-13 Thread GitBox
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/5#issuecomment-819015877 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-get=5=false=BUG)

[jira] [Commented] (SLING-10186) Enhance cli parsing on sling-feature-launcher

2021-04-13 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320503#comment-17320503 ] Eric Norman commented on SLING-10186: - Below would be my preference to maintain compatibility with

[GitHub] [sling-org-apache-sling-feature-launcher] enapps-enorman commented on a change in pull request #24: Fixes in cli options

2021-04-13 Thread GitBox
enapps-enorman commented on a change in pull request #24: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612718849 ## File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java ## @@ -264,20 +270,23 @@ protected

[GitHub] [sling-org-apache-sling-servlets-get] joerghoh opened a new pull request #6: SLING-10303 update to parent pom 41, other version updates, add testcases

2021-04-13 Thread GitBox
joerghoh opened a new pull request #6: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

Re: [VOTE] Release Apache Sling Resource Resolver 1.7.4

2021-04-13 Thread Eric Norman
+1 On Mon, Apr 12, 2021 at 1:22 PM Stefan Seifert wrote: > Hi, > > Resource Resolver 1.7.4 (3 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12349581 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2428/ > > You can use this UNIX

Re: [VOTE] Release Apache Sling Event Support 4.2.18

2021-04-13 Thread Eric Norman
+1 On Tue, Apr 13, 2021 at 6:45 AM Stefan Egli wrote: > Hi, > > We solved 4 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12350074 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2429/ > > You can use this UNIX

[jira] [Resolved] (SLING-10294) Committer CLI - Return Codes

2021-04-13 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-10294. -- Resolution: Fixed Fixed in ecbe0d7aef0c6a15a1f1a5b9bda144d18473801e > Committer CLI - Return Codes >

[jira] [Closed] (SLING-10294) Committer CLI - Return Codes

2021-04-13 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-10294. > Committer CLI - Return Codes > > > Key: SLING-10294 >

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #70: SLING-10127 optionally emit converted content packages to dedicated folder

2021-04-13 Thread GitBox
kwin commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818872856 I exposed now three options for the `contenttypepackagepolicy` in

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #70: SLING-10127 optionally emit converted content packages to dedicated folder

2021-04-13 Thread GitBox
sonarcloud[bot] removed a comment on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818516185 SonarCloud Quality Gate failed.

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #70: SLING-10127 optionally emit converted content packages to dedicated folder

2021-04-13 Thread GitBox
sonarcloud[bot] commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818872564 Kudos, SonarCloud Quality Gate passed!

Re: [git] New git repository - org-apache-sling-auth-saml2

2021-04-13 Thread Cris Rockwell
Thank you, Robert. I look forward to the new repo, and discussing the project’s use of the Shibboleth repository and it’s dependencies. Cris > On Apr 13, 2021, at 6:40 AM, Robert Munteanu wrote: > > Hi Cris, > > Overall this looks good, I'll create a repo later this week unless > someone

[jira] [Created] (SLING-10304) Missing documentation for delete user and delete service user

2021-04-13 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10304: Summary: Missing documentation for delete user and delete service user Key: SLING-10304 URL: https://issues.apache.org/jira/browse/SLING-10304 Project: Sling

RE: [VOTE] Release Apache Sling JUnit Core 1.1.2

2021-04-13 Thread Stefan Seifert
>As per the Release Management doc [0], any PMC member is requested to >kindly copy this release to the Sling dist directory >and promote the artifacts to the central Maven repository. sling dist updated with rev. 47038 you can continue with the other steps (including promotion to maven

Re: [VOTE] Release Apache Sling JUnit Core 1.1.2

2021-04-13 Thread Cris Rockwell
Hi, The vote has passed with the following result : +1 (binding): Dan Klco Stefan Seifert Robert Munteanu +1 (non binding): Andreas Schaefer Henry Saginor As per the Release Management doc [0], any PMC member is requested to kindly copy this release to the Sling dist directory and promote

Re: [VOTE] Release Apache Sling Event Support 4.2.18

2021-04-13 Thread Carsten Ziegeler
+1 Carsten Am 13.04.2021 um 15:45 schrieb Stefan Egli: Hi, We solved 4 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12350074 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2429/ You can use this UNIX script to download

RE: [VOTE] Release Apache Sling Event Support 4.2.18

2021-04-13 Thread Stefan Seifert
+1 stefan

[VOTE] Release Apache Sling Event Support 4.2.18

2021-04-13 Thread Stefan Egli
Hi, We solved 4 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12350074 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2429/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Updated] (SLING-10120) Upgrade event to parent 41 [was: Upgrade event to parent 40]

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-10120: Fix Version/s: (was: Event 4.2.16) Event 4.2.18 > Upgrade event to parent

[jira] [Updated] (SLING-9906) Avoid retrying to load jobs if classes are missing

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-9906: --- Fix Version/s: (was: Event 4.2.16) Event 4.2.18 > Avoid retrying to load jobs

[jira] [Updated] (SLING-7756) Improve logging for Job retries

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-7756: --- Fix Version/s: (was: Event 4.2.16) Event 4.2.18 > Improve logging for Job

[jira] [Updated] (SLING-8295) Enable CodeCoverage extraction form pax exam ITs in sling.event

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-8295: --- Fix Version/s: (was: Event 4.2.18) Event 4.2.20 > Enable CodeCoverage

[jira] [Updated] (SLING-9905) Provide option to include sling instance id nodes in cleanup

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-9905: --- Fix Version/s: (was: Event 4.2.18) Event 4.2.20 > Provide option to include

[jira] [Resolved] (SLING-10300) fix maven dependencies in sling.event

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved SLING-10300. - Resolution: Fixed > fix maven dependencies in sling.event >

[GitHub] [sling-org-apache-sling-servlets-get] sonarcloud[bot] removed a comment on pull request #5: SLING-10295 fix stream leaks in StreamRenderer

2021-04-13 Thread GitBox
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/5#issuecomment-817993597 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-get=5=false=BUG)

[GitHub] [sling-org-apache-sling-servlets-get] sonarcloud[bot] commented on pull request #5: SLING-10295 fix stream leaks in StreamRenderer

2021-04-13 Thread GitBox
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/5#issuecomment-818737715 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-get=5=false=BUG)

[jira] [Created] (SLING-10303) Improve test coverage of StreamRenderer

2021-04-13 Thread Joerg Hoh (Jira)
Joerg Hoh created SLING-10303: - Summary: Improve test coverage of StreamRenderer Key: SLING-10303 URL: https://issues.apache.org/jira/browse/SLING-10303 Project: Sling Issue Type: Improvement

[GitHub] [sling-org-apache-sling-event] stefan-egli merged pull request #11: SLING-10300 : fix duplicate dependencies and versions

2021-04-13 Thread GitBox
stefan-egli merged pull request #11: URL: https://github.com/apache/sling-org-apache-sling-event/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

Re: Release of Servlets Resolver and Scripting bundles

2021-04-13 Thread Carsten Ziegeler
Am 13.04.2021 um 14:35 schrieb Oliver Lietz: On Tuesday, 13 April 2021 08:03:02 CEST Carsten Ziegeler wrote: IMHO Resource versioning is now a common practice is Sling/AEM projects. I strongly suggest keeping API and helpers/utils in a single place (as we have done it so far) instead of

[GitHub] [sling-org-apache-sling-event] kwin commented on a change in pull request #11: SLING-10300 : fix duplicate dependencies and versions

2021-04-13 Thread GitBox
kwin commented on a change in pull request #11: URL: https://github.com/apache/sling-org-apache-sling-event/pull/11#discussion_r612414931 ## File path: pom.xml ## @@ -195,17 +195,14 @@ org.osgi osgi.core -6.0.0

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre

2021-04-13 Thread GitBox
sonarcloud[bot] commented on pull request #26: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-818708442 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof opened a new pull request #26: container: adoptopenjdk/openjdk11:alpine-jre

2021-04-13 Thread GitBox
stbischof opened a new pull request #26: URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26 switch from slim to jre because it is smalle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #21: SLING-10289 fix array configuration

2021-04-13 Thread GitBox
sonarcloud[bot] commented on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/21#issuecomment-818707289 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-dynamic-include] AndreasWurm opened a new pull request #21: SLING-10289 fix array configuration

2021-04-13 Thread GitBox
AndreasWurm opened a new pull request #21: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/21 extended ConfigurationTest to verify multiple values work and changed the AttributeDefinitions to String Arrays -- This is an automated message from the Apache Git

[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image

2021-04-13 Thread Stefan Bischof (Jira)
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320143#comment-17320143 ] Stefan Bischof commented on SLING-10229: They have the version number fixes in the Dockerfile

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on a change in pull request #11: SLING-10300 : fix duplicate dependencies and versions

2021-04-13 Thread GitBox
stefan-egli commented on a change in pull request #11: URL: https://github.com/apache/sling-org-apache-sling-event/pull/11#discussion_r612408343 ## File path: pom.xml ## @@ -195,17 +195,14 @@ org.osgi osgi.core -6.0.0

[jira] [Created] (SLING-10302) Tidy up sling.event pom

2021-04-13 Thread Stefan Egli (Jira)
Stefan Egli created SLING-10302: --- Summary: Tidy up sling.event pom Key: SLING-10302 URL: https://issues.apache.org/jira/browse/SLING-10302 Project: Sling Issue Type: Task Components:

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-13 Thread GitBox
karlpauls commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818702640 > That is where we don't agree. I don't see a good use case for that (even if it the current status quo). Can you give one? I'm not sure

[GitHub] [sling-org-apache-sling-dynamic-include] santiagozky commented on pull request #19: Extend the IncludeGenerator interface with the Sling Request

2021-04-13 Thread GitBox
santiagozky commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-818701825 thank you @rombert -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: Release of Servlets Resolver and Scripting bundles

2021-04-13 Thread Oliver Lietz
On Tuesday, 13 April 2021 08:03:02 CEST Carsten Ziegeler wrote: > I tend to agree that there is not that much value in moving this to the > api. I don't see any use cases for users of Sling's resource api to also > use this class. > > Apart from the reasons mentioned, ResourceType talks about

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #73: SLING-10286 : Converter ignores disabled status of system user

2021-04-13 Thread GitBox
sonarcloud[bot] commented on pull request #73: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/73#issuecomment-818697480 Kudos, SonarCloud Quality Gate passed!

[jira] [Assigned] (SLING-10286) Converter ignores disabled status of system user

2021-04-13 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber reassigned SLING-10286: Assignee: Angela Schreiber > Converter ignores disabled status of system user >

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela opened a new pull request #73: SLING-10286 : Converter ignores disabled status of system user

2021-04-13 Thread GitBox
anchela opened a new pull request #73: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/73 @karlpauls , i would appreciate if you had time to take a look at the suggested fix. nothing urgent and it's probably a minor bug but if the converter is expected to

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on a change in pull request #11: SLING-10300 : fix duplicate dependencies and versions

2021-04-13 Thread GitBox
stefan-egli commented on a change in pull request #11: URL: https://github.com/apache/sling-org-apache-sling-event/pull/11#discussion_r612396444 ## File path: pom.xml ## @@ -195,17 +195,14 @@ org.osgi osgi.core -6.0.0

[jira] [Resolved] (SLING-10301) Use Apache Sling Bundle Parent 41

2021-04-13 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-10301. -- Resolution: Fixed Fixed in [commit

[jira] [Created] (SLING-10301) Use Apache Sling Bundle Parent 41

2021-04-13 Thread Radu Cotescu (Jira)
Radu Cotescu created SLING-10301: Summary: Use Apache Sling Bundle Parent 41 Key: SLING-10301 URL: https://issues.apache.org/jira/browse/SLING-10301 Project: Sling Issue Type: Improvement

[jira] [Updated] (SLING-10299) Allow for removal of access control policies (not just individual entries)

2021-04-13 Thread Angela Schreiber (Jira)
[ https://issues.apache.org/jira/browse/SLING-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Angela Schreiber updated SLING-10299: - Description: hi [~bdelacretaz], as outline in SLING-10134 the ability to cleanup access

[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on pull request #20: Moving the JS calling part into the DIV, thus it get replaced after d…

2021-04-13 Thread GitBox
rombert commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/20#issuecomment-818677827 Thanks for the PR @maximilianvoss . As this is a non-trivial fix, can you please file an issue in the Sling Jira -

[jira] [Updated] (SLING-10096) Allow the SlingHttpServletRequest in the IncludeGenerator or Sling dynamic includes

2021-04-13 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-10096: Fix Version/s: Dynamic Include 3.2.2 > Allow the SlingHttpServletRequest in the

[jira] [Resolved] (SLING-10096) Allow the SlingHttpServletRequest in the IncludeGenerator or Sling dynamic includes

2021-04-13 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-10096. - Assignee: Robert Munteanu Resolution: Fixed Fixed in

[GitHub] [sling-org-apache-sling-dynamic-include] rombert merged pull request #19: Extend the IncludeGenerator interface with the Sling Request

2021-04-13 Thread GitBox
rombert merged pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [sling-org-apache-sling-event] stefan-egli commented on a change in pull request #11: SLING-10300 : fix duplicate dependencies and versions

2021-04-13 Thread GitBox
stefan-egli commented on a change in pull request #11: URL: https://github.com/apache/sling-org-apache-sling-event/pull/11#discussion_r612362361 ## File path: pom.xml ## @@ -195,17 +195,14 @@ org.osgi osgi.core -6.0.0

[GitHub] [sling-org-apache-sling-event] kwin commented on a change in pull request #11: SLING-10300 : fix duplicate dependencies and versions

2021-04-13 Thread GitBox
kwin commented on a change in pull request #11: URL: https://github.com/apache/sling-org-apache-sling-event/pull/11#discussion_r612337111 ## File path: pom.xml ## @@ -195,17 +195,14 @@ org.osgi osgi.core -6.0.0

[jira] [Commented] (SLING-10300) fix maven dependencies in sling.event

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320072#comment-17320072 ] Stefan Egli commented on SLING-10300: - *

[GitHub] [sling-org-apache-sling-event] stefan-egli opened a new pull request #11: SLING-10300 : fix duplicate dependencies and versions

2021-04-13 Thread GitBox
stefan-egli opened a new pull request #11: URL: https://github.com/apache/sling-org-apache-sling-event/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

Re: [git] New git repository - org-apache-sling-auth-saml2

2021-04-13 Thread Robert Munteanu
Hi Cris, Overall this looks good, I'll create a repo later this week unless someone objects. Note that we still need to clarify the status of the additional Maven artifact repository [1] and probably need to review the deps (there are lots of them) before starting a release. But that's for

Re: [VOTE] Release Apache Sling JUnit Core 1.1.2

2021-04-13 Thread Robert Munteanu
On Fri, 2021-04-09 at 12:12 -0400, Cris Rockwell wrote: > Please vote to approve these releases: +1 Robert signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Resource Resolver 1.7.4

2021-04-13 Thread Robert Munteanu
On Mon, 2021-04-12 at 20:22 +, Stefan Seifert wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image

2021-04-13 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320067#comment-17320067 ] Robert Munteanu commented on SLING-10229: - Hi [~bisch...@jena.de]. Sorry for the delay, I hope

[GitHub] [sling-org-apache-sling-jcr-base] rombert commented on pull request #4: SLING-9821 - Fix Error message points to non-existing method

2021-04-13 Thread GitBox
rombert commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/4#issuecomment-818624332 Hi @valtsu3000 and thanks for the PR! I see a couple of unrelated changes, it would be good to remove them from the PR: - we don't use GitHub actions

[jira] [Assigned] (SLING-10300) fix maven dependencies in sling.event

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli reassigned SLING-10300: --- Assignee: Stefan Egli > fix maven dependencies in sling.event >

[CANCEL][VOTE] Release Apache Sling Event Support 4.2.16

2021-04-13 Thread Stefan Egli
Ok, let me cancel the release Cheers, Stefan On 13.04.21 12:10, Stefan Seifert wrote: hmm, those inconsistencies were newly introduced with the latest version. although the one has "provided" scope and the other "test" scope, it has effect on the package version selected by the bnd plugin for

RE: [VOTE] Release Apache Sling Event Support 4.2.16

2021-04-13 Thread Stefan Seifert
hmm, those inconsistencies were newly introduced with the latest version. although the one has "provided" scope and the other "test" scope, it has effect on the package version selected by the bnd plugin for depending on the service user mapper dependency. it seems to have picked automatically

Re: [VOTE] Release Apache Sling Event Support 4.2.16

2021-04-13 Thread Stefan Egli
Hi Stefan, Good point, I created SLING-10300 to follow up. What's your vote for 4.2.16? Cheers, Stefan On 12.04.21 22:41, Stefan Seifert wrote: the dependencies defined for the project are inconsistent - as reported by maven: [WARNING]

Re: [VOTE] Release Apache Sling Event Support 4.2.16

2021-04-13 Thread Stefan Egli
done now. Cheers, Stefan On 13.04.21 11:14, Konrad Windszus wrote: Please move all issues which have 4.2.14 as fix version to 4.2.16 and remove the cancelled version from JIRA. We don't use fix-versions against non-public releases. That makes it way easier for customers to understand which

[jira] [Updated] (SLING-7756) Improve logging for Job retries

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-7756: --- Fix Version/s: (was: Event 4.2.14) Event 4.2.16 > Improve logging for Job

[jira] [Updated] (SLING-9906) Avoid retrying to load jobs if classes are missing

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-9906: --- Fix Version/s: (was: Event 4.2.14) Event 4.2.16 > Avoid retrying to load jobs

[jira] [Created] (SLING-10300) fix maven dependencies in sling.event

2021-04-13 Thread Stefan Egli (Jira)
Stefan Egli created SLING-10300: --- Summary: fix maven dependencies in sling.event Key: SLING-10300 URL: https://issues.apache.org/jira/browse/SLING-10300 Project: Sling Issue Type: Task

[jira] [Updated] (SLING-10300) fix maven dependencies in sling.event

2021-04-13 Thread Stefan Egli (Jira)
[ https://issues.apache.org/jira/browse/SLING-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-10300: Fix Version/s: Event 4.2.18 > fix maven dependencies in sling.event >

[GitHub] [sling-org-apache-sling-jcr-base] sonarcloud[bot] commented on pull request #4: SLING-9821 - Fix Error message points to non-existing method

2021-04-13 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/4#issuecomment-818597691 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-base=4=false=BUG)

[GitHub] [sling-org-apache-sling-jcr-base] valtsu3000 opened a new pull request #4: SLING-9821 - Fix Error message points to non-existing method

2021-04-13 Thread GitBox
valtsu3000 opened a new pull request #4: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/4 This pull request was made for a mandatory school project https://issues.apache.org/jira/browse/SLING-9821 -- This is an automated message from the Apache Git Service. To

Re: [VOTE] Release Apache Sling Event Support 4.2.16

2021-04-13 Thread Konrad Windszus
Please move all issues which have 4.2.14 as fix version to 4.2.16 and remove the cancelled version from JIRA. We don't use fix-versions against non-public releases. That makes it way easier for customers to understand which version is necessary for the fix. Konrad > On 12. Apr 2021, at 17:26,

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-13 Thread GitBox
kwin commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818567126 bq. I think we should as a first step expose that as an option. That is where we don't agree. I don't see a good use case for that (even if

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin edited a comment on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-13 Thread GitBox
kwin edited a comment on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818567126 > I think we should as a first step expose that as an option. That is where we don't agree. I don't see a good use case for that (even

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #70: SLING-10127 emit all converted packages to the local Maven repository

2021-04-13 Thread GitBox
karlpauls commented on pull request #70: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#issuecomment-818563923 @kwin, right. So the current behavior is to never reference "content" content packages and never write them. I think we should as a first step

[jira] [Created] (SLING-10299) Allow for removal of access control policies (not just individual entries)

2021-04-13 Thread Angela Schreiber (Jira)
Angela Schreiber created SLING-10299: Summary: Allow for removal of access control policies (not just individual entries) Key: SLING-10299 URL: https://issues.apache.org/jira/browse/SLING-10299

[jira] [Created] (SLING-10298) Record origins for configurations and bundles

2021-04-13 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-10298: Summary: Record origins for configurations and bundles Key: SLING-10298 URL: https://issues.apache.org/jira/browse/SLING-10298 Project: Sling Issue

  1   2   >