Re: [VOTE] Release Apache Sling Bundle Resource Provider version 2.3.4

2021-04-23 Thread Daniel Klco
+1 On Fri, Apr 23, 2021 at 2:03 PM Eric Norman wrote: > +1 > > On Fri, Apr 23, 2021 at 11:02 AM Eric Norman wrote: > > > Hi, > > > > We solved 2 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12349706 > > > > Staging repository: > >

Re: [VOTE] Release Apache Sling Scripting SPI 1.0.2

2021-04-23 Thread Daniel Klco
+1 On Fri, Apr 23, 2021 at 2:03 PM Eric Norman wrote: > +1 > > On Fri, Apr 23, 2021 at 8:21 AM Radu Cotescu wrote: > > > Hi, > > > > We solved 3 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12349958 > > > > Staging repository: > >

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #74: SLING-10243 extract Sling-Initial-Content

2021-04-23 Thread GitBox
sonarcloud[bot] commented on pull request #74: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#issuecomment-826023026 SonarCloud Quality Gate failed.

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #74: SLING-10243 extract Sling-Initial-Content

2021-04-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #74: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#issuecomment-824047400 SonarCloud Quality Gate failed.

Re: SAML auth handler and additional Maven repo (was: [git] New git repository - org-apache-sling-auth-saml2)

2021-04-23 Thread Cris Rockwell
Hi Robert There are a few things the Shibboleth devs wanted to reinforce with me. A) They don’t upload artifacts to Maven Central. The canonical way to get their latest libraries is through the Shibboleth repo. The v4.0.1 was uploaded to Central by other parties, and they don't know anything

[jira] [Assigned] (SLING-10327) SlingAdaptable: simplify getAdapter()

2021-04-23 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-10327: - Assignee: Joerg Hoh > SlingAdaptable: simplify getAdapter() >

[jira] [Comment Edited] (SLING-8759) Replace the SlingAdaptable.adapterCache with a ConcurrentMap

2021-04-23 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331018#comment-17331018 ] Joerg Hoh edited comment on SLING-8759 at 4/23/21, 8:32 PM: I created

[jira] [Commented] (SLING-8759) Replace the SlingAdaptable.adapterCache with a ConcurrentMap

2021-04-23 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331018#comment-17331018 ] Joerg Hoh commented on SLING-8759: -- I created SLING-10327 to handle the refactoring of getAdapter(), so

[jira] [Created] (SLING-10327) SlingAdaptable: simplify getAdapter()

2021-04-23 Thread Joerg Hoh (Jira)
Joerg Hoh created SLING-10327: - Summary: SlingAdaptable: simplify getAdapter() Key: SLING-10327 URL: https://issues.apache.org/jira/browse/SLING-10327 Project: Sling Issue Type: Improvement

[jira] [Commented] (SLING-8759) Replace the SlingAdaptable.adapterCache with a ConcurrentMap

2021-04-23 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331014#comment-17331014 ] Joerg Hoh commented on SLING-8759: -- You are right. But: Is a ConcurrentMap really necessary here? * I

Re: [VOTE] Release Apache Sling Bundle Resource Provider version 2.3.4

2021-04-23 Thread Eric Norman
+1 On Fri, Apr 23, 2021 at 11:02 AM Eric Norman wrote: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12349706 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2434/ > > You can use this UNIX

Re: [VOTE] Release Apache Sling Scripting SPI 1.0.2

2021-04-23 Thread Eric Norman
+1 On Fri, Apr 23, 2021 at 8:21 AM Radu Cotescu wrote: > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12349958 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2433/ > > You can use this UNIX

[VOTE] Release Apache Sling Bundle Resource Provider version 2.3.4

2021-04-23 Thread Eric Norman
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12349706 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2434/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Commented] (SLING-10141) Update to Sling Bundle Parent 41

2021-04-23 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330895#comment-17330895 ] Eric Norman commented on SLING-10141: - Updated from parent 40 to parent 41 at: 

[jira] [Updated] (SLING-10141) Update to Sling Bundle Parent 41

2021-04-23 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-10141: Description: Update to Sling Bundle Parent 41 (was: Update to Sling Bundle Parent 40) > Update

[jira] [Updated] (SLING-10141) Update to Sling Bundle Parent 41

2021-04-23 Thread Eric Norman (Jira)
[ https://issues.apache.org/jira/browse/SLING-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-10141: Summary: Update to Sling Bundle Parent 41 (was: Update to Sling Bundle Parent 40) > Update to

[jira] [Commented] (SLING-10118) Fully cache the GraphQLSchema objects

2021-04-23 Thread Jira
[ https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330880#comment-17330880 ] Thierry Ygé commented on SLING-10118: - [~bdelacretaz] in our tests, caching the schema help to

Re: SAML auth handler and additional Maven repo (was: [git] New git repository - org-apache-sling-auth-saml2)

2021-04-23 Thread Cris Rockwell
Ok Thanks for the clarification. Let me take a bit of time to review the hashes. For example, comparing this https://build.shibboleth.net/nexus/content/groups/public/org/opensaml/opensaml-xmlsec-impl/4.0.1/opensaml-xmlsec-impl-4.0.1.jar.sha1 to this

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-04-23 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-825731798 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-04-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-825619009 SonarCloud Quality Gate failed.

[VOTE] Release Apache Sling Scripting SPI 1.0.2

2021-04-23 Thread Radu Cotescu
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12349958 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2433/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Comment Edited] (SLING-10118) Fully cache the GraphQLSchema objects

2021-04-23 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330813#comment-17330813 ] Bertrand Delacretaz edited comment on SLING-10118 at 4/23/21, 3:16 PM:

CFP for ApacheCon 2021 closes in ONE WEEK

2021-04-23 Thread Rich Bowen
[You are receiving this because you're subscribed to one or more dev@ mailing lists for an Apache project, or the ApacheCon Announce list.] Time is running out to submit your talk for ApacheCon 2021. The Call for Presentations for ApacheCon @Home 2021, focused on Europe and North America time

[jira] [Reopened] (SLING-8759) Replace the SlingAdaptable.adapterCache with a ConcurrentMap

2021-04-23 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reopened SLING-8759: [~joerghoh] - I don't think this is solved as proposed - there is no ConcurrentMap usage. I

SAML auth handler and additional Maven repo (was: [git] New git repository - org-apache-sling-auth-saml2)

2021-04-23 Thread Robert Munteanu
Hi Cris, On Fri, 2021-04-23 at 09:31 -0400, Cris Rockwell wrote: > The OpenSAML library was selected because of the support the Shibboleth > Consortium has within higher education[0]. > My institution is a member of the consortium. I am confident about the > ongoing support the project has and

[jira] [Comment Edited] (SLING-10118) Fully cache the GraphQLSchema objects

2021-04-23 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330813#comment-17330813 ] Bertrand Delacretaz edited comment on SLING-10118 at 4/23/21, 2:26 PM:

[jira] [Commented] (SLING-10118) Fully cache the GraphQLSchema objects

2021-04-23 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330813#comment-17330813 ] Bertrand Delacretaz commented on SLING-10118: - Thank you for the clarification, I understand

[jira] [Comment Edited] (SLING-10118) Fully cache the GraphQLSchema objects

2021-04-23 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330813#comment-17330813 ] Bertrand Delacretaz edited comment on SLING-10118 at 4/23/21, 2:23 PM:

[jira] [Resolved] (SLING-10308) Sling Dynamic Include - Changing the resulting DOM for JSI

2021-04-23 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-10308. -- Resolution: Fixed Resolved in

[jira] [Updated] (SLING-10118) Fully cache the GraphQLSchema objects

2021-04-23 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-10118: Summary: Fully cache the GraphQLSchema objects (was: Fully cache GraphQLSchema)

[jira] [Assigned] (SLING-10308) Sling Dynamic Include - Changing the resulting DOM for JSI

2021-04-23 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-10308: Assignee: Dan Klco > Sling Dynamic Include - Changing the resulting DOM for JSI >

[GitHub] [sling-org-apache-sling-dynamic-include] klcodanr merged pull request #20: Moving the JS calling part into the DIV, thus it get replaced after d…

2021-04-23 Thread GitBox
klcodanr merged pull request #20: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

Re: [git] New git repository - org-apache-sling-auth-saml2

2021-04-23 Thread Cris Rockwell
Hi Robert Regarding "Note that we still need to clarify the status of the additional Maven artifact repository [1] and probably need to review the deps (there are lots of them) before starting a release. But that's for later." I aware there are many dependencies in this project [1]:

Re: Releasing new Sling API?

2021-04-23 Thread Jörg Hoh
Hi, The only outstanding issue is SLING-8742, for which Robert mentioned, that he won't work on it. The remaining ones are resolved. If there's no objection in the next days, I would like to try my very first release for Sling API 2.23.4 next week. Jörg Am Di., 6. Apr. 2021 um 11:59 Uhr

[jira] [Resolved] (SLING-8759) Replace the SlingAdaptable.adapterCache with a ConcurrentMap

2021-04-23 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-8759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh resolved SLING-8759. -- Resolution: Fixed > Replace the SlingAdaptable.adapterCache with a ConcurrentMap >

Re: Sling Declarative Dynamic Resources

2021-04-23 Thread Ruben Reusser
Carsten, I think I understand your security concern - do you see another way to solve this in that case? Ruben On 4/22/2021 10:31 PM, Carsten Ziegeler wrote: Thanks Ruben, in my opinion /apps belongs to developers. In our case its immutable for good reasons. Drilling a hole into this and

[jira] [Comment Edited] (SLING-10118) Fully cache GraphQLSchema

2021-04-23 Thread Jira
[ https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330416#comment-17330416 ] Thierry Ygé edited comment on SLING-10118 at 4/23/21, 12:19 PM:

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-04-23 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-825619009 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-04-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-825121992 SonarCloud Quality Gate failed.

[jira] [Commented] (SLING-10118) Fully cache GraphQLSchema

2021-04-23 Thread Jira
[ https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330416#comment-17330416 ] Thierry Ygé commented on SLING-10118: - [~bdelacretaz] the current implementation is not fully

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #18: SLING-10118 Fully cache GraphQLSchema

2021-04-23 Thread GitBox
bdelacretaz commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/18#issuecomment-825616000 Before reviewing this, I have asked clarification questions in SLING-10118 as I don't really understand what this aims to fix. -- This is an

[jira] [Commented] (SLING-10118) Fully cache GraphQLSchema

2021-04-23 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17330414#comment-17330414 ] Bertrand Delacretaz commented on SLING-10118: - bq. in SLING-10085 the GraphQLSchema couldn't

[GitHub] [sling-org-apache-sling-api] joerghoh merged pull request #26: SLING-8759 use computeIfAbsent to reduce code size

2021-04-23 Thread GitBox
joerghoh merged pull request #26: URL: https://github.com/apache/sling-org-apache-sling-api/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #26: SLING-8759 use computeIfAbsent to reduce code size

2021-04-23 Thread GitBox
sonarcloud[bot] commented on pull request #26: URL: https://github.com/apache/sling-org-apache-sling-api/pull/26#issuecomment-825614326 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=26=false=BUG)

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] removed a comment on pull request #26: SLING-8759 use computeIfAbsent to reduce code size

2021-04-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #26: URL: https://github.com/apache/sling-org-apache-sling-api/pull/26#issuecomment-821067059 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=26=false=BUG)

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on a change in pull request #18: SLING-10118 Fully cache GraphQLSchema

2021-04-23 Thread GitBox
raducotescu commented on a change in pull request #18: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/18#discussion_r619019334 ## File path: src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java ## @@ -147,8 +147,8 @@ public

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #18: SLING-10118 Fully cache GraphQLSchema

2021-04-23 Thread GitBox
sonarcloud[bot] commented on pull request #18: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/18#issuecomment-825558716 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=18=false=BUG)

[jira] [Updated] (SLING-10326) Include scheduled jobs for sling jobs inventory printer

2021-04-23 Thread Natalia Angulo Herrera (Jira)
[ https://issues.apache.org/jira/browse/SLING-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natalia Angulo Herrera updated SLING-10326: --- Issue Type: Improvement (was: Bug) > Include scheduled jobs for sling jobs

[jira] [Updated] (SLING-10326) Include scheduled jobs for sling jobs inventory printer

2021-04-23 Thread Natalia Angulo Herrera (Jira)
[ https://issues.apache.org/jira/browse/SLING-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natalia Angulo Herrera updated SLING-10326: --- Issue Type: Bug (was: Improvement) > Include scheduled jobs for sling jobs

[jira] [Updated] (SLING-10326) Include scheduled jobs for sling jobs inventory printer

2021-04-23 Thread Natalia Angulo Herrera (Jira)
[ https://issues.apache.org/jira/browse/SLING-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Natalia Angulo Herrera updated SLING-10326: --- Component/s: Feature InventoryPrinters > Include scheduled jobs for sling

[jira] [Created] (SLING-10326) Include scheduled jobs for sling jobs inventory printer

2021-04-23 Thread Natalia Angulo Herrera (Jira)
Natalia Angulo Herrera created SLING-10326: -- Summary: Include scheduled jobs for sling jobs inventory printer Key: SLING-10326 URL: https://issues.apache.org/jira/browse/SLING-10326 Project:

[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on pull request #20: Moving the JS calling part into the DIV, thus it get replaced after d…

2021-04-23 Thread GitBox
rombert commented on pull request #20: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/20#issuecomment-825472107 Code overall LGTM but it is way out of my area of expertise regarding dynamic includes . @klcodanr - maybe you can review? -- This is an

[jira] [Resolved] (SLING-10289) Sling Dynamic Include 3.2.0 configuration of arrays broken

2021-04-23 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-10289. - Assignee: Robert Munteanu Resolution: Fixed Merged, thanks [~AndreasWurm]! >

[GitHub] [sling-org-apache-sling-dynamic-include] rombert merged pull request #21: SLING-10289 fix array configuration

2021-04-23 Thread GitBox
rombert merged pull request #21: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on pull request #21: SLING-10289 fix array configuration

2021-04-23 Thread GitBox
rombert commented on pull request #21: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/21#issuecomment-825470592 Merged, thanks for the contribution @AndreasWurm ! -- This is an automated message from the Apache Git Service. To respond to the message, please