[GitHub] [sling-org-apache-sling-resourceresolver] Gabiesfat opened a new pull request #50: SLING-10844: ResourceMapper.getMapping() returns null for empty path

2021-10-16 Thread GitBox
Gabiesfat opened a new pull request #50: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/50 This PR has the code changes for issue SLING-10844. Apparently earlier implementation of API getMapping() in ResourceMapperImpl.java was returning null in case the path

[jira] [Commented] (SLING-10844) ResourceMapper.getMapping() returns null for empty path

2021-10-16 Thread Aditya Seth (Jira)
[ https://issues.apache.org/jira/browse/SLING-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429620#comment-17429620 ] Aditya Seth commented on SLING-10844: - PR raised: 

Re: Cache objects retrieved/derived from a ResourceResolver

2021-10-16 Thread Paul Bjorkstrand
On Sat, Oct 16, 2021 at 9:42 AM Jörg Hoh wrote: > Hi Carsten, > > Am Sa., 16. Okt. 2021 um 09:41 Uhr schrieb Carsten Ziegeler < > cziege...@apache.org>: > > > I don't think that the RR is the right place for this. > > > > If the use case is that during a request the exact same query is > >

Re: Cache objects retrieved/derived from a ResourceResolver

2021-10-16 Thread Jörg Hoh
Hi Carsten, Am Sa., 16. Okt. 2021 um 09:41 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > I don't think that the RR is the right place for this. > > If the use case is that during a request the exact same query is > executed more than once, then caching the result of the query in Sling

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #709 is BROKEN

2021-10-16 Thread Apache Jenkins Server
--- [INFO] Total time: 04:40 min [INFO] Finished at: 2021-10-16T11:33:30Z [INFO] ---- [INFO] [jenkins-event-spy] Generated /home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMaven90e8b06b/maven-spy-2

Re: Add builders to create request/response objects

2021-10-16 Thread Carsten Ziegeler
I've created an issue and did a first step at the implementation at https://issues.apache.org/jira/browse/SLING-10871 The api is based on what we have in servlet helpers today, with some fixes and minor changes. In addition I added some methods which allow to reuse parts of an existing

[jira] [Commented] (SLING-10871) Add builder API for request/resource objects

2021-10-16 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429526#comment-17429526 ] Carsten Ziegeler commented on SLING-10871: -- First implementation of builder api based on the

[jira] [Created] (SLING-10871) Add builder API for request/resource objects

2021-10-16 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-10871: Summary: Add builder API for request/resource objects Key: SLING-10871 URL: https://issues.apache.org/jira/browse/SLING-10871 Project: Sling Issue

[jira] [Closed] (SLING-8777) Sling activation bundle overrides default CommandMap with wrong type

2021-10-16 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-8777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-8777. --- > Sling activation bundle overrides default CommandMap with wrong type >

[VOTE RESULT] Release Apache Sling Javax Activation 0.3.0

2021-10-16 Thread Carsten Ziegeler
The vote passes with 6 binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org

Re: Cache objects retrieved/derived from a ResourceResolver

2021-10-16 Thread Carsten Ziegeler
But you can use adaptTo to retrieve your cache via an adapter factory. As Radu points out, those objects are cached/created once per Adaptable. This binds the lifetime of your cache to the lifetime of the Adaptable and you get what you need for free without any api additions. Carsten Am

Re: Cache objects retrieved/derived from a ResourceResolver

2021-10-16 Thread Carsten Ziegeler
I don't think that the RR is the right place for this. If the use case is that during a request the exact same query is executed more than once, then caching the result of the query in Sling is probably not resulting in the wanted gain. I think it is much better to avoid executing the query