[
https://issues.apache.org/jira/browse/SLING-9036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-9036:
--
Fix Version/s: Models Implementation 1.5.2
(was: Models Implementation
[
https://issues.apache.org/jira/browse/SLING-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-9674:
--
Fix Version/s: Models Implementation 1.5.2
(was: Models Implementation
[
https://issues.apache.org/jira/browse/SLING-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-10972:
---
Assignee: Konrad Windszus
> Testing Sling Mock Oak: Shade Guava
>
Hi Stefan,
yes, please include a release of org.apache.sling.models.validation-impl as
well.
Thanks,
Konrad
> On 7. Dec 2021, at 08:51, Stefan Seifert
> wrote:
>
> i plan to start the releases for those 3 bundles today.
>
> @konrad: should I also include a release for
>
i plan to start the releases for those 3 bundles today.
@konrad: should I also include a release for
org.apache.sling.models.validation-impl?
stefan
>-Original Message-
>From: Stefan Seifert
>Sent: Friday, December 3, 2021 3:00 PM
>To: dev@sling.apache.org
>Subject: sling models
[
https://issues.apache.org/jira/browse/SLING-8923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-8923:
--
Fix Version/s: (was: Models Implementation 1.5.0)
> Jackson Sling Model Exporter for
[
https://issues.apache.org/jira/browse/SLING-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10972:
Description:
All Oak bundles are already shaded in
[
https://issues.apache.org/jira/browse/SLING-10972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10972:
Description:
All Oak bundles are already shaded in
Konrad Windszus created SLING-10972:
---
Summary: Testing Sling Mock Oak: Shade Guava
Key: SLING-10972
URL: https://issues.apache.org/jira/browse/SLING-10972
Project: Sling
Issue Type:
[
https://issues.apache.org/jira/browse/SLING-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-10971.
Resolution: Fixed
[
https://issues.apache.org/jira/browse/SLING-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-10971:
---
Summary: caconfig-mock-plugin: Make dependency to
org.apache.sling.testing.sling-mock.core
Stefan Seifert created SLING-10971:
--
Summary: caconfig-mock-plugin
Key: SLING-10971
URL: https://issues.apache.org/jira/browse/SLING-10971
Project: Sling
Issue Type: Bug
Oliver Lietz created SLING-10970:
Summary: Update Karaf to 4.3.4
Key: SLING-10970
URL: https://issues.apache.org/jira/browse/SLING-10970
Project: Sling
Issue Type: Task
Components:
[
https://issues.apache.org/jira/browse/SLING-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454106#comment-17454106
]
Konrad Windszus edited comment on SLING-10969 at 12/6/21, 4:07 PM:
---
[
https://issues.apache.org/jira/browse/SLING-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-10969:
---
Assignee: Konrad Windszus
> Remove synchronized & rest of accessible flag during
[
https://issues.apache.org/jira/browse/SLING-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-10969.
-
Fix Version/s: Models Implementation 1.5.0
Resolution: Fixed
Fixed in
kwin merged pull request #29:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sonarcloud[bot] commented on pull request #29:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/29#issuecomment-986903203
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17454090#comment-17454090
]
Paul Bjorkstrand commented on SLING-10969:
--
[~sseifert], [~rombert], [~kwin]
PR:
paul-bjorkstrand opened a new pull request #29:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/29
Also, remove the original cause of SLING-6584, the "reset" of the
setAccessible flag.
--
This is an automated message from the Apache Git Service.
To respond to the
Paul Bjorkstrand created SLING-10969:
Summary: Remove synchronized & rest of accessible flag during
injection
Key: SLING-10969
URL: https://issues.apache.org/jira/browse/SLING-10969
Project:
Agreed, Konrad. That was the way I was going to approach it. I am adding
the "remove sync" ticket now, and will add the MethodHandles ticket after I
have the PR for sync removal in, since it is far simpler.
-Paul
On Mon, Dec 6, 2021 at 9:07 AM Konrad Windszus wrote:
> Maybe we can start with
Maybe we can start with the simple code by removing synchronized and reset.
Using MethodHandle should be treated separately (in a dedicated ticket and PR).
Konrad
> On 6. Dec 2021, at 16:03, Paul Bjorkstrand wrote:
>
> It may be possible to do that, by doing a reflective check on that method
It may be possible to do that, by doing a reflective check on that method
and calling that method reflectively (or via method handles, since it is
public). The code might be a bit complex, but I'll give it a go.
-Paul
On Mon, Dec 6, 2021 at 3:22 AM Robert Munteanu wrote:
> Hi Paul,
>
> On
[
https://issues.apache.org/jira/browse/SLING-10968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-10968:
--
Description:
Currently whenever a relevant change to the is detected, the configuration is
reloaded
[
https://issues.apache.org/jira/browse/SLING-10968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-10968:
--
Summary: Reduce reload events on content changes (was: Reduce aliasreload
events on content changes)
Joerg Hoh created SLING-10968:
-
Summary: Reduce aliasreload events on content changes
Key: SLING-10968
URL: https://issues.apache.org/jira/browse/SLING-10968
Project: Sling
Issue Type:
[
https://issues.apache.org/jira/browse/SLING-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17453939#comment-17453939
]
Carsten Ziegeler commented on SLING-10967:
--
Big +1 to this - its currently quiet ugly to use
[
https://issues.apache.org/jira/browse/SLING-9036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17453896#comment-17453896
]
Konrad Windszus commented on SLING-9036:
[~Henry Kuijpers] Can you come up with a failing test
[
https://issues.apache.org/jira/browse/SLING-10947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10947:
Fix Version/s: (was: Models Implementation 1.5.0)
> Sling Models Unit Tests do not
Hi,
We can still add a link to Feature Launcher or Kickstart Launcher as 2nd best
option for everyone who doesn't want to use Docker (for whatever reason). But I
am also +1 on primarily promoting Sling Starter Container.
Konrad
> On 4. Dec 2021, at 15:06, Carsten Ziegeler wrote:
>
> Hi,
>
>
joerghoh commented on a change in pull request #53:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#discussion_r762849659
##
File path:
src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverMetrics.java
##
@@ -0,0 +1,122 @@
+/*
+
Joerg Hoh created SLING-10967:
-
Summary: Improve Gauge support in metrics
Key: SLING-10967
URL: https://issues.apache.org/jira/browse/SLING-10967
Project: Sling
Issue Type: Improvement
sonarcloud[bot] commented on pull request #53:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-986600615
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #53:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-986562159
SonarCloud Quality Gate failed. ![Quality Gate
Hi,
IMHO SLING-6584 is only about the race condition with set and reset. If we get
rid of resetting the field accessibility this can no longer occur.
Also the test which has been added in the context of SLING-6584 should show
nicely that synchronisation is not necessary without reset.
I am also
good point about SLING-6584 - here is the related commit [2].
the code that was in place before did the setAcccessible(false) without
synchronization - this is indeed a threading issue as the Field reflection
object is not thread-safe.
so our recommendation is to remove both synchronization and
Hi Carsten,
On Sat, 2021-12-04 at 15:06 +0100, Carsten Ziegeler wrote:
> Hi,
>
> I'm fine with whatever solution we can agree on, however if we
> promote a
> docker based solution we increase the requirements (installed tools)
> to
> be able to run the starter. Now, I guess everyone will now
On Mon, 2021-12-06 at 10:20 +0100, Robert Munteanu wrote:
> The injection
I meant the synchronisation.
Hi Paul,
On Sat, 2021-12-04 at 21:38 -0600, Paul Bjorkstrand wrote:
> I added in using MethodHandles in the tests, just to show the
> difference.
> When Sling stops supporting Java 8, we can move to MethodHandle which
> has
> significantly better performance characteristics. Unfortunately, we
>
Hi,
The injection seems to have been added with [1]. I think it's worth
checking if that issue is still a problem.
Thanks,
Robert
[1]: https://issues.apache.org/jira/browse/SLING-6584
On Mon, 2021-12-06 at 09:13 +, Stefan Seifert wrote:
> hello paul.
>
> thanks for doing all this testing.
hello paul.
thanks for doing all this testing. i also think it's not worth bothering to
reset a field to non-accessible if it was set to accessible, and requiring a
synchronization block for this. we should remove the synchronization and the
setAccessible(false). it's a performance gain and
[
https://issues.apache.org/jira/browse/SLING-10951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed SLING-10951.
--
> sling-mock: Get rid of "Deprecated service mapping by userId" warnings
>
[
https://issues.apache.org/jira/browse/SLING-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed SLING-10950.
--
> sling-mock: Make compatible with Sling API 2.24.0, Resource Resolver 1.8.0,
> Adapter 2.2.0,
Hi,
The vote has passed with the following result :
+1 (binding): Stefan, Robert Munteanu, Carsten Ziegeler
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
stefan
sonarcloud[bot] removed a comment on pull request #53:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-986039409
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #53:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/53#issuecomment-986562159
SonarCloud Quality Gate failed. 